Skip to contentSkip to conversation

ALSA: hda: cs35l56: Don't use the device index as a calibration index

PATCH Applied Simon Trimmer 2 participants 2 messages Aug 21, 2024 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda: cs35l56: Don't use the device index as a calibration index

The HDA driver cannot assume that the order that the devices are specified in the cirrus,dev-index matches the order of calibration entries.

Only a calibration entry with a matching silicon id will be used.

Fixes cfa43aaa7948 ("ALSA: hda: cs35l56: Apply amp calibration from EFI data")
---
 sound/pci/hda/cs35l56_hda.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/hda/cs35l56_hda.c +1 -1
index a9dfd62637cf..e3ac0e23ae32 100644
@@ -1003,7 +1003,7 @@ int cs35l56_hda_common_probe(struct cs35l56_hda *cs35l56, int hid, int id)
 		goto err;
 	}
 
-	cs35l56->base.cal_index = cs35l56->index;
+	cs35l56->base.cal_index = -1;
 
 	cs35l56_init_cs_dsp(&cs35l56->base, &cs35l56->cs_dsp);
 	cs35l56->cs_dsp.client_ops = &cs35l56_hda_client_ops;
Signature · 1 line
2.43.0
Applied
#1 lore raw
Quoted 9 lines · Simon Trimmer

The HDA driver cannot assume that the order that the devices are specified in the cirrus,dev-index matches the order of calibration entries.

Only a calibration entry with a matching silicon id will be used.

Fixes cfa43aaa7948 ("ALSA: hda: cs35l56: Apply amp calibration from EFI data")

Thanks, applied now.

Takashi