tcp: avoid reusing FIN_WAIT2 when trying to find port in connect() process
Subsystems (3)
PATCH v3 1/1 tcp: avoid reusing FIN_WAIT2 when trying to find port in connect() process
From: Jason Xing <[email protected]>
We found that one close-wait socket was reset by the other side due to a new connection reusing the same port which is beyond our expectation, so we have to investigate the underlying reason.
The following experiment is conducted in the test environment. We limit the port range from 40000 to 40010 and delay the time to close() after receiving a fin from the active close side, which can help us easily reproduce like what happened in production.
Here are three connections captured by tcpdump:
127.0.0.1.40002 > 127.0.0.1.9999: Flags [S], seq 2965525191 127.0.0.1.9999 > 127.0.0.1.40002: Flags [S.], seq 2769915070 127.0.0.1.40002 > 127.0.0.1.9999: Flags [.], ack 1 127.0.0.1.40002 > 127.0.0.1.9999: Flags [F.], seq 1, ack 1 // a few seconds later, within 60 seconds 127.0.0.1.40002 > 127.0.0.1.9999: Flags [S], seq 2965590730 127.0.0.1.9999 > 127.0.0.1.40002: Flags [.], ack 2 127.0.0.1.40002 > 127.0.0.1.9999: Flags [R], seq 2965525193 // later, very quickly
127.0.0.1.40002 > 127.0.0.1.9999: Flags [S], seq 2965590730 127.0.0.1.9999 > 127.0.0.1.40002: Flags [S.], seq 3120990805 127.0.0.1.40002 > 127.0.0.1.9999: Flags [.], ack 1
As we can see, the first flow is reset because:
1) client starts a new connection, I mean, the second one
2) client tries to find a suitable port which is a timewait socket (its state is timewait, substate is fin_wait2)
3) client occupies that timewait port to send a SYN
4) server finds a corresponding close-wait socket in ehash table, then replies with a challenge ack
5) client sends an RST to terminate this old close-wait socket.
I don't think the port selection algo can choose a FIN_WAIT2 socket when we turn on tcp_tw_reuse because on the server side there remain unread data. In some cases, if one side haven't call close() yet, we should not consider it as expendable and treat it at will.
Even though, sometimes, the server isn't able to call close() as soon as possible like what we expect, it can not be terminated easily, especially due to a second unrelated connection happening.
After this patch, we can see the expected failure if we start a connection when all the ports are occupied in fin_wait2 state:
"Ncat: Cannot assign requested address."
---
v3
1. take the ipv6 case into consideration. (Eric)
v2
1. change from fin_wait2 to timewait test statement, no functional change (Kuniyuki)
--- net/ipv4/tcp_ipv4.c | 3 +++ 1 file changed, 3 insertions(+)
net/ipv4/tcp_ipv4.c +3 -0
@@ -144,6 +144,9 @@ int tcp_twsk_unique(struct sock *sk, struct sock *sktw, void *twp) reuse =0 ; } +if (tw->tw_substate ==TCP_FIN_WAIT2 ) + reuse =0 ; +/* With PAWS, it is safe from the viewpoint of data integrity. Even without PAWS it is safe provided sequence spaces do not overlap i.e. at data rates <= 80Mbit/sec.
Signature · 1 line
2.37.3
Quoted 68 lines · Jason Xing
From: Jason Xing <[email protected]>
We found that one close-wait socket was reset by the other side due to a new connection reusing the same port which is beyond our expectation, so we have to investigate the underlying reason.
The following experiment is conducted in the test environment. We limit the port range from 40000 to 40010 and delay the time to
close()after receiving a fin from the active close side, which can help us easily reproduce like what happened in production.Here are three connections captured by tcpdump:
127.0.0.1.40002 > 127.0.0.1.9999: Flags [S], seq 2965525191 127.0.0.1.9999 > 127.0.0.1.40002: Flags [S.], seq 2769915070 127.0.0.1.40002 > 127.0.0.1.9999: Flags [.], ack 1 127.0.0.1.40002 > 127.0.0.1.9999: Flags [F.], seq 1, ack 1 // a few seconds later, within 60 seconds 127.0.0.1.40002 > 127.0.0.1.9999: Flags [S], seq 2965590730 127.0.0.1.9999 > 127.0.0.1.40002: Flags [.], ack 2 127.0.0.1.40002 > 127.0.0.1.9999: Flags [R], seq 2965525193 // later, very quickly
127.0.0.1.40002 > 127.0.0.1.9999: Flags [S], seq 2965590730 127.0.0.1.9999 > 127.0.0.1.40002: Flags [S.], seq 3120990805 127.0.0.1.40002 > 127.0.0.1.9999: Flags [.], ack 1As we can see, the first flow is reset because:
1) client starts a new connection, I mean, the second one
2) client tries to find a suitable port which is a timewait socket (its state is timewait, substate isfin_wait2)
3) client occupies that timewait port to send a SYN
4) server finds a corresponding close-wait socket in ehash table, then replies with a challenge ack
5) client sends an RST to terminate this old close-wait socket.I don't think the port selection algo can choose a
FIN_WAIT2socket when we turn ontcp_tw_reusebecause on the server side there remain unread data. In some cases, if one side haven't callclose()yet, we should not consider it as expendable and treat it at will.Even though, sometimes, the server isn't able to call
close()as soon as possible like what we expect, it can not be terminated easily, especially due to a second unrelated connection happening.After this patch, we can see the expected failure if we start a connection when all the ports are occupied in
fin_wait2state:
"Ncat: Cannot assign requested address."Reported-by Jade Dong <[email protected]>Signed-off-by Jason Xing <[email protected]>---
v31. take the ipv6 case into consideration. (Eric)
v2
1. change from
fin_wait2to timewait test statement, no functional change (Kuniyuki)--- net/ipv4/tcp_ipv4.c | 3 +++ 1 file changed, 3 insertions(+)net/ipv4/tcp_ipv4.c +0
-0
net/ipv4/tcp_ipv4.c int tcp_twsk_unique(struct sock *sk, struct sock *sktw, void *twp) · line 149
Quoted 6 lines
net/ipv4/tcp_ipv4.c +3
-0@@ -144,6 +144,9 @@ int tcp_twsk_unique(struct sock *sk, struct sock *sktw, void *twp) reuse =0 ; } +if (tw->tw_substate ==TCP_FIN_WAIT2 ) + reuse =0 ; +
sysctl_tcp_tw_reuse default value being 2, I would suggest doing this test earlier,
to avoid unneeded work.
net/ipv4/tcp_ipv4.c +0 -0
100644
net/ipv4/tcp_ipv4.c +0 -0
@@ -118,6 +118,9 @@ int tcp_twsk_unique(struct sock *sk, struct sock
*sktw, void *twp)
struct tcp_sock *tp = tcp_sk(sk);
int ts_recent_stamp;+ if (tw->tw_substate == TCP_FIN_WAIT2)
+ reuse = 0;
+
if (reuse == 2) {
/* Still does not detect *everything* that goes through
* lo, since we require a loopback src or dst addressQuoted 73 lines · Eric Dumazet
Quoted 71 lines · Jason Xing
From: Jason Xing <[email protected]>
We found that one close-wait socket was reset by the other side due to a new connection reusing the same port which is beyond our expectation, so we have to investigate the underlying reason.
The following experiment is conducted in the test environment. We limit the port range from 40000 to 40010 and delay the time to
close()after receiving a fin from the active close side, which can help us easily reproduce like what happened in production.Here are three connections captured by tcpdump:
127.0.0.1.40002 > 127.0.0.1.9999: Flags [S], seq 2965525191 127.0.0.1.9999 > 127.0.0.1.40002: Flags [S.], seq 2769915070 127.0.0.1.40002 > 127.0.0.1.9999: Flags [.], ack 1 127.0.0.1.40002 > 127.0.0.1.9999: Flags [F.], seq 1, ack 1 // a few seconds later, within 60 seconds 127.0.0.1.40002 > 127.0.0.1.9999: Flags [S], seq 2965590730 127.0.0.1.9999 > 127.0.0.1.40002: Flags [.], ack 2 127.0.0.1.40002 > 127.0.0.1.9999: Flags [R], seq 2965525193 // later, very quickly
127.0.0.1.40002 > 127.0.0.1.9999: Flags [S], seq 2965590730 127.0.0.1.9999 > 127.0.0.1.40002: Flags [S.], seq 3120990805 127.0.0.1.40002 > 127.0.0.1.9999: Flags [.], ack 1As we can see, the first flow is reset because:
1) client starts a new connection, I mean, the second one
2) client tries to find a suitable port which is a timewait socket (its state is timewait, substate isfin_wait2)
3) client occupies that timewait port to send a SYN
4) server finds a corresponding close-wait socket in ehash table, then replies with a challenge ack
5) client sends an RST to terminate this old close-wait socket.I don't think the port selection algo can choose a
FIN_WAIT2socket when we turn ontcp_tw_reusebecause on the server side there remain unread data. In some cases, if one side haven't callclose()yet, we should not consider it as expendable and treat it at will.Even though, sometimes, the server isn't able to call
close()as soon as possible like what we expect, it can not be terminated easily, especially due to a second unrelated connection happening.After this patch, we can see the expected failure if we start a connection when all the ports are occupied in
fin_wait2state:
"Ncat: Cannot assign requested address."Reported-by Jade Dong <[email protected]>Signed-off-by Jason Xing <[email protected]>---
v31. take the ipv6 case into consideration. (Eric)
v2
1. change from
fin_wait2to timewait test statement, no functional change (Kuniyuki)--- net/ipv4/tcp_ipv4.c | 3 +++ 1 file changed, 3 insertions(+)net/ipv4/tcp_ipv4.c +0
-0@@ -144,6 +144,9 @@ int tcp_twsk_unique(struct sock *sk, struct sock *sktw, void *twp) reuse =0 ; }
Quoted 7 lines
net/ipv4/tcp_ipv4.c int tcp_twsk_unique(struct sock *sk, struct sock *sktw, void *twp) · line 149
Quoted 3 lines
net/ipv4/tcp_ipv4.c +3
-0+if (tw->tw_substate ==TCP_FIN_WAIT2 ) + reuse =0 ; +
sysctl_tcp_tw_reusedefault value being 2, I would suggest doing this test earlier,
to avoid unneeded work.
Thanks. I should have thought of that. I will submit it ~24 hours later.
Thanks,
Jason
Quoted 17 lines
net/ipv4/tcp_ipv4.c +0
-0100644
net/ipv4/tcp_ipv4.c +3
-0@@ -118,6 +118,9 @@ int tcp_twsk_unique(struct sock *sk, struct sock *sktw, void *twp)struct tcp_sock *tp =tcp_sk (sk);int ts_recent_stamp; +if (tw->tw_substate ==TCP_FIN_WAIT2 ) + reuse =0 ; +if (reuse ==2 ) {/* Still does not detect *everything* that goes through * lo, since we require a loopback src or dst address