Skip to contentSkip to conversation

power: sequencing: qcom-wcn: set the wlan-enable GPIO to output

PATCH In review Bartosz Golaszewski 1 participant 2 messages Aug 23, 2024 – Aug 24, 2024 Power sequencing

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 power: sequencing: qcom-wcn: set the wlan-enable GPIO to output

From: Bartosz Golaszewski <[email protected]>

Commit a9aaf1ff88a8 ("power: sequencing: request the WLAN enable GPIO as-is") broke WLAN on boards on which the wlan-enable GPIO enabling the wifi module isn't in output mode by default. We need to set direction to output while retaining the value that was already set to keep the ath module on if it's already started.

Fixes a9aaf1ff88a8 ("power: sequencing: request the WLAN enable GPIO as-is")
---
 drivers/power/sequencing/pwrseq-qcom-wcn.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/power/sequencing/pwrseq-qcom-wcn.c +7 -0
index d786cbf1b2cd..700879474abf 100644
@@ -288,6 +288,13 @@ static int pwrseq_qcom_wcn_probe(struct platform_device *pdev)
 		return dev_err_probe(dev, PTR_ERR(ctx->wlan_gpio),
 				     "Failed to get the WLAN enable GPIO\n");
 
+	/*
+	 * Set direction to output but keep the current value in order to not
+	 * disable the WLAN module accidentally if it's already powered on.
+	 */
+	gpiod_direction_output(ctx->wlan_gpio,
+			       gpiod_get_value_cansleep(ctx->wlan_gpio));
+
 	ctx->clk = devm_clk_get_optional(dev, NULL);
 	if (IS_ERR(ctx->clk))
 		return dev_err_probe(dev, PTR_ERR(ctx->clk),
Signature · 1 line
2.43.0
#1 lore raw

From: Bartosz Golaszewski <[email protected]>

Quoted 8 lines · Bartosz Golaszewski

Commit a9aaf1ff88a8 ("power: sequencing: request the WLAN enable GPIO as-is") broke WLAN on boards on which the wlan-enable GPIO enabling the wifi module isn't in output mode by default. We need to set direction to output while retaining the value that was already set to keep the ath module on if it's already started.

[...]

I'll be OoO next week and don't want to leave it broken in next so I'm applying it fast.

[1/1] power: sequencing: qcom-wcn: set the wlan-enable GPIO to output

      commit: 06802616488c980a63084e53f401cfc8a65672a7

Best regards,

Signature · 1 line
Bartosz Golaszewski <[email protected]>