Skip to contentSkip to conversation

drm/connector: hdmi: Increase HDMI_MAX_INFOFRAME_SIZE to 30

PATCH Superseded Derek Foreman 2 participants 2 messages Aug 23, 2024

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/connector: hdmi: Increase HDMI_MAX_INFOFRAME_SIZE to 30

The DRM infoframe is 26 bytes, with a 4 byte header this gives us 30. The current limit of 29 prevents us from writing DRM infoframes.

---
 drivers/gpu/drm/display/drm_hdmi_state_helper.c | 2 +-
 drivers/gpu/drm/drm_debugfs.c                   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/display/drm_hdmi_state_helper.c +1 -1
index 7854820089ec..cc7747d33fdf 100644
@@ -521,7 +521,7 @@ int drm_atomic_helper_connector_hdmi_check(struct drm_connector *connector,
 }
 EXPORT_SYMBOL(drm_atomic_helper_connector_hdmi_check);
 
-#define HDMI_MAX_INFOFRAME_SIZE		29
+#define HDMI_MAX_INFOFRAME_SIZE		30
 
 static int clear_device_infoframe(struct drm_connector *connector,
 				  enum hdmi_infoframe_type type)
drivers/gpu/drm/drm_debugfs.c +1 -1
index 6b239a24f1df..3439fd65275a 100644
@@ -520,7 +520,7 @@ static const struct file_operations drm_connector_fops = {
 	.write = connector_write
 };
 
-#define HDMI_MAX_INFOFRAME_SIZE		29
+#define HDMI_MAX_INFOFRAME_SIZE		30
 
 static ssize_t
 audio_infoframe_read(struct file *filp, char __user *ubuf, size_t count, loff_t *ppos)
Signature · 1 line
2.45.2
#1 lore raw
Quoted 2 lines · Derek Foreman

The DRM infoframe is 26 bytes, with a 4 byte header this gives us 30. The current limit of 29 prevents us from writing DRM infoframes.

Some more details would be useful. Which infoframe, etc.

BR,
Jani.

Quoted 33 lines
---
 drivers/gpu/drm/display/drm_hdmi_state_helper.c | 2 +-
 drivers/gpu/drm/drm_debugfs.c                   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/display/drm_hdmi_state_helper.c +1 -1
index 7854820089ec..cc7747d33fdf 100644
@@ -521,7 +521,7 @@ int drm_atomic_helper_connector_hdmi_check(struct drm_connector *connector,
 }
 EXPORT_SYMBOL(drm_atomic_helper_connector_hdmi_check);
 
-#define HDMI_MAX_INFOFRAME_SIZE		29
+#define HDMI_MAX_INFOFRAME_SIZE		30
 
 static int clear_device_infoframe(struct drm_connector *connector,
 				  enum hdmi_infoframe_type type)
drivers/gpu/drm/drm_debugfs.c +1 -1
index 6b239a24f1df..3439fd65275a 100644
@@ -520,7 +520,7 @@ static const struct file_operations drm_connector_fops = {
 	.write = connector_write
 };
 
-#define HDMI_MAX_INFOFRAME_SIZE		29
+#define HDMI_MAX_INFOFRAME_SIZE		30
 
 static ssize_t
 audio_infoframe_read(struct file *filp, char __user *ubuf, size_t count, loff_t *ppos)
Signature · 1 line
Jani Nikula, Intel