Skip to contentSkip to conversation

staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c:681

PATCH Superseded Alien Wesley 4 participants 6 messages Aug 25, 2024 – Aug 29, 2024 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Alien Wesley

author
#0 lore raw

PATCH 1/1 staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c:681

Separated assignments for pairwise_key_type and group_key_type in order to silence the following checkpatch warning.

CHECK: Assignment operator '=' should be on the previous line.

Signed-off-by Alien Wesley <[email protected]>
---
 drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c +2 -2
index 47f1adf30ab4..2d42e7a5bcdb 100644
@@ -677,8 +677,8 @@ static int _rtl92e_wx_set_encode_ext(struct net_device *dev,
 
 		if ((encoding->flags & IW_ENCODE_DISABLED) ||
 		    ext->alg == IW_ENCODE_ALG_NONE) {
-			ieee->pairwise_key_type = ieee->group_key_type
-						= KEY_TYPE_NA;
+			ieee->pairwise_key_type = KEY_TYPE_NA;
+			ieee->group_key_type = KEY_TYPE_NA;
 			rtl92e_cam_reset(dev);
 			memset(priv->rtllib->swcamtable, 0,
 			       sizeof(struct sw_cam_table) * 32);
Signature · 1 line
2.34.1
Tested-by on v1 1/1
#1 lore raw
Quoted 15 lines · Alien Wesley

Separated assignments for pairwise_key_type and group_key_type in order to silence the following checkpatch warning.

CHECK: Assignment operator '=' should be on the previous line.

Signed-off-by Alien Wesley <[email protected]>
---
  drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c +0 -0
index 47f1adf30ab4..2d42e7a5bcdb 100644

drivers/staging/rtl8192e/rtl8192e/rtl_wx.c static int _rtl92e_wx_set_encode_ext(struct net_device *dev, · line 684

Quoted 10 lines
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c +2 -2
@@ -677,8 +677,8 @@ static int _rtl92e_wx_set_encode_ext(struct net_device *dev,
 
  		if ((encoding->flags & IW_ENCODE_DISABLED) ||
  		    ext->alg == IW_ENCODE_ALG_NONE) {
-			ieee->pairwise_key_type = ieee->group_key_type
-						= KEY_TYPE_NA;
+			ieee->pairwise_key_type = KEY_TYPE_NA;
+			ieee->group_key_type = KEY_TYPE_NA;
  			rtl92e_cam_reset(dev);
  			memset(priv->rtllib->swcamtable, 0,
  			       sizeof(struct sw_cam_table) * 32);
Tested-by Philipp Hortmann <[email protected]>
maintainer
#2 lore raw
In reply to Alien Wesley
Quoted 6 lines · Alien Wesley

Separated assignments for pairwise_key_type and group_key_type in order to silence the following checkpatch warning.

CHECK: Assignment operator '=' should be on the previous line.

Signed-off-by Alien Wesley <[email protected]>

Please do not put line numbers in the subject line.

thanks,

greg k-h

author
#3 lore raw
Quoted 4 lines · Greg KH
Quoted 3 lines · Alien Wesley

Separated assignments for pairwise_key_type and group_key_type in order to silence the following checkpatch warning.

Quoted 8 lines
Quoted 3 lines

CHECK: Assignment operator '=' should be on the previous line.

Signed-off-by Alien Wesley <[email protected]>

Please do not put line numbers in the subject line.

thanks,

greg k-h

Should I fix up the subject and resend it as v2?

Alien Wesley

maintainer
#4 lore raw
Quoted 7 lines · Alien Wesley
Quoted 6 lines · Greg KH
Quoted 5 lines · Alien Wesley

Separated assignments for pairwise_key_type and group_key_type in order to silence the following checkpatch warning.

CHECK: Assignment operator '=' should be on the previous line.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Signed-off-by Alien Wesley <[email protected]>

Please do not put line numbers in the subject line.

thanks,

greg k-h

Should I fix up the subject and resend it as v2?

Please do.

#5 lore raw
In reply to Alien Wesley
Quoted 7 lines · Alien Wesley
Quoted 6 lines · Greg KH
Quoted 5 lines · Alien Wesley

Separated assignments for pairwise_key_type and group_key_type in order to silence the following checkpatch warning.

CHECK: Assignment operator '=' should be on the previous line.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Signed-off-by Alien Wesley <[email protected]>

Please do not put line numbers in the subject line.

thanks,

greg k-h

Should I fix up the subject and resend it as v2?

Yes.

regards,
dan carpenter