Skip to contentSkip to conversation

arm64: dts: rockchip: remove unnecessary properties for Radxa ROCK 5A

PATCH Applied FUKAUMI Naoki 3 participants 3 messages Aug 26, 2024 – Aug 28, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: remove unnecessary properties for Radxa ROCK 5A

There is no "on-board WLAN/BT chip" on Radxa ROCK 5A. remove related properties.

Fixes 1642bf66e270 ("arm64: dts: rockchip: add USB2 to rk3588s-rock5a")
---
 .../boot/dts/rockchip/rk3588s-rock-5a.dts     | 24 -------------------
 1 file changed, 24 deletions(-)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +0 -24
index 03ed48246d36..953a722198fe 100644
@@ -317,28 +317,6 @@ vcc5v0_host_en: vcc5v0-host-en {
 			rockchip,pins = <4 RK_PB5 RK_FUNC_GPIO &pcfg_pull_none>;
 		};
 	};
-
-	wifibt {
-		wl_reset: wl-reset {
-			rockchip,pins = <0 RK_PD0 RK_FUNC_GPIO &pcfg_pull_up>;
-		};
-
-		wl_dis: wl-dis {
-			rockchip,pins = <0 RK_PD5 RK_FUNC_GPIO &pcfg_output_high>;
-		};
-
-		wl_wake_host: wl-wake-host {
-			rockchip,pins = <0 RK_PC7 RK_FUNC_GPIO &pcfg_pull_up>;
-		};
-
-		bt_dis: bt-dis {
-			rockchip,pins = <0 RK_PD4 RK_FUNC_GPIO &pcfg_output_high>;
-		};
-
-		bt_wake_host: bt-wake-host {
-			rockchip,pins = <0 RK_PC5 RK_FUNC_GPIO &pcfg_pull_up>;
-		};
-	};
 };
 
 &pwm3 {
@@ -754,8 +732,6 @@ &usbdp_phy0 {
 
 &usb_host0_ehci {
 	status = "okay";
-	pinctrl-names = "default";
-	pinctrl-0 = <&wl_reset &wl_dis &wl_wake_host &bt_dis &bt_wake_host>;
 };
 
 &usb_host0_ohci {
Signature · 7 lines
2.43.0


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
maintainer Applied
#1 lore raw
Quoted 4 lines · FUKAUMI Naoki

There is no "on-board WLAN/BT chip" on Radxa ROCK 5A. remove related properties.

Applied, thanks!

[1/1] arm64: dts: rockchip: remove unnecessary properties for Radxa ROCK 5A

      commit: b8ac0cf405c2092decc5cc102ed3a2d5d3200ab4

Best regards,

Signature · 6 lines
Heiko Stuebner <[email protected]>

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
#2 lore raw

Hi,

Quoted 8 lines · Heiko Stuebner
Quoted 2 lines · FUKAUMI Naoki

There is no "on-board WLAN/BT chip" on Radxa ROCK 5A. remove related properties.

Applied, thanks!

[1/1] arm64: dts: rockchip: remove unnecessary properties for Radxa ROCK 5A

      commit: b8ac0cf405c2092decc5cc102ed3a2d5d3200ab4

Oops, good find. I didn't notice this feature did not make it into the final ROCK 5A. I have a pre-production version of this board (which does have a WLAN/BT chip).

I did notice that the M.2 slot was changed between my version and the one being sold, that's why I never send PCIe patches. That might be something for you to look into Naoki?

Greetings,

-- Sebastian

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip