Skip to contentSkip to conversation

imx: Remove CFG_MXC_USB_FLAGS

PATCH Superseded Fabio Estevam 4 participants 8 messages Aug 27, 2024

Subsystems (4)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/3 imx: Remove CFG_MXC_USB_FLAGS

From: Fabio Estevam <[email protected]>

CFG_MXC_USB_FLAGS is only used for drivers/usb/host/ehci-mx5.c, so it can be removed from all the imx6/imx7/imx8m board config files.

mx51evk.h is the only place CFG_MXC_USB_FLAGS is not set to 0.

---
 include/configs/apalis_imx6.h            | 1 -
 include/configs/aristainetos2.h          | 1 -
 include/configs/cl-som-imx7.h            | 1 -
 include/configs/cm_fx6.h                 | 1 -
 include/configs/colibri-imx6ull.h        | 1 -
 include/configs/colibri_imx6.h           | 1 -
 include/configs/colibri_imx7.h           | 1 -
 include/configs/dart_6ul.h               | 1 -
 include/configs/dh_imx6.h                | 1 -
 include/configs/embestmx6boards.h        | 1 -
 include/configs/ge_b1x5v2.h              | 1 -
 include/configs/gw_ventana.h             | 1 -
 include/configs/imx6_logic.h             | 1 -
 include/configs/imx6dl-mamoj.h           | 1 -
 include/configs/imx6q-bosch-acc.h        | 1 -
 include/configs/kontron-sl-mx6ul.h       | 1 -
 include/configs/kontron-sl-mx8mm.h       | 1 -
 include/configs/kp_imx53.h               | 1 -
 include/configs/kp_imx6q_tpc.h           | 1 -
 include/configs/liteboard.h              | 1 -
 include/configs/m53menlo.h               | 1 -
 include/configs/mx53cx9020.h             | 1 -
 include/configs/mx53loco.h               | 1 -
 include/configs/mx53ppd.h                | 1 -
 include/configs/mx6sabreauto.h           | 1 -
 include/configs/mx6sabresd.h             | 1 -
 include/configs/mx6slevk.h               | 1 -
 include/configs/mx6sxsabreauto.h         | 1 -
 include/configs/mx6sxsabresd.h           | 1 -
 include/configs/mx6ul_14x14_evk.h        | 1 -
 include/configs/mys_6ulx.h               | 1 -
 include/configs/nitrogen6x.h             | 1 -
 include/configs/novena.h                 | 1 -
 include/configs/npi_imx6ull.h            | 1 -
 include/configs/opos6uldev.h             | 1 -
 include/configs/pcl063.h                 | 1 -
 include/configs/pcl063_ull.h             | 1 -
 include/configs/pico-imx6.h              | 1 -
 include/configs/pico-imx6ul.h            | 1 -
 include/configs/pico-imx7d.h             | 1 -
 include/configs/somlabs_visionsom_6ull.h | 1 -
 include/configs/usbarmory.h              | 1 -
 include/configs/vining_2000.h            | 1 -
 include/configs/wandboard.h              | 1 -
 include/configs/xpress.h                 | 1 -
 45 files changed, 45 deletions(-)
include/configs/apalis_imx6.h +0 -1
index 6fd43511ee4d..097f819e44a4 100644
@@ -26,7 +26,6 @@
 /* USB Configs */
 /* Host */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 /* Framebuffer and LCD */
 
include/configs/aristainetos2.h +0 -1
index 9d4a4bbdf43c..120ff9284ef6 100644
@@ -413,7 +413,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS	0
 
 /* UBI support */
 
include/configs/cl-som-imx7.h +0 -1
index 280ae1e9cca8..96058d48148b 100644
@@ -97,6 +97,5 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS   0
 
 #endif	/* __CONFIG_H */
include/configs/cm_fx6.h +0 -1
index 7d0f2b6dc13a..fc2d59751c42 100644
@@ -136,7 +136,6 @@
 
 /* USB */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 /* Boot */
 #define CFG_SYS_BOOTMAPSZ	        (8 << 20)
include/configs/colibri-imx6ull.h +0 -1
index 8860ceec1a0a..c896a897cbf4 100644
@@ -120,7 +120,6 @@
 /* USB Configs */
 
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 /* USB Device Firmware Update support */
 #define DFU_DEFAULT_POLL_TIMEOUT	300
include/configs/colibri_imx6.h +0 -1
index 79e5b870b812..87c973883c33 100644
@@ -24,7 +24,6 @@
 /* USB Configs */
 /* Host */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 /* Command definition */
 
include/configs/colibri_imx7.h +0 -1
index 33133a0b96e1..0e0665038b1f 100644
@@ -162,6 +162,5 @@
 /* USB Configs */
 
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 #endif
include/configs/dart_6ul.h +0 -1
index c5781670864b..4d715d4f425e 100644
@@ -48,7 +48,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 #define ENV_MMC \
 	"mmcdev=" __stringify(MMC_ROOTFS_DEV) "\0" \
include/configs/dh_imx6.h +0 -1
index 4b5ef4ad5100..dc5ca9fc60cd 100644
@@ -32,7 +32,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 /* USB Gadget (DFU, UMS) */
 #if defined(CONFIG_CMD_DFU) || defined(CONFIG_CMD_USB_MASS_STORAGE)
include/configs/embestmx6boards.h +0 -1
index 31c7e104f6b8..e378374a004a 100644
@@ -19,7 +19,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS	0
 
 /* MMC Configs */
 #define CFG_SYS_FSL_ESDHC_ADDR      0
include/configs/ge_b1x5v2.h +0 -1
index 49b058cb10d4..0bf31897a744 100644
@@ -25,7 +25,6 @@
 
 /* USB */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 /* Memory */
 #define PHYS_SDRAM		       MMDC0_ARB_BASE_ADDR
include/configs/gw_ventana.h +0 -1
index ebc5d03d0d5c..f884d74d9ca9 100644
@@ -37,7 +37,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC     (PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS      0
 
 /* Miscellaneous configurable options */
 
include/configs/imx6_logic.h +0 -1
index 66004a6eb2a3..19613e838fb3 100644
@@ -117,7 +117,6 @@
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 #endif
 
 /* Falcon Mode */
include/configs/imx6dl-mamoj.h +0 -1
index 6c61b3f44801..6651653d5e9c 100644
@@ -44,7 +44,6 @@
 
 /* USB */
 #define CFG_MXC_USB_PORTSC			(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS			0
 
 /* Falcon */
 
include/configs/imx6q-bosch-acc.h +0 -1
index 2c998cdcfc72..aa365dc9a795 100644
@@ -111,6 +111,5 @@
 #endif
 
 #define CFG_MXC_USB_PORTSC            (PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS             0
 
 #endif /* __IMX6Q_ACC_H */
include/configs/kontron-sl-mx6ul.h +0 -1
index 1c92cd787677..e68c667c5057 100644
@@ -26,7 +26,6 @@
 
 #ifdef CONFIG_USB_EHCI_HCD
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 #endif
 
 /* Boot order for distro boot */
include/configs/kontron-sl-mx8mm.h +0 -1
index eee3d2ddb037..be1f70a9a598 100644
@@ -26,7 +26,6 @@
 
 #ifdef CONFIG_USB_EHCI_HCD
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 #endif
 
 /* GUID for capsule updatable firmware image */
include/configs/kp_imx53.h +0 -1
index 6e383cbe75f7..91caf03091c4 100644
@@ -12,7 +12,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS	0
 
 /* Command definition */
 
include/configs/kp_imx6q_tpc.h +0 -1
index 1aa4b8ab5987..74f6e4e9f963 100644
@@ -19,7 +19,6 @@
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 #endif
 
 #define CFG_EXTRA_ENV_SETTINGS	\
include/configs/liteboard.h +0 -1
index 5811059c8e2b..25c30e6c6a5d 100644
@@ -96,7 +96,6 @@
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS   0
 #endif
 
 #ifdef CONFIG_CMD_NET
include/configs/m53menlo.h +0 -1
index 9cf46b2c3624..1491c509820d 100644
@@ -72,7 +72,6 @@
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORT		1
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 #endif
 
 /* LVDS display */
include/configs/mx53cx9020.h +0 -1
index dccfdc3a15da..ab6b0b65556e 100644
@@ -24,7 +24,6 @@
 /* USB Configs */
 #define CFG_MXC_USB_PORT	1
 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS	0
 
 /* Command definition */
 
include/configs/mx53loco.h +0 -1
index 7398804e6b54..04f4b7232099 100644
@@ -19,7 +19,6 @@
 /* USB Configs */
 #define CFG_MXC_USB_PORT	1
 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS	0
 
 /* PMIC Controller */
 #define CFG_SYS_DIALOG_PMIC_I2C_ADDR	0x48
include/configs/mx53ppd.h +0 -1
index df65dbeea41c..3c9a9fb045b6 100644
@@ -14,7 +14,6 @@
 /* USB Configs */
 #define CFG_MXC_USB_PORT	1
 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS	0
 
 /* Command definition */
 
include/configs/mx6sabreauto.h +0 -1
index 91544c8a0e23..eb963cbb0b3b 100644
@@ -13,7 +13,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS	0
 
 #define CFG_SYS_I2C_PCA953X_WIDTH	{ {0x30, 8}, {0x32, 8}, {0x34, 8} }
 
include/configs/mx6sabresd.h +0 -1
index 844f10e4229f..9160f878f4b3 100644
@@ -27,7 +27,6 @@
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 #endif
 
 #endif                         /* __MX6SABRESD_CONFIG_H */
include/configs/mx6slevk.h +0 -1
index 490d9feb805b..65c6cdd4b87b 100644
@@ -91,7 +91,6 @@
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 #endif
 
 #define CFG_SYS_FSL_USDHC_NUM	3
include/configs/mx6sxsabreauto.h +0 -1
index 1c14a6beb0ac..4e163d28e63d 100644
@@ -97,7 +97,6 @@
 
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS   0
 #endif
 
 #define CFG_SYS_FSL_USDHC_NUM	2
include/configs/mx6sxsabresd.h +0 -1
index fe0ad34ef9c1..b43a1d813151 100644
@@ -119,7 +119,6 @@
 
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS   0
 #endif
 
 #ifdef CONFIG_CMD_PCI
include/configs/mx6ul_14x14_evk.h +0 -1
index 98b743b93644..fd0c87ffb012 100644
@@ -117,7 +117,6 @@
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS   0
 #endif
 
 #ifdef CONFIG_CMD_NET
include/configs/mys_6ulx.h +0 -1
index 2571098d06c6..8defdfc4fda6 100644
@@ -31,7 +31,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 #define CFG_EXTRA_ENV_SETTINGS \
 	"console=ttymxc0,115200n8\0" \
include/configs/nitrogen6x.h +0 -1
index c03d11dcdaec..a8ad85050f79 100644
@@ -20,7 +20,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS	0
 
 #ifdef CONFIG_CMD_MMC
 #define DISTRO_BOOT_DEV_MMC(func) func(MMC, mmc, 0) func(MMC, mmc, 1)
include/configs/novena.h +0 -1
index 39d3afd1c8ee..144cf1b4a4b8 100644
@@ -54,7 +54,6 @@
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 #endif
 
 /* Extra U-Boot environment. */
include/configs/npi_imx6ull.h +0 -1
index 5f933391cc01..f71e2657076b 100644
@@ -30,7 +30,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 #ifdef CONFIG_CMD_NET
 #define CFG_FEC_MXC_PHYADDR		0x1
include/configs/opos6uldev.h +0 -1
index 1edb1826c4e8..12020d31e1c7 100644
@@ -20,7 +20,6 @@
 /* USB */
 #ifdef CONFIG_USB_EHCI_MX6
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 #endif
 
 /* LCD */
include/configs/pcl063.h +0 -1
index 38dcee053596..2a729c3e4544 100644
@@ -43,7 +43,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 #define CFG_EXTRA_ENV_SETTINGS \
 	"console=ttymxc0,115200n8\0" \
include/configs/pcl063_ull.h +0 -1
index d742201ce43b..afa8e7aeb716 100644
@@ -45,7 +45,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 #define ENV_MMC \
 	"mmcdev=" __stringify(MMC_ROOTFS_DEV) "\0" \
include/configs/pico-imx6.h +0 -1
index d806d7d9c57d..6ccb3dc19021 100644
@@ -17,7 +17,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 #define DFU_DEFAULT_POLL_TIMEOUT 300
 
include/configs/pico-imx6ul.h +0 -1
index 8a22f0134b39..ef8281440e5d 100644
@@ -23,7 +23,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 #define DFU_DEFAULT_POLL_TIMEOUT 300
 
include/configs/pico-imx7d.h +0 -1
index e7a8cb20dff9..21ec7fd3362c 100644
@@ -107,6 +107,5 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC			(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS			0
 
 #endif
include/configs/somlabs_visionsom_6ull.h +0 -1
index 041a83b057d4..aa09528acd97 100644
@@ -62,7 +62,6 @@
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS   0
 #endif
 
 #ifdef CONFIG_CMD_NET
include/configs/usbarmory.h +0 -1
index 27e61f5b8f46..28d86a263628 100644
@@ -25,7 +25,6 @@
 /* USB */
 #define CFG_MXC_USB_PORT	1
 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS	0
 
 /* Linux boot */
 
include/configs/vining_2000.h +0 -1
index 30654191a264..3c2d7e668917 100644
@@ -37,7 +37,6 @@
 #define CFG_FEC_MXC_PHYADDR          0x0
 
 #define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS   0
 
 #ifdef CONFIG_CMD_PCI
 #define CFG_PCIE_IMX_PERST_GPIO	IMX_GPIO_NR(4, 6)
include/configs/wandboard.h +0 -1
index 7b8c5cbe7a8f..d64c4262bd69 100644
@@ -18,7 +18,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 #define CFG_EXTRA_ENV_SETTINGS \
 	"console=ttymxc0\0" \
include/configs/xpress.h +0 -1
index a2aa31008ec9..bb0a30c4344f 100644
@@ -29,7 +29,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 #define CFG_FEC_ENET_DEV		0
 #define CFG_FEC_MXC_PHYADDR          0x0
Signature · 1 line
2.34.1
author reviewer
#1 lore raw

PATCH 2/3 usb: ehci-mx5: Add a default for CFG_MXC_USB_PORTSC

From: Fabio Estevam <[email protected]>

Just like drivers/usb/host/ehci-mx6.c, add a default for drivers/usb/host/ehci-mx5.c.

The motivation for doing this is to remove CFG_MXC_USB_PORTSC from board config files.

---
 drivers/usb/host/ehci-mx5.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/usb/host/ehci-mx5.c +4 -0
index 44912de7787d..d8f521befe14 100644
@@ -79,6 +79,10 @@
 /* USB_CTRL_1 */
 #define MXC_USB_CTRL_UH1_EXT_CLK_EN	(1 << 25)
 
+#ifndef CFG_MXC_USB_PORTSC
+#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
+#endif
+
 int mxc_set_usbcontrol(int port, unsigned int flags)
 {
 	unsigned int v;
Signature · 1 line
2.34.1
#2 lore raw

Re: [PATCH 2/3] usb: ehci-mx5: Add a default for CFG_MXC_USB_PORTSC

Quoted 18 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Just like drivers/usb/host/ehci-mx6.c, add a default for drivers/usb/host/ehci-mx5.c.

The motivation for doing this is to remove CFG_MXC_USB_PORTSC from board config files.

---
  drivers/usb/host/ehci-mx5.c | 4 ++++
  1 file changed, 4 insertions(+)
drivers/usb/host/ehci-mx5.c +0 -0
index 44912de7787d..d8f521befe14 100644

drivers/usb/host/ehci-mx5.c line 83

Quoted 5 lines
drivers/usb/host/ehci-mx5.c +2 -0
@@ -79,6 +79,10 @@
  /* USB_CTRL_1 */
  #define MXC_USB_CTRL_UH1_EXT_CLK_EN	(1 << 25)
 
+#ifndef CFG_MXC_USB_PORTSC
+#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)

Why this specific value ? (this should be in the commit message)

author reviewer
#3 lore raw

PATCH 3/3 imx: Remove CFG_MXC_USB_PORTSC

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

'#define CFG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW)' can
be removed from mx5/mx6/mx7/mx8m board config files as it is the default in drivers/usb/host/ehci-mx5.c and drivers/usb/host/ehci-mx6.c.

---
 include/configs/apalis_imx6.h            | 1 -
 include/configs/aristainetos2.h          | 1 -
 include/configs/brppt2.h                 | 1 -
 include/configs/cl-som-imx7.h            | 1 -
 include/configs/cm_fx6.h                 | 1 -
 include/configs/colibri-imx6ull.h        | 1 -
 include/configs/colibri_imx6.h           | 1 -
 include/configs/colibri_imx7.h           | 1 -
 include/configs/dart_6ul.h               | 1 -
 include/configs/dh_imx6.h                | 1 -
 include/configs/display5.h               | 1 -
 include/configs/embestmx6boards.h        | 1 -
 include/configs/ge_b1x5v2.h              | 1 -
 include/configs/gw_ventana.h             | 1 -
 include/configs/imx6_logic.h             | 1 -
 include/configs/imx6dl-mamoj.h           | 1 -
 include/configs/imx6q-bosch-acc.h        | 1 -
 include/configs/imx7-cm.h                | 1 -
 include/configs/imx8mm-cl-iot-gate.h     | 1 -
 include/configs/kontron-sl-mx6ul.h       | 1 -
 include/configs/kontron-sl-mx8mm.h       | 1 -
 include/configs/kp_imx53.h               | 1 -
 include/configs/kp_imx6q_tpc.h           | 1 -
 include/configs/liteboard.h              | 1 -
 include/configs/m53menlo.h               | 1 -
 include/configs/meerkat96.h              | 1 -
 include/configs/mx53cx9020.h             | 1 -
 include/configs/mx53loco.h               | 1 -
 include/configs/mx53ppd.h                | 1 -
 include/configs/mx6cuboxi.h              | 1 -
 include/configs/mx6memcal.h              | 1 -
 include/configs/mx6sabreauto.h           | 1 -
 include/configs/mx6sabresd.h             | 1 -
 include/configs/mx6slevk.h               | 1 -
 include/configs/mx6sllevk.h              | 1 -
 include/configs/mx6sxsabreauto.h         | 1 -
 include/configs/mx6sxsabresd.h           | 1 -
 include/configs/mx6ul_14x14_evk.h        | 1 -
 include/configs/mx7dsabresd.h            | 1 -
 include/configs/mx7ulp_com.h             | 1 -
 include/configs/mys_6ulx.h               | 1 -
 include/configs/nitrogen6x.h             | 1 -
 include/configs/novena.h                 | 1 -
 include/configs/npi_imx6ull.h            | 1 -
 include/configs/o4-imx6ull-nano.h        | 1 -
 include/configs/opos6uldev.h             | 1 -
 include/configs/pcl063.h                 | 1 -
 include/configs/pcl063_ull.h             | 1 -
 include/configs/pico-imx6.h              | 1 -
 include/configs/pico-imx6ul.h            | 1 -
 include/configs/pico-imx7d.h             | 1 -
 include/configs/somlabs_visionsom_6ull.h | 1 -
 include/configs/tbs2910.h                | 1 -
 include/configs/tqma6.h                  | 1 -
 include/configs/usbarmory.h              | 1 -
 include/configs/verdin-imx8mm.h          | 1 -
 include/configs/vining_2000.h            | 1 -
 include/configs/wandboard.h              | 1 -
 include/configs/warp7.h                  | 1 -
 include/configs/xpress.h                 | 1 -
 60 files changed, 60 deletions(-)
include/configs/apalis_imx6.h +0 -1
index 097f819e44a4..b7f66729ed4f 100644
@@ -25,7 +25,6 @@
 
 /* USB Configs */
 /* Host */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 /* Framebuffer and LCD */
 
include/configs/aristainetos2.h +0 -1
index 120ff9284ef6..aade66435dd4 100644
@@ -412,7 +412,6 @@
 /* DMA stuff, needed for GPMI/MXS NAND support */
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 /* UBI support */
 
include/configs/brppt2.h +0 -1
index 38c98c5e21c4..73d136d355d5 100644
@@ -79,6 +79,5 @@ BUR_COMMON_ENV \
 #define CFG_SYS_INIT_RAM_SIZE	IRAM_SIZE
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #endif	/* __CONFIG_BRPP2_IMX6_H */
include/configs/cl-som-imx7.h +0 -1
index 96058d48148b..816056eeacf1 100644
@@ -96,6 +96,5 @@
 #endif
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #endif	/* __CONFIG_H */
include/configs/cm_fx6.h +0 -1
index fc2d59751c42..afe0c3af428c 100644
@@ -135,7 +135,6 @@
 #define CFG_FEC_MXC_PHYADDR		0
 
 /* USB */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 /* Boot */
 #define CFG_SYS_BOOTMAPSZ	        (8 << 20)
include/configs/colibri-imx6ull.h +0 -1
index c896a897cbf4..56276b711e3c 100644
@@ -119,7 +119,6 @@
 
 /* USB Configs */
 
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 /* USB Device Firmware Update support */
 #define DFU_DEFAULT_POLL_TIMEOUT	300
include/configs/colibri_imx6.h +0 -1
index 87c973883c33..76a88d113e29 100644
@@ -23,7 +23,6 @@
 
 /* USB Configs */
 /* Host */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 /* Command definition */
 
include/configs/colibri_imx7.h +0 -1
index 0e0665038b1f..d406b20fe26e 100644
@@ -161,6 +161,5 @@
 
 /* USB Configs */
 
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #endif
include/configs/dart_6ul.h +0 -1
index 4d715d4f425e..392562fce6c0 100644
@@ -47,7 +47,6 @@
 #define CFG_SYS_INIT_RAM_SIZE	IRAM_SIZE
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #define ENV_MMC \
 	"mmcdev=" __stringify(MMC_ROOTFS_DEV) "\0" \
include/configs/dh_imx6.h +0 -1
index dc5ca9fc60cd..73308645efe6 100644
@@ -31,7 +31,6 @@
 #define CFG_MXC_UART_BASE		UART1_BASE
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 /* USB Gadget (DFU, UMS) */
 #if defined(CONFIG_CMD_DFU) || defined(CONFIG_CMD_USB_MASS_STORAGE)
include/configs/display5.h +0 -1
index 2005a256d6e3..51fa2b03a2e6 100644
@@ -287,5 +287,4 @@
 /* The 0x120000 value corresponds to above SPI-NOR memory MAP */
 #endif
 
-#define CFG_MXC_USB_PORTSC           (PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif /* __CONFIG_H */
include/configs/embestmx6boards.h +0 -1
index e378374a004a..86951e135fa7 100644
@@ -18,7 +18,6 @@
 #define PHYS_SDRAM_SIZE		(1u * 1024 * 1024 * 1024)
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 /* MMC Configs */
 #define CFG_SYS_FSL_ESDHC_ADDR      0
include/configs/ge_b1x5v2.h +0 -1
index 0bf31897a744..27d3409f0a67 100644
@@ -24,7 +24,6 @@
 #endif
 
 /* USB */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 /* Memory */
 #define PHYS_SDRAM		       MMDC0_ARB_BASE_ADDR
include/configs/gw_ventana.h +0 -1
index f884d74d9ca9..374e244cc16b 100644
@@ -36,7 +36,6 @@
 /* Various command support */
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC     (PORT_PTS_UTMI | PORT_PTS_PTW)
 
 /* Miscellaneous configurable options */
 
include/configs/imx6_logic.h +0 -1
index 19613e838fb3..44fe3606d5b8 100644
@@ -116,7 +116,6 @@
 
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif
 
 /* Falcon Mode */
include/configs/imx6dl-mamoj.h +0 -1
index 6651653d5e9c..e403d8e578da 100644
@@ -43,7 +43,6 @@
 #define CFG_FEC_MXC_PHYADDR		1
 
 /* USB */
-#define CFG_MXC_USB_PORTSC			(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 /* Falcon */
 
include/configs/imx6q-bosch-acc.h +0 -1
index aa365dc9a795..fab5063b73f4 100644
@@ -110,6 +110,5 @@
 #endif
 #endif
 
-#define CFG_MXC_USB_PORTSC            (PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #endif /* __IMX6Q_ACC_H */
include/configs/imx7-cm.h +0 -1
index 131f18290b90..59eb4f16fb50 100644
@@ -78,6 +78,5 @@
 #define CFG_SYS_FSL_USDHC_NUM		2
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #endif	/* __CONFIG_H */
include/configs/imx8mm-cl-iot-gate.h +0 -1
index 6442e3d570f4..79bd29fa6efb 100644
@@ -138,6 +138,5 @@
 #define CFG_FEC_MXC_PHYADDR		-1 /* Auto search of PHY on MII */
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #endif /*__IMX8MM_CL_IOT_GATE_H*/
include/configs/kontron-sl-mx6ul.h +0 -1
index e68c667c5057..3d6715004800 100644
@@ -25,7 +25,6 @@
 #define CFG_MXC_UART_BASE		UART4_BASE
 
 #ifdef CONFIG_USB_EHCI_HCD
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif
 
 /* Boot order for distro boot */
include/configs/kontron-sl-mx8mm.h +0 -1
index be1f70a9a598..131f882c65ca 100644
@@ -25,7 +25,6 @@
 /* Board and environment settings */
 
 #ifdef CONFIG_USB_EHCI_HCD
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif
 
 /* GUID for capsule updatable firmware image */
include/configs/kp_imx53.h +0 -1
index 91caf03091c4..c41b4a368fbe 100644
@@ -11,7 +11,6 @@
 #include <linux/sizes.h>
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 /* Command definition */
 
include/configs/kp_imx6q_tpc.h +0 -1
index 74f6e4e9f963..a6ba31c5a3e0 100644
@@ -18,7 +18,6 @@
 
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif
 
 #define CFG_EXTRA_ENV_SETTINGS	\
include/configs/liteboard.h +0 -1
index 25c30e6c6a5d..dc6d9e9dd2e1 100644
@@ -95,7 +95,6 @@
 
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif
 
 #ifdef CONFIG_CMD_NET
include/configs/m53menlo.h +0 -1
index 1491c509820d..a668eb70fc73 100644
@@ -71,7 +71,6 @@
  */
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORT		1
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif
 
 /* LVDS display */
include/configs/meerkat96.h +0 -1
index 6ffc1282411a..c8b65ebbb8e5 100644
@@ -24,6 +24,5 @@
 /* Environment configs */
 
 /* USB configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #endif
include/configs/mx53cx9020.h +0 -1
index ab6b0b65556e..278b45f0c221 100644
@@ -23,7 +23,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORT	1
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 /* Command definition */
 
include/configs/mx53loco.h +0 -1
index 04f4b7232099..9b69ee6bcdd7 100644
@@ -18,7 +18,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORT	1
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 /* PMIC Controller */
 #define CFG_SYS_DIALOG_PMIC_I2C_ADDR	0x48
include/configs/mx53ppd.h +0 -1
index 3c9a9fb045b6..7dddabfb85ba 100644
@@ -13,7 +13,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORT	1
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 /* Command definition */
 
include/configs/mx6cuboxi.h +0 -1
index f0d6405d3012..fa11c5e7f61c 100644
@@ -15,7 +15,6 @@
 #define CFG_SYS_FSL_ESDHC_ADDR	USDHC2_BASE_ADDR
 
 /* USB */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 /* Command definition */
 
include/configs/mx6memcal.h +0 -1
index f2edd13eb881..a966c8b2a446 100644
@@ -31,6 +31,5 @@
 #define CFG_SYS_INIT_RAM_ADDR       IRAM_BASE_ADDR
 #define CFG_SYS_INIT_RAM_SIZE       IRAM_SIZE
 
-#define CFG_MXC_USB_PORTSC	PORT_PTS_UTMI
 
 #endif	       /* __CONFIG_H */
include/configs/mx6sabreauto.h +0 -1
index eb963cbb0b3b..63715f920465 100644
@@ -12,7 +12,6 @@
 #define CONSOLE_DEV		"ttymxc3"
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #define CFG_SYS_I2C_PCA953X_WIDTH	{ {0x30, 8}, {0x32, 8}, {0x34, 8} }
 
include/configs/mx6sabresd.h +0 -1
index 9160f878f4b3..b19b1c03fb65 100644
@@ -26,7 +26,6 @@
 
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif
 
 #endif                         /* __MX6SABRESD_CONFIG_H */
include/configs/mx6slevk.h +0 -1
index 65c6cdd4b87b..ed84296803da 100644
@@ -90,7 +90,6 @@
 
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif
 
 #define CFG_SYS_FSL_USDHC_NUM	3
include/configs/mx6sllevk.h +0 -1
index 290996b51bc7..0948b5db100e 100644
@@ -94,7 +94,6 @@
 
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif
 
 #include <linux/stringify.h>
include/configs/mx6sxsabreauto.h +0 -1
index 4e163d28e63d..e47dc41a38b2 100644
@@ -96,7 +96,6 @@
 #define CFG_FEC_MXC_PHYADDR          0x0
 
 #ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif
 
 #define CFG_SYS_FSL_USDHC_NUM	2
include/configs/mx6sxsabresd.h +0 -1
index b43a1d813151..b848f6f4426e 100644
@@ -118,7 +118,6 @@
 #define CFG_FEC_MXC_PHYADDR          0x1
 
 #ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif
 
 #ifdef CONFIG_CMD_PCI
include/configs/mx6ul_14x14_evk.h +0 -1
index fd0c87ffb012..c6a41d762ee4 100644
@@ -116,7 +116,6 @@
 
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif
 
 #ifdef CONFIG_CMD_NET
include/configs/mx7dsabresd.h +0 -1
index 94bee75fdea5..a0a5f7d09338 100644
@@ -99,6 +99,5 @@
 #endif
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #endif	/* __CONFIG_H */
include/configs/mx7ulp_com.h +0 -1
index a310c64e7948..f8e3950fa321 100644
@@ -51,5 +51,4 @@
 #define CFG_SYS_INIT_RAM_ADDR	IRAM_BASE_ADDR
 #define CFG_SYS_INIT_RAM_SIZE	SZ_256K
 
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif	/* __CONFIG_H */
include/configs/mys_6ulx.h +0 -1
index 8defdfc4fda6..c5f85e4a8478 100644
@@ -30,7 +30,6 @@
 #define CFG_SYS_NAND_BASE		0x40000000
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #define CFG_EXTRA_ENV_SETTINGS \
 	"console=ttymxc0,115200n8\0" \
include/configs/nitrogen6x.h +0 -1
index a8ad85050f79..9e8ac943a880 100644
@@ -19,7 +19,6 @@
 #define CFG_FEC_MXC_PHYADDR		6
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #ifdef CONFIG_CMD_MMC
 #define DISTRO_BOOT_DEV_MMC(func) func(MMC, mmc, 0) func(MMC, mmc, 1)
include/configs/novena.h +0 -1
index 144cf1b4a4b8..2fd7a53b0505 100644
@@ -53,7 +53,6 @@
 
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif
 
 /* Extra U-Boot environment. */
include/configs/npi_imx6ull.h +0 -1
index f71e2657076b..ce1d3f9e7459 100644
@@ -29,7 +29,6 @@
 #define CFG_SYS_NAND_BASE		0x40000000
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #ifdef CONFIG_CMD_NET
 #define CFG_FEC_MXC_PHYADDR		0x1
include/configs/o4-imx6ull-nano.h +0 -1
index 9050da8738b1..23c26b67c258 100644
@@ -12,7 +12,6 @@
 #define CFG_SYS_INIT_RAM_SIZE	IRAM_SIZE
 
 #if IS_ENABLED(CONFIG_CMD_USB)
-#	define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif /* CONFIG_CMD_USB */
 
 #define CFG_EXTRA_ENV_SETTINGS \
include/configs/opos6uldev.h +0 -1
index 12020d31e1c7..45cefd6ab2da 100644
@@ -19,7 +19,6 @@
 
 /* USB */
 #ifdef CONFIG_USB_EHCI_MX6
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif
 
 /* LCD */
include/configs/pcl063.h +0 -1
index 2a729c3e4544..fc061d1b6901 100644
@@ -42,7 +42,6 @@
 #define CFG_SYS_NAND_BASE		0x40000000
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #define CFG_EXTRA_ENV_SETTINGS \
 	"console=ttymxc0,115200n8\0" \
include/configs/pcl063_ull.h +0 -1
index afa8e7aeb716..f5d640a2e45e 100644
@@ -44,7 +44,6 @@
 #define CFG_SYS_NAND_BASE		0x40000000
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #define ENV_MMC \
 	"mmcdev=" __stringify(MMC_ROOTFS_DEV) "\0" \
include/configs/pico-imx6.h +0 -1
index 6ccb3dc19021..8bce836f18fe 100644
@@ -16,7 +16,6 @@
 #define CFG_SYS_FSL_ESDHC_ADDR	USDHC3_BASE_ADDR
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #define DFU_DEFAULT_POLL_TIMEOUT 300
 
include/configs/pico-imx6ul.h +0 -1
index ef8281440e5d..42e9d40fd7ee 100644
@@ -22,7 +22,6 @@
 #define CFG_SYS_FSL_ESDHC_ADDR	USDHC1_BASE_ADDR
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #define DFU_DEFAULT_POLL_TIMEOUT 300
 
include/configs/pico-imx7d.h +0 -1
index 21ec7fd3362c..919fc4db8dfe 100644
@@ -106,6 +106,5 @@
 #define CFG_SYS_FSL_USDHC_NUM		2
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC			(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #endif
include/configs/somlabs_visionsom_6ull.h +0 -1
index aa09528acd97..cad37fccbac9 100644
@@ -61,7 +61,6 @@
 
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif
 
 #ifdef CONFIG_CMD_NET
include/configs/tbs2910.h +0 -1
index 256331ae1733..eb5fdae0ea86 100644
@@ -27,7 +27,6 @@
 
 /* USB */
 #ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif /* CONFIG_CMD_USB      */
 
 #define CFG_EXTRA_ENV_SETTINGS \
include/configs/tqma6.h +0 -1
index b4a06a75c538..1da7e855a250 100644
@@ -30,7 +30,6 @@
 #define CFG_SYS_FSL_ESDHC_ADDR	0
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #if defined(CONFIG_TQMA6X_MMC_BOOT)
 
include/configs/usbarmory.h +0 -1
index 28d86a263628..ffeead40573f 100644
@@ -24,7 +24,6 @@
 
 /* USB */
 #define CFG_MXC_USB_PORT	1
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 /* Linux boot */
 
include/configs/verdin-imx8mm.h +0 -1
index 12d2b6823058..31d153870af4 100644
@@ -64,6 +64,5 @@
 #define PHYS_SDRAM_2_SIZE            (long)(SZ_1G)
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #endif /* __VERDIN_IMX8MM_H */
include/configs/vining_2000.h +0 -1
index 3c2d7e668917..2cf7bc70d8de 100644
@@ -36,7 +36,6 @@
 /* Network */
 #define CFG_FEC_MXC_PHYADDR          0x0
 
-#define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #ifdef CONFIG_CMD_PCI
 #define CFG_PCIE_IMX_PERST_GPIO	IMX_GPIO_NR(4, 6)
include/configs/wandboard.h +0 -1
index d64c4262bd69..9b2d4eb55966 100644
@@ -17,7 +17,6 @@
 #define CFG_SYS_FSL_ESDHC_ADDR	0
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #define CFG_EXTRA_ENV_SETTINGS \
 	"console=ttymxc0\0" \
include/configs/warp7.h +0 -1
index 0da9250c3b78..a5278d1cb9b8 100644
@@ -92,7 +92,6 @@
 
 #define CFG_SYS_FSL_USDHC_NUM	1
 
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 /* USB Device Firmware Update support */
 #define DFU_DEFAULT_POLL_TIMEOUT	300
include/configs/xpress.h +0 -1
index bb0a30c4344f..877e1a00b104 100644
@@ -28,7 +28,6 @@
 /* Environment is in stored in the eMMC boot partition */
 
 /* USB Configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #define CFG_FEC_ENET_DEV		0
 #define CFG_FEC_MXC_PHYADDR          0x0
Signature · 1 line
2.34.1
Reviewed-by on v1 3/3
#4 lore raw

Re: [PATCH 3/3] imx: Remove CFG_MXC_USB_PORTSC

Quoted 8 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

'#define CFG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW)' can
be removed from mx5/mx6/mx7/mx8m board config files as it is the default in drivers/usb/host/ehci-mx5.c and drivers/usb/host/ehci-mx6.c.

#5 lore raw

Re: [PATCH 3/3] imx: Remove CFG_MXC_USB_PORTSC

In reply to Fabio Estevam

Hi Fabio,

Quoted 70 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

'#define CFG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW)' can
be removed from mx5/mx6/mx7/mx8m board config files as it is the default in drivers/usb/host/ehci-mx5.c and drivers/usb/host/ehci-mx6.c.

---
  include/configs/apalis_imx6.h            | 1 -
  include/configs/aristainetos2.h          | 1 -
  include/configs/brppt2.h                 | 1 -
  include/configs/cl-som-imx7.h            | 1 -
  include/configs/cm_fx6.h                 | 1 -
  include/configs/colibri-imx6ull.h        | 1 -
  include/configs/colibri_imx6.h           | 1 -
  include/configs/colibri_imx7.h           | 1 -
  include/configs/dart_6ul.h               | 1 -
  include/configs/dh_imx6.h                | 1 -
  include/configs/display5.h               | 1 -
  include/configs/embestmx6boards.h        | 1 -
  include/configs/ge_b1x5v2.h              | 1 -
  include/configs/gw_ventana.h             | 1 -
  include/configs/imx6_logic.h             | 1 -
  include/configs/imx6dl-mamoj.h           | 1 -
  include/configs/imx6q-bosch-acc.h        | 1 -
  include/configs/imx7-cm.h                | 1 -
  include/configs/imx8mm-cl-iot-gate.h     | 1 -
  include/configs/kontron-sl-mx6ul.h       | 1 -
  include/configs/kontron-sl-mx8mm.h       | 1 -
  include/configs/kp_imx53.h               | 1 -
  include/configs/kp_imx6q_tpc.h           | 1 -
  include/configs/liteboard.h              | 1 -
  include/configs/m53menlo.h               | 1 -
  include/configs/meerkat96.h              | 1 -
  include/configs/mx53cx9020.h             | 1 -
  include/configs/mx53loco.h               | 1 -
  include/configs/mx53ppd.h                | 1 -
  include/configs/mx6cuboxi.h              | 1 -
  include/configs/mx6memcal.h              | 1 -
  include/configs/mx6sabreauto.h           | 1 -
  include/configs/mx6sabresd.h             | 1 -
  include/configs/mx6slevk.h               | 1 -
  include/configs/mx6sllevk.h              | 1 -
  include/configs/mx6sxsabreauto.h         | 1 -
  include/configs/mx6sxsabresd.h           | 1 -
  include/configs/mx6ul_14x14_evk.h        | 1 -
  include/configs/mx7dsabresd.h            | 1 -
  include/configs/mx7ulp_com.h             | 1 -
  include/configs/mys_6ulx.h               | 1 -
  include/configs/nitrogen6x.h             | 1 -
  include/configs/novena.h                 | 1 -
  include/configs/npi_imx6ull.h            | 1 -
  include/configs/o4-imx6ull-nano.h        | 1 -
  include/configs/opos6uldev.h             | 1 -
  include/configs/pcl063.h                 | 1 -
  include/configs/pcl063_ull.h             | 1 -
  include/configs/pico-imx6.h              | 1 -
  include/configs/pico-imx6ul.h            | 1 -
  include/configs/pico-imx7d.h             | 1 -
  include/configs/somlabs_visionsom_6ull.h | 1 -
  include/configs/tbs2910.h                | 1 -
  include/configs/tqma6.h                  | 1 -
  include/configs/usbarmory.h              | 1 -
  include/configs/verdin-imx8mm.h          | 1 -
  include/configs/vining_2000.h            | 1 -
  include/configs/wandboard.h              | 1 -
  include/configs/warp7.h                  | 1 -
  include/configs/xpress.h                 | 1 -
  60 files changed, 60 deletions(-)

[...]

include/configs/tbs2910.h line 32

Quoted 12 lines
include/configs/tbs2910.h +0 -1
index 256331ae1733..eb5fdae0ea86 100644
@@ -27,7 +27,6 @@
 
  /* USB */
  #ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
  #endif /* CONFIG_CMD_USB      */
 
  #define CFG_EXTRA_ENV_SETTINGS \

Can you please also remove the now useless comment and empty #ifdef block!?

I have not checked in detail, but the same occurs also for other boards in this patch.

Thanks,
Soeren

#6 lore raw

Re: [PATCH 3/3] imx: Remove CFG_MXC_USB_PORTSC

In reply to Fabio Estevam
Quoted 10 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

'#define CFG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW)' can
be removed from mx5/mx6/mx7/mx8m board config files as it is the default in drivers/usb/host/ehci-mx5.c and drivers/usb/host/ehci-mx6.c.

---

<snip>

include/configs/m53menlo.h line 75

Quoted 12 lines

#ifdef CONFIG_CMD_NET

include/configs/m53menlo.h +0 -1
index 1491c509820d..a668eb70fc73 100644
@@ -71,7 +71,6 @@
  */
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORT               1
-#define CFG_MXC_USB_PORTSC             (PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif
 

Hi Fabio,

Thanks for doing this - we are at a point where the include/configs/<board>.h files are almost empty.

It doesn't look like CFG_MXC_USB_PORT (defined in 6 mx51/mx53 includes) is not used anymore so it can be removed as well.

With all of these outdated USB defines removed you could also prune out the enclosing '#ifdef CONFIG_CMD_USB' and the '/* USB configs */' comments in the includes but that certainly would be a manual edit of the files.

Best Regards,

Tim