Skip to contentSkip to conversation

staging: vme_user: added bound check to geoid

PATCH In review Riyan Dhiman 2 participants 2 messages Aug 27, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 staging: vme_user: added bound check to geoid

The geoid is a module parameter that allows users to hardcode the slot number. A bound check for geoid was added in the probe function because only values between 0 and less than VME_MAX_SLOT are valid.

---
v3: Fix commit message and remove redundant comment.
v2: Removed unnecessary paranthesis and changed pr_err to dev_err.
v1: Added bound check to geoid

 drivers/staging/vme_user/vme_fake.c   | 6 ++++++
 drivers/staging/vme_user/vme_tsi148.c | 6 ++++++
 2 files changed, 12 insertions(+)
drivers/staging/vme_user/vme_fake.c +6 -0
index 7f84d1c86f29..c4fb2b65154c 100644
@@ -1059,6 +1059,12 @@ static int __init fake_init(void)
 	struct vme_slave_resource *slave_image;
 	struct vme_lm_resource *lm;
 
+	if (geoid < 0 || geoid >= VME_MAX_SLOTS) {
+		pr_err("VME geographical address must be between 0 and %d (exclusive), but got %d\n",
+			VME_MAX_SLOTS, geoid);
+		return -EINVAL;
+	}
+
 	/* We need a fake parent device */
 	vme_root = root_device_register("vme");
 	if (IS_ERR(vme_root))
drivers/staging/vme_user/vme_tsi148.c +6 -0
index d81be8e4ceba..6b6ad781b966 100644
@@ -2252,6 +2252,12 @@ static int tsi148_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 	struct vme_dma_resource *dma_ctrlr;
 	struct vme_lm_resource *lm;
 
+	if (geoid < 0 || geoid >= VME_MAX_SLOTS) {
+		dev_err(&pdev->dev, "VME geographical address must be between 0 and %d (exclusive), but got %d\n",
+			VME_MAX_SLOTS, geoid);
+		return -EINVAL;
+	}
+
 	/* If we want to support more than one of each bridge, we need to
 	 * dynamically generate this so we get one per device
 	 */
Signature · 1 line
2.46.0
Reviewed-by on v3 1/1
#1 lore raw
Quoted 10 lines · Riyan Dhiman

The geoid is a module parameter that allows users to hardcode the slot number. A bound check for geoid was added in the probe function because only values between 0 and less than VME_MAX_SLOT are valid.

---
v3: Fix commit message and remove redundant comment.
v2: Removed unnecessary paranthesis and changed pr_err to dev_err.
v1: Added bound check to geoid

Thanks!

regards,
dan carpenter