staging: rtl8712: Fix style issues in rtl871x_io.c
PATCH v3 1/2 staging: rtl8712: Fix style issues in rtl871x_io.c
Refactor the _init_intf_hdl() function to avoid multiple assignments in a single statement. This change improves code readability and adheres to kernel coding style guidelines.
---
Changes since v2:
- commit message updated.
- assignment done before goto fail.
Changes since v1:
Broke the patch into 2 different fixes.
drivers/staging/rtl8712/rtl871x_io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8712/rtl871x_io.c +2 -2
@@ -48,8 +48,8 @@ static uint _init_intf_hdl(struct _adapter *padapter, set_intf_funs = &(r8712_usb_set_intf_funs); set_intf_ops = &r8712_usb_set_intf_ops; init_intf_priv = &r8712_usb_init_intf_priv; - pintf_priv = pintf_hdl->pintfpriv =kmalloc (sizeof (struct intf_priv ), -GFP_ATOMIC ); + pintf_priv =kmalloc (sizeof (struct intf_priv ),GFP_ATOMIC ); + pintf_hdl->pintfpriv = pintf_priv;if (!pintf_priv) goto _init_intf_hdl_fail; pintf_hdl->adapter = (u8 *)padapter;
Signature · 1 line
2.43.0
PATCH v3 2/2 staging: rtl8712: Calculate size from pointer
Calculate the size from the pointer instead of struct to adhere to kernel coding style.
---
Changes since v2:
commit message updated.
Changes since v1:
Broke the patch into 2 different fixes.
drivers/staging/rtl8712/rtl871x_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/rtl871x_io.c +1 -1
@@ -48,7 +48,7 @@ static uint _init_intf_hdl(struct _adapter *padapter, set_intf_funs = &(r8712_usb_set_intf_funs); set_intf_ops = &r8712_usb_set_intf_ops; init_intf_priv = &r8712_usb_init_intf_priv; - pintf_priv =kmalloc (sizeof (struct intf_priv ),GFP_ATOMIC ); + pintf_priv =kmalloc (sizeof (*pintf_priv),GFP_ATOMIC ); pintf_hdl->pintfpriv = pintf_priv;if (!pintf_priv) goto _init_intf_hdl_fail;
Signature · 1 line
2.43.0
Re: [PATCH v3 2/2] staging: rtl8712: Calculate size from pointer
Quoted 19 lines · Manisha Singh
Calculate the size from the pointer instead of struct to adhere to kernel coding style.
Signed-off-by Manisha Singh <[email protected]>---
Changes since v2:
commit message updated.Changes since v1:
Broke the patch into 2 different fixes.drivers/staging/rtl8712/rtl871x_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/rtl8712/rtl871x_io.c +0
-0
drivers/staging/rtl8712/rtl871x_io.c static uint _init_intf_hdl(struct _adapter *padapter, · line 54
Quoted 8 lines
drivers/staging/rtl8712/rtl871x_io.c +1
-1@@ -48,7 +48,7 @@ static uint _init_intf_hdl(struct _adapter *padapter, set_intf_funs = &(r8712_usb_set_intf_funs); set_intf_ops = &r8712_usb_set_intf_ops; init_intf_priv = &r8712_usb_init_intf_priv; - pintf_priv =kmalloc (sizeof (struct intf_priv ),GFP_ATOMIC ); + pintf_priv =kmalloc (sizeof (*pintf_priv),GFP_ATOMIC ); pintf_hdl->pintfpriv = pintf_priv;if (!pintf_priv) goto _init_intf_hdl_fail;
Quoted 21 lines · Manisha Singh
Refactor the
_init_intf_hdl()function to avoid multiple assignments in a single statement. This change improves code readability and adheres to kernel coding style guidelines.Signed-off-by Manisha Singh <[email protected]>---
Changes since v2:
- commit message updated.
- assignment done before goto fail.Changes since v1:
Broke the patch into 2 different fixes.drivers/staging/rtl8712/rtl871x_io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/rtl8712/rtl871x_io.c +0
-0
drivers/staging/rtl8712/rtl871x_io.c static uint _init_intf_hdl(struct _adapter *padapter, · line 55
Quoted 10 lines
drivers/staging/rtl8712/rtl871x_io.c +2
-2@@ -48,8 +48,8 @@ static uint _init_intf_hdl(struct _adapter *padapter, set_intf_funs = &(r8712_usb_set_intf_funs); set_intf_ops = &r8712_usb_set_intf_ops; init_intf_priv = &r8712_usb_init_intf_priv; - pintf_priv = pintf_hdl->pintfpriv =kmalloc (sizeof (struct intf_priv ), -GFP_ATOMIC ); + pintf_priv =kmalloc (sizeof (struct intf_priv ),GFP_ATOMIC ); + pintf_hdl->pintfpriv = pintf_priv;if (!pintf_priv) goto _init_intf_hdl_fail; pintf_hdl->adapter = (u8 *)padapter;