nvmet: Identify-Active Namespace ID List command should reject invalid nsid
Subsystems (2)
PATCH v2 1/1 nvmet: Identify-Active Namespace ID List command should reject invalid nsid
nsid values of 0xFFFFFFFE and 0XFFFFFFFF should be rejected with a status code of "Invalid Namespace or Format".
See NVMe Base Specification, Active Namespace ID list (CNS 02h).
Fixes a07b4970f464 ("nvmet: add a generic NVMe target")
Signed-off-by Maurizio Lombardi <[email protected]>
---
v2: Explicitely check against the two constants, add a reference to the specs
drivers/nvme/target/admin-cmd.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/nvme/target/admin-cmd.c +10 -0
@@ -587,6 +587,16 @@ static void nvmet_execute_identify_nslist(struct nvmet_req *req)u16 status =0 ;int i =0 ; +/* +* NSID values 0xFFFFFFFE and NVME_NSID_ALL are invalid +* See NVMe Base Specification, Active Namespace ID list (CNS 02h). +*/ +if (min_nsid ==0xFFFFFFFE || min_nsid ==NVME_NSID_ALL ) { + req->error_loc = offsetof(struct nvme_identify , nsid); + status =NVME_SC_INVALID_NS |NVME_STATUS_DNR ; + goto out; + } + list =kzalloc (buf_size,GFP_KERNEL );if (!list) { status =NVME_SC_INTERNAL ;
Signature · 1 line
2.43.5
Reviewed-by Sagi Grimberg <[email protected]>
Quoted 3 lines · Maurizio Lombardi
nsid values of
0xFFFFFFFEand0XFFFFFFFFshould be rejected with a status code of "Invalid Namespace or Format".
See NVMe Base Specification, Active Namespace ID list (CNS 02h).
Thanks, applied to nvme-6.11.