selftests/mm: Relax test to fail after 100 migration failures
Subsystems (3)
PATCH 1/1 selftests/mm: Relax test to fail after 100 migration failures
It was recently observed at [1] that during the folio unmapping stage of migration, when the PTEs are cleared, a racing thread faulting on that folio may increase the refcount of the folio, sleep on the folio lock (the migration path has the lock), and migration ultimately fails when asserting the actual refcount against the expected. Thereby, the migration selftest fails on shared-anon mappings.
The above enforces the fact that migration is a best-effort service, therefore, it is wrong to fail the test for just a single failure; hence, fail the test after 100 consecutive failures (where 100 is still a subjective choice). Note that, this has no effect on the execution time of the test since that is controlled by a timeout.
[1] https://lore.kernel.org/all/[email protected]/
---
The above patch was part of the following:
https://lore.kernel.org/all/[email protected]/
I decided to send it separately since it should be applied nevertheless.
tools/testing/selftests/mm/migration.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-)
tools/testing/selftests/mm/migration.c +11 -6
@@ -15,10 +15,10 @@#include <signal.h> #include <time.h> -#define TWOMEG (2<<20) -#define RUNTIME (20) - -#define ALIGN (x, a) (((x) + (a - 1)) & (~((a) - 1))) +#define TWOMEG (2<<20) +#define RUNTIME (20) +#define MAX_RETRIES 100 +#define ALIGN (x, a) (((x) + (a - 1)) & (~((a) - 1)))FIXTURE (migration) {
@@ -65,6 +65,7 @@ int migrate(uint64_t *ptr, int n1, int n2)int ret, tmp;int status =0 ;struct timespec ts1, ts2; +int failures =0 ;if (clock_gettime (CLOCK_MONOTONIC , &ts1))return -1 ;
@@ -79,13 +80,17 @@ int migrate(uint64_t *ptr, int n1, int n2) ret =move_pages (0 ,1 , (void **) &ptr, &n2, &status,MPOL_MF_MOVE_ALL );if (ret) { -if (ret >0 ) +if (ret >0 ) { +/* Migration is best effort; try again */ +if (++failures <MAX_RETRIES ) +continue ;printf ("Didn't migrate %d pages\n" , ret); + }else perror ("Couldn't migrate pages" );return -2 ; } - + failures =0 ; tmp = n2; n2 = n1; n1 = tmp;
Signature · 1 line
2.30.2