kselftest/arm64: Fix build warnings for ptrace
PATCH 1/1 kselftest/arm64: Fix build warnings for ptrace
A "%s" is missing in ksft_exit_fail_msg(); instead, use the newly introduced ksft_exit_fail_perror().
Signed-off-by Dev Jain <[email protected]>
--- tools/testing/selftests/arm64/abi/ptrace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/arm64/abi/ptrace.c +2 -2
@@ -163,10 +163,10 @@ static void test_hw_debug(pid_t child, int type, const char *type_name)static int do_child (void ) {if (ptrace (PTRACE_TRACEME ,-1 ,NULL ,NULL )) -ksft_exit_fail_msg ("PTRACE_TRACEME" ,strerror (errno)); +ksft_exit_fail_perror ("PTRACE_TRACEME" );if (raise (SIGSTOP )) -ksft_exit_fail_msg ("raise(SIGSTOP)" ,strerror (errno)); +ksft_exit_fail_perror ("raise(SIGSTOP)" );return EXIT_SUCCESS ; }
Signature · 1 line
2.30.2
Quoted 2 lines · Dev Jain
A "%s" is missing in
ksft_exit_fail_msg(); instead, use the newly introducedksft_exit_fail_perror().
Reviewed-by Mark Brown <[email protected]>
Quoted 15 lines · Dev Jain
A "%s" is missing in
ksft_exit_fail_msg(); instead, use the newly introducedksft_exit_fail_perror().Signed-off-by Dev Jain <[email protected]>--- tools/testing/selftests/arm64/abi/ptrace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/testing/selftests/arm64/abi/ptrace.c +0
-0@@ -163,10 +163,10 @@ static void test_hw_debug(pid_t child, int type, const char *type_name)static int do_child (void ) {
tools/testing/selftests/arm64/abi/ptrace.c static void test_hw_debug(pid_t child, int type, const char *type_name) · line 172
Quoted 10 lines
tools/testing/selftests/arm64/abi/ptrace.c +2
-2if (ptrace (PTRACE_TRACEME ,-1 ,NULL ,NULL )) -ksft_exit_fail_msg ("PTRACE_TRACEME" ,strerror (errno)); +ksft_exit_fail_perror ("PTRACE_TRACEME" );if (raise (SIGSTOP )) -ksft_exit_fail_msg ("raise(SIGSTOP)" ,strerror (errno)); +ksft_exit_fail_perror ("raise(SIGSTOP)" );return EXIT_SUCCESS ; }
Thanks for doing this.
Reviewed-by Shuah Khan <[email protected]>
thanks,
-- Shuah
Will Deacon
maintainerQuoted 4 lines · Dev Jain
A "%s" is missing in
ksft_exit_fail_msg(); instead, use the newly introducedksft_exit_fail_perror().
Applied to arm64 (for-next/selftests), thanks!
[1/1] kselftest/arm64: Fix build warnings for ptrace
https://git.kernel.org/arm64/c/d736d4fc7630
Cheers,
Signature · 5 lines
Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev