Skip to contentSkip to conversation

media: dt-bindings: i2c: ds90ub960: Add DS90UB954 chip to DS90UB960 bindings

PATCH Superseded Alexander Shiyan 3 participants 4 messages Aug 30, 2024 – Oct 1, 2024

Subsystems (3)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 media: dt-bindings: i2c: ds90ub960: Add DS90UB954 chip to DS90UB960 bindings

The ds90ub960 driver can now be used for the DS90UB954 chip as it has a similar register set and configuration.
Let's add an additional compatibility line to the bindings.

---
 Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml +1 -0
index 0b71e6f911a8..86d43d949dd3 100644
@@ -19,6 +19,7 @@ allOf:
 properties:
   compatible:
     enum:
+      - ti,ds90ub954-q1
       - ti,ds90ub960-q1
       - ti,ds90ub9702-q1
 
Signature · 1 line
2.39.1
Acked-by on v1 3/3
#1 lore raw
Quoted 5 lines · Alexander Shiyan

The ds90ub960 driver can now be used for the DS90UB954 chip as it has a similar register set and configuration.
Let's add an additional compatibility line to the bindings.

FYI, your threading is broken on this series, patch 1 & 2 are linked, but the binding patch is not.

Quoted 20 lines
---
 Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml +1 -0
index 0b71e6f911a8..86d43d949dd3 100644
@@ -19,6 +19,7 @@ allOf:
 properties:
   compatible:
     enum:
+      - ti,ds90ub954-q1
       - ti,ds90ub960-q1
       - ti,ds90ub9702-q1
 
Signature · 1 line
2.39.1
maintainer
#2 lore raw
In reply to Alexander Shiyan

Hi,

Quoted 14 lines · Alexander Shiyan

The ds90ub960 driver can now be used for the DS90UB954 chip as it has a similar register set and configuration.
Let's add an additional compatibility line to the bindings.

---
  Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 1 +
  1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml +0 -0
index 0b71e6f911a8..86d43d949dd3 100644

Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml allOf: · line 25

Quoted 7 lines
Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml +1 -0
@@ -19,6 +19,7 @@ allOf:
  properties:
    compatible:
      enum:
+      - ti,ds90ub954-q1
        - ti,ds90ub960-q1
        - ti,ds90ub9702-q1
 

The binding lists 6 ports as required, but UB954 only has 3 ports.

Tomi

#3 lore raw

Hello Toni.

I don't know how to use condition blocks for YAML format. Can You help me? If I understand correctly, it is necessary to create conditions here for ti,ds90ub954-q1:
"link@[0-1]$" instead of "link@[0-3]$" and rewrite all port@x part.

Thanks!

вт, 10 сент. 2024 г. в 11:44, Tomi Valkeinen <[email protected]>:

Quoted 27 lines

Hi,

Quoted 14 lines · Alexander Shiyan

The ds90ub960 driver can now be used for the DS90UB954 chip as it has a similar register set and configuration.
Let's add an additional compatibility line to the bindings.

---
  Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 1 +
  1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml +0 -0
index 0b71e6f911a8..86d43d949dd3 100644

Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml allOf: · line 25

Quoted 7 lines
Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml +1 -0
@@ -19,6 +19,7 @@ allOf:
  properties:
    compatible:
      enum:
+      - ti,ds90ub954-q1
        - ti,ds90ub960-q1
        - ti,ds90ub9702-q1
 

The binding lists 6 ports as required, but UB954 only has 3 ports.