FAILED: patch "[PATCH] drm/i915/dp_mst: Fix MST state after a sink reset" failed to apply to 6.1-stable tree
[email protected]
maintainerThe patch below does not apply to the 6.1-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y
git checkout FETCH_HEAD
git cherry-pick -x a2ccc33b88e2953a6bf0b309e7e8849cc5320018
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2024083052-definite-customs-8a5e@gregkh' --subject-prefix 'PATCH 6.1.y' HEAD^..
Possible dependencies:
a2ccc33b88e2 ("drm/i915/dp_mst: Fix MST state after a sink reset") e37137380931 ("drm/i915/dp_mst: Force modeset CRTC if DSC toggling requires it") 326b1e792ff0 ("drm/i915/dp_mst: Add the MST topology state for modesetted CRTCs")
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From a2ccc33b88e2953a6bf0b309e7e8849cc5320018 Mon Sep 17 00:00:00 2001
From: Imre Deak <[email protected]>
Date: Fri, 23 Aug 2024 19:29:18 +0300
Subject: [PATCH] drm/i915/dp_mst: Fix MST state after a sink reset
In some cases the sink can reset itself after it was configured into MST mode, without the driver noticing the disconnected state. For instance the reset may happen in the middle of a modeset, or the (long) HPD pulse generated may be not long enough for the encoder detect handler to observe the HPD's deasserted state. In this case the sink's DPCD register programmed to enable MST will be reset, while the driver still assumes MST is still enabled. Detect this condition, which will tear down and recreate/re-enable the MST topology.
v2:
- Add a code comment about adjusting the expected DP_MSTM_CTRL register value for SST + SideBand. (Suraj, Jani)
- Print a debug message about detecting the link reset. (Jani)
- Verify the DPCD MST state only if it wasn't already determined that the sink is disconnected.
drivers/gpu/drm/i915/display/intel_dp.c +12 -0
@@ -5935,6 +5935,18 @@ intel_dp_detect(struct drm_connector *connector,else status = connector_status_disconnected; +if (status != connector_status_disconnected && + !intel_dp_mst_verify_dpcd_state (intel_dp)) +/* +* This requires retrying detection for instance to re-enable +* the MST mode that got reset via a long HPD pulse. The retry +* will happen either via the hotplug handler's retry logic, +* ensured by setting the connector here to SST/disconnected, +* or via a userspace connector probing in response to the +* hotplug uevent sent when removing the MST connectors. +*/ + status = connector_status_disconnected; +if (status == connector_status_disconnected) {memset (&intel_dp->compliance,0 ,sizeof (intel_dp->compliance));memset (intel_connector->dp.dsc_dpcd,0 ,sizeof (intel_connector->dp.dsc_dpcd));
drivers/gpu/drm/i915/display/intel_dp_mst.c +40 -0
@@ -1998,3 +1998,43 @@ bool intel_dp_mst_crtc_needs_modeset(struct intel_atomic_state *state,return false; } + +/* +* intel_dp_mst_verify_dpcd_state - verify the MST SW enabled state wrt. the DPCD +* @intel_dp: DP port object +* +* Verify if @intel_dp's MST enabled SW state matches the corresponding DPCD +* state. A long HPD pulse - not long enough to be detected as a disconnected +* state - could've reset the DPCD state, which requires tearing +* down/recreating the MST topology. +* +* Returns %true if the SW MST enabled and DPCD states match, %false +* otherwise. +*/ +bool intel_dp_mst_verify_dpcd_state (struct intel_dp *intel_dp) +{ +struct intel_display *display =to_intel_display (intel_dp); +struct intel_connector *connector = intel_dp->attached_connector; +struct intel_digital_port *dig_port =dp_to_dig_port (intel_dp); +struct intel_encoder *encoder = &dig_port->base; +int ret; +u8 val; + +if (!intel_dp->is_mst) +return true; + + ret =drm_dp_dpcd_readb (intel_dp->mst_mgr.aux,DP_MSTM_CTRL , &val); + +/* Adjust the expected register value for SST + SideBand. */ +if (ret <0 || val != (DP_MST_EN |DP_UP_REQ_EN |DP_UPSTREAM_IS_SRC )) { +drm_dbg_kms (display->drm, +"[CONNECTOR:%d:%s][ENCODER:%d:%s] MST mode got reset, removing topology (ret=%d, ctrl=0x%02x)\n" , + connector->base.base.id, connector->base.name, + encoder->base.base.id, encoder->base.name, + ret, val); + +return false; + } + +return true; +}
drivers/gpu/drm/i915/display/intel_dp_mst.h +1 -0
@@ -27,5 +27,6 @@ int intel_dp_mst_atomic_check_link(struct intel_atomic_state *state, struct intel_link_bw_limits *limits);bool intel_dp_mst_crtc_needs_modeset (struct intel_atomic_state *state,struct intel_crtc *crtc); +bool intel_dp_mst_verify_dpcd_state (struct intel_dp *intel_dp);#endif /* __INTEL_DP_MST_H__ */