mm-always-inline-_compound_head-with-config_hugetlb_page_optimize_vmemmap=y.patch removed from -mm tree
The quilt patch titled
Subject: mm: always inline _compound_head() with CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP=y
has been removed from the -mm tree. Its filename was
mm-always-inline-_compound_head-with-config_hugetlb_page_optimize_vmemmap=y.patch
This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: David Hildenbrand <[email protected]>
Subject: mm: always inline _compound_head() with CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP=y
Date: Tue, 20 Aug 2024 14:22:10 +0200
We already force-inline page_fixed_fake_head(), page_is_fake_head() and PageTail(), however the compiler might decide that _compound_head() is not worthy to be inlined, because of page_fixed_fake_head().
The result is that, for example, PageAnonExclusive() now might involve a function call when checking PageHuge(), which performs a page_folio()->_compound_head() call. This can lead to a slight regression of the stress-ng.clone benchmark.
This is not super-urgent to fix, but always inlining _compound_head() seems like the obvious thing to do for this primitive, similar to the other ones.
This change restores the slight regression and a compilation with CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP=y shows no relevant bloat [2]:
add/remove: 15/14 grow/shrink: 79/87 up/down: 12836/-13917 (-1081) ... Total: Before=32786363, After=32785282, chg -0.00%
[1] https://lkml.kernel.org/r/[email protected]
[2] https://lore.kernel.org/all/[email protected]/
---
include/linux/page-flags.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/page-flags.h renamed from include/linux/page-flags.h~mm-always-inline-_compound_head-with-config_hugetlb_page_optimize_vmemmap=y +1 -1
@@ -232,7 +232,7 @@ static __always_inline int page_is_fake_return page_fixed_fake_head (page) != page; } -static inline unsigned long _compound_head (const struct page *page) +static __always_inline unsigned long _compound_head (const struct page *page) {unsigned long head =READ_ONCE (page->compound_head);
_
Patches currently in -mm which might be from [email protected] are