ext4: return error on syncfs after shutdown

This is the logic behavior and one that we would like to verify using a generic fstest similar to xfs/546.

Link https://lore.kernel.org/fstests/20240830152648.GE6216@frogsfrogsfrogs/ open here

Suggested-by Darrick J. Wong <[email protected]>

Signed-off-by Amir Goldstein <[email protected]>

---

Ted,

Please see the discussion about moving test xfs/546 to generic.

WDYT?

Thanks,
Amir.

 fs/ext4/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

fs/ext4/super.c +1 -1

index e72145c4ae5a..b9cf18819e11 100644
@@ -6279,7 +6279,7 @@ static int ext4_sync_fs(struct super_block *sb, int wait)
 	struct ext4_sb_info *sbi = EXT4_SB(sb);
 
 	if (unlikely(ext4_forced_shutdown(sb)))
-		return 0;
+		return -EIO;
 
 	trace_ext4_sync_fs(sb, wait);
 	flush_workqueue(sbi->rsv_conversion_wq);

Signature · 1 line

2.34.1

This is the logic behavior and one that we would like to verify using a generic fstest similar to xfs/546.