Skip to contentSkip to conversation

ASoC: mediatek: mt8365: remove unused mt8365_i2s_hd_str

PATCH In review Arnd Bergmann 3 participants 3 messages Sep 7, 2024 – Sep 9, 2024

Subsystems (3)
Sound ASoC Arm MediaTek
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 ASoC: mediatek: mt8365: remove unused mt8365_i2s_hd_str

From: Arnd Bergmann <[email protected]>

The mt8365_i2s_enum and mt8365_i2s_hd_str variables are not used anywhere, but cause a warning when building with C=1 or when enabling -Wunused-const-variable:

sound/soc/mediatek/mt8365/mt8365-dai-i2s.c:781:27: error: 'mt8365_i2s_hd_str' defined but not used [-Werror=unused-const-variable=]

  781 | static const char * const mt8365_i2s_hd_str[] = {
      |                           ^~~~~~~~~~~~~~~~~

Remove these for the moment, they can be added back if a user comes up.

Fixes 402bbb13a195 ("ASoC: mediatek: mt8365: Add I2S DAI support")
Signed-off-by Arnd Bergmann <[email protected]>
---
 sound/soc/mediatek/mt8365/mt8365-dai-i2s.c | 7 -------
 1 file changed, 7 deletions(-)
sound/soc/mediatek/mt8365/mt8365-dai-i2s.c +0 -7
index 6b4d8b7e24ca..3482d8f8b4e7 100644
@@ -777,13 +777,6 @@ static struct snd_soc_dai_driver mtk_dai_i2s_driver[] = {
 	}
 };
 
-/* low jitter control */
-static const char * const mt8365_i2s_hd_str[] = {
-	"Normal", "Low_Jitter"
-};
-
-static SOC_ENUM_SINGLE_EXT_DECL(mt8365_i2s_enum, mt8365_i2s_hd_str);
-
 static const char * const fmi2sin_text[] = {
 	"OPEN", "FM_2ND_I2S_IN"
 };
Signature · 1 line
2.39.2
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The mt8365_i2s_enum and mt8365_i2s_hd_str variables are not used anywhere, but cause a warning when building with C=1 or when enabling -Wunused-const-variable:

sound/soc/mediatek/mt8365/mt8365-dai-i2s.c:781:27: error: 'mt8365_i2s_hd_str' defined but not used [-Werror=unused-const-variable=]

Quoted 8 lines
   781 | static const char * const mt8365_i2s_hd_str[] = {
       |                           ^~~~~~~~~~~~~~~~~

Remove these for the moment, they can be added back if a user comes up.

Fixes 402bbb13a195 ("ASoC: mediatek: mt8365: Add I2S DAI support")
Signed-off-by Arnd Bergmann <[email protected]>
Reviewed-by Matthias Brugger <[email protected]>
Quoted 22 lines
---
  sound/soc/mediatek/mt8365/mt8365-dai-i2s.c | 7 -------
  1 file changed, 7 deletions(-)
sound/soc/mediatek/mt8365/mt8365-dai-i2s.c +0 -7
index 6b4d8b7e24ca..3482d8f8b4e7 100644
@@ -777,13 +777,6 @@ static struct snd_soc_dai_driver mtk_dai_i2s_driver[] = {
  	}
  };
 
-/* low jitter control */
-static const char * const mt8365_i2s_hd_str[] = {
-	"Normal", "Low_Jitter"
-};
-
-static SOC_ENUM_SINGLE_EXT_DECL(mt8365_i2s_enum, mt8365_i2s_hd_str);
-
  static const char * const fmi2sin_text[] = {
  	"OPEN", "FM_2ND_I2S_IN"
  };
maintainer
#2 lore raw
In reply to Arnd Bergmann
Quoted 9 lines · Arnd Bergmann

The mt8365_i2s_enum and mt8365_i2s_hd_str variables are not used anywhere, but cause a warning when building with C=1 or when enabling -Wunused-const-variable:

sound/soc/mediatek/mt8365/mt8365-dai-i2s.c:781:27: error: 'mt8365_i2s_hd_str' defined but not used [-Werror=unused-const-variable=]

  781 | static const char * const mt8365_i2s_hd_str[] = {
      |                           ^~~~~~~~~~~~~~~~~

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: mediatek: mt8365: remove unused mt8365_i2s_hd_str

      commit: 876dec03fdfb7eeb592d01a95ba292c9e53b324b

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark