lib/math: Add int_pow test suite
Subsystems (2)
PATCH v4 1/1 lib/math: Add int_pow test suite
Adds test suite for integer based power function.
---
Changes in v4:
- Address checkpatch warning and make kconfig description longer
- Use GPL-2.0-only for consistency
- Spelling fix fith -> fifth
Changes in v3:
- Fix compiler warning: explicitly define constant as unsigned int
- Add changes in patch revisions
Changes in v2:
- Address review feedback
- Add kconfig entry
- Use correct dir and file convention for KUnit
- Fix typo
- Remove unused static_stub header
- Refactor test suite to use paramerterized test cases
- Add close to max allowable value to in large_result test case
- Add test case with non-power of two exponent
- Fix module license
--- lib/Kconfig.debug | 9 ++++++ lib/math/Makefile | 1 + lib/math/tests/Makefile | 3 ++ lib/math/tests/int_pow_kunit.c | 52 ++++++++++++++++++++++++++++++++++ 4 files changed, 65 insertions(+) create mode 100644 lib/math/tests/Makefile create mode 100644 lib/math/tests/int_pow_kunit.c
lib/Kconfig.debug +9 -0
@@ -3051,3 +3051,12 @@ config RUST_KERNEL_DOCTESTS endmenu # "Rust" endmenu # Kernel hacking + +config INT_POW_TEST + tristate "Integer exponentiation (int_pow) test" if !KUNIT_ALL_TESTS + depends on KUNIT + default KUNIT_ALL_TESTS + help + This option enables the KUnit test suite for the int_pow function, + which performs integer exponentiation. The test suite is designed to + verify that the implementation of int_pow correctly computes the power
+ of a given base raised to a given exponent.
+
+ Enabling this option will include tests that check various scenarios + and edge cases to ensure the accuracy and reliability of the exponentiation + function.
+
+ If unsure, say N
lib/math/Makefile +1 -0
@@ -5,5 +5,6 @@ obj-$(CONFIG_CORDIC) += cordic.o obj-$(CONFIG_PRIME_NUMBERS) += prime_numbers.o obj-$(CONFIG_RATIONAL) += rational.o +obj-$(CONFIG_INT_POW_TEST) += tests/int_pow_kunit.o obj-$(CONFIG_TEST_DIV64) += test_div64.o obj-$(CONFIG_RATIONAL_KUNIT_TEST) += rational-test.o
lib/math/tests/Makefile new file +3 -0
@@ -0,0 +1,3 @@ +# SPDX-License-Identifier: GPL-2.0-only + +obj-$(CONFIG_INT_POW_TEST) += int_pow_kunit.o
lib/math/tests/int_pow_kunit.c new file +52 -0
52 lines not on this page · raw message
Signature · 1 line
2.46.0
kernel test robot
build botkernel test robot noticed the following build warnings:
Hi Luis,
kernel test robot noticed the following build warnings:
[auto build test WARNING on v6.11-rc6]
[also build test WARNING on linus/master next-20240906] [cannot apply to akpm-mm/mm-nonmm-unstable]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Luis-Felipe-Hernandez/lib-math-Add-int_pow-test-suite/20240909-065058 base: v6.11-rc6 patch link: https://lore.kernel.org/r/20240908224901.78595-1-luis.hernandez093%40gmail.com patch subject: [PATCH v4] lib/math: Add int_pow test suite config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20240909/[email protected]/config) compiler: m68k-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240909/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
>> lib/math/tests/int_pow_kunit.c:22:18: warning: integer constant is so large that it is unsigned
22 | { 2, 63, 9223372036854775808, "Large result"},
| ^~~~~~~~~~~~~~~~~~~vim +22 lib/math/tests/int_pow_kunit.c
12
13 static const struct test_case_params params[] = {
14 { 64, 0, 1, "Power of zero" },
15 { 64, 1, 64, "Power of one"},
16 { 0, 5, 0, "Base zero" },
17 { 1, 64, 1, "Base one" },
18 { 2, 2, 4, "Two squared"},
19 { 2, 3, 8, "Two cubed"},
20 { 5, 5, 3125, "Five raised to the fifth power" },
21 { U64_MAX, 1, U64_MAX, "Max base" },
> 22 { 2, 63, 9223372036854775808, "Large result"},
23 };
24 Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
kernel test robot
build botkernel test robot noticed the following build warnings:
Hi Luis,
kernel test robot noticed the following build warnings:
[auto build test WARNING on v6.11-rc6]
[also build test WARNING on linus/master next-20240909] [cannot apply to akpm-mm/mm-nonmm-unstable]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Luis-Felipe-Hernandez/lib-math-Add-int_pow-test-suite/20240909-065058 base: v6.11-rc6 patch link: https://lore.kernel.org/r/20240908224901.78595-1-luis.hernandez093%40gmail.com patch subject: [PATCH v4] lib/math: Add int_pow test suite config: arm64-randconfig-002-20240909 (https://download.01.org/0day-ci/archive/20240910/[email protected]/config) compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 05f5a91d00b02f4369f46d076411c700755ae041) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240910/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
>> lib/math/tests/int_pow_kunit.c:22:11: warning: integer literal is too large to be represented in a signed integer type, interpreting as unsigned [-Wimplicitly-unsigned-literal]
22 | { 2, 63, 9223372036854775808, "Large result"},
| ^1 warning generated.
vim +22 lib/math/tests/int_pow_kunit.c
12
13 static const struct test_case_params params[] = {
14 { 64, 0, 1, "Power of zero" },
15 { 64, 1, 64, "Power of one"},
16 { 0, 5, 0, "Base zero" },
17 { 1, 64, 1, "Base one" },
18 { 2, 2, 4, "Two squared"},
19 { 2, 3, 8, "Two cubed"},
20 { 5, 5, 3125, "Five raised to the fifth power" },
21 { U64_MAX, 1, U64_MAX, "Max base" },
> 22 { 2, 63, 9223372036854775808, "Large result"},
23 };
24 Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki