Skip to contentSkip to conversation

irqchip/riscv-imsic: Fix output text of base address

PATCH Applied Andrew Jones 4 participants 4 messages Sep 9, 2024 – Nov 12, 2024

Subsystems (3)
RISC-V irqchip drivers RISC-V AIA drivers
lore
Share & tools
lore

Andrew Jones

author
#0 lore raw

PATCH 1/1 irqchip/riscv-imsic: Fix output text of base address

The "per-CPU IDs ... at base ..." info log is outputting a physical address, not a PPN.

Fixes 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
Signed-off-by Andrew Jones <[email protected]>
---
 drivers/irqchip/irq-riscv-imsic-platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/irq-riscv-imsic-platform.c +1 -1
index 11723a763c10..c5ec66e0bfd3 100644
@@ -340,7 +340,7 @@ int imsic_irqdomain_init(void)
 		imsic->fwnode, global->hart_index_bits, global->guest_index_bits);
 	pr_info("%pfwP: group-index-bits: %d, group-index-shift: %d\n",
 		imsic->fwnode, global->group_index_bits, global->group_index_shift);
-	pr_info("%pfwP: per-CPU IDs %d at base PPN %pa\n",
+	pr_info("%pfwP: per-CPU IDs %d at base address %pa\n",
 		imsic->fwnode, global->nr_ids, &global->base_addr);
 	pr_info("%pfwP: total %d interrupts available\n",
 		imsic->fwnode, num_possible_cpus() * (global->nr_ids - 1));
Signature · 1 line
2.46.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Andrew Jones

The "per-CPU IDs ... at base ..." info log is outputting a physical address, not a PPN.

Fixes 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
Signed-off-by Andrew Jones <[email protected]>

LGTM.

Reviewed-by Anup Patel <[email protected]>

Regards,
Anup

Quoted 20 lines
---
 drivers/irqchip/irq-riscv-imsic-platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/irq-riscv-imsic-platform.c +1 -2
index 11723a763c10..c5ec66e0bfd3 100644
@@ -340,7 +340,7 @@ int imsic_irqdomain_init(void)
                imsic->fwnode, global->hart_index_bits, global->guest_index_bits);
        pr_info("%pfwP: group-index-bits: %d, group-index-shift: %d\n",
                imsic->fwnode, global->group_index_bits, global->group_index_shift);
-       pr_info("%pfwP: per-CPU IDs %d at base PPN %pa\n",
+       pr_info("%pfwP: per-CPU IDs %d at base address %pa\n",
                imsic->fwnode, global->nr_ids, &global->base_addr);
        pr_info("%pfwP: total %d interrupts available\n",
                imsic->fwnode, num_possible_cpus() * (global->nr_ids - 1));
--

2.46.0

merge bot Applied
#2 lore raw
In reply to Andrew Jones
The following commit has been merged into the irq/urgent branch of tip:

The following commit has been merged into the irq/urgent branch of tip:

Commit-ID:     4a1361e9a5c5dbb5c9f647762ae0cb1a605101fa
Gitweb:        https://git.kernel.org/tip/4a1361e9a5c5dbb5c9f647762ae0cb1a605101fa
Author:        Andrew Jones <[email protected]>
AuthorDate:    Mon, 09 Sep 2024 10:56:11 +02:00
Committer:     Thomas Gleixner <[email protected]>
CommitterDate: Wed, 02 Oct 2024 15:12:18 +02:00

irqchip/riscv-imsic: Fix output text of base address

The "per-CPU IDs ... at base ..." info log is outputting a physical address, not a PPN.

Fixes 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
Signed-off-by Andrew Jones <[email protected]>
Signed-off-by Thomas Gleixner <[email protected]>
Reviewed-by Anup Patel <[email protected]>
Link https://lore.kernel.org/all/[email protected] open here
---
 drivers/irqchip/irq-riscv-imsic-platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/irq-riscv-imsic-platform.c +1 -1
index 64905e6..c708780 100644
@@ -341,7 +341,7 @@ int imsic_irqdomain_init(void)
 		imsic->fwnode, global->hart_index_bits, global->guest_index_bits);
 	pr_info("%pfwP: group-index-bits: %d, group-index-shift: %d\n",
 		imsic->fwnode, global->group_index_bits, global->group_index_shift);
-	pr_info("%pfwP: per-CPU IDs %d at base PPN %pa\n",
+	pr_info("%pfwP: per-CPU IDs %d at base address %pa\n",
 		imsic->fwnode, global->nr_ids, &global->base_addr);
 	pr_info("%pfwP: total %d interrupts available\n",
 		imsic->fwnode, num_possible_cpus() * (global->nr_ids - 1));
CI Applied
#3 lore raw
In reply to Andrew Jones
This patch was applied to riscv/linux.git (fixes) by Thomas Gleixner <[email protected]>:

Hello:

This patch was applied to riscv/linux.git (fixes)
by Thomas Gleixner <[email protected]>:

Quoted 8 lines · On Mon, 9 Sep 2024 10:56:11 +0200 you wrote:

The "per-CPU IDs ... at base ..." info log is outputting a physical address, not a PPN.

Fixes 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
Signed-off-by Andrew Jones <[email protected]>
---
 drivers/irqchip/irq-riscv-imsic-platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- irqchip/riscv-imsic: Fix output text of base address

    https://git.kernel.org/riscv/c/4a1361e9a5c5

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html