platform: cznic: turris-omnia-mcu: fix HW_RANDOM dependency
PATCH 1/1 platform: cznic: turris-omnia-mcu: fix HW_RANDOM dependency
From: Arnd Bergmann <[email protected]>
There is still a build failure when the rwrng support is in a loadable module but the mcu driver is built-in:
arm-linux-gnueabi-ld: drivers/platform/cznic/turris-omnia-mcu-trng.o: in function `omnia_mcu_register_trng':
turris-omnia-mcu-trng.c:(.text.omnia_mcu_register_trng+0x11c): undefined reference to `devm_hwrng_register'
Change the dependency to explicitly disallow the broken configuration.
--- drivers/platform/cznic/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/cznic/Kconfig +1 -1
@@ -70,7 +70,7 @@ config TURRIS_OMNIA_MCU_TRNG bool "Turris Omnia MCU true random number generator" default y depends on TURRIS_OMNIA_MCU_GPIO - depends on HW_RANDOM + depends on HW_RANDOM=y || HW_RANDOM=TURRIS_OMNIA_MCU help Say Y here to add support for the true random number generator provided by CZ.NIC's Turris Omnia MCU.
Signature · 1 line
2.39.2
Quoted 33 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
There is still a build failure when the rwrng support is in a loadable module but the mcu driver is built-in:
arm-linux-gnueabi-ld:
drivers/platform/cznic/turris-omnia-mcu-trng.o: in function `omnia_mcu_register_trng':
turris-omnia-mcu-trng.c:(.text.omnia_mcu_register_trng+0x11c): undefined reference to `devm_hwrng_register'Change the dependency to explicitly disallow the broken configuration.
Fixes 41bb142a4028 ("platform: cznic: turris-omnia-mcu: Add support for MCU provided TRNG")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/platform/cznic/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/cznic/Kconfig +1
-1@@ -70,7 +70,7 @@ config TURRIS_OMNIA_MCU_TRNG bool "Turris Omnia MCU true random number generator" default y depends on TURRIS_OMNIA_MCU_GPIO - depends on HW_RANDOM + depends on HW_RANDOM=y || HW_RANDOM=TURRIS_OMNIA_MCU help Say Y here to add support for the true random number generator provided by CZ.NIC's Turris Omnia MCU.Signature · 1 line
2.39.2
This patch was applied to soc/soc.git (arm/fixes) by Arnd Bergmann <[email protected]>:
Hello:
This patch was applied to soc/soc.git (arm/fixes)
by Arnd Bergmann <[email protected]>:
Quoted 9 lines · On Mon, 9 Sep 2024 11:04:09 +0000 you wrote:
From: Arnd Bergmann <[email protected]>
There is still a build failure when the rwrng support is in a loadable module but the mcu driver is built-in:
arm-linux-gnueabi-ld:
drivers/platform/cznic/turris-omnia-mcu-trng.o: in function `omnia_mcu_register_trng':
turris-omnia-mcu-trng.c:(.text.omnia_mcu_register_trng+0x11c): undefined reference to `devm_hwrng_register'[...]
Here is the summary with links:
- platform: cznic: turris-omnia-mcu: fix HW_RANDOM dependency
https://git.kernel.org/soc/soc/c/b97acde6f984
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html