Skip to contentSkip to conversation

MAINTAINERS: record lib/buildid.c as owned by BPF subsystem

PATCH Applied Andrii Nakryiko 5 participants 5 messages Sep 9, 2024 – Sep 10, 2024 BPF

lore
Share & tools
lore

Andrii Nakryiko

author maintainer
#0 lore raw

PATCH 1/1 MAINTAINERS: record lib/buildid.c as owned by BPF subsystem

Build ID fetching code originated from ([0]), and is still both owned and heavily relied upon by BPF subsystem.

Fix the original omission in [0] to record this fact in MAINTAINERS.

[0] bd7525dacd7e ("bpf: Move stack_map_get_build_id into lib")

---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index f328373463b0..a86834bb4c25 100644
@@ -4098,6 +4098,7 @@ F:	include/uapi/linux/btf*
 F:	include/uapi/linux/filter.h
 F:	kernel/bpf/
 F:	kernel/trace/bpf_trace.c
+F:	lib/buildid.c
 F:	lib/test_bpf.c
 F:	net/bpf/
 F:	net/core/filter.c
@@ -4218,6 +4219,7 @@ L:	[email protected]
 S:	Maintained
 F:	kernel/bpf/stackmap.c
 F:	kernel/trace/bpf_trace.c
+F:	lib/buildid.c
 
 BROADCOM ASP 2.0 ETHERNET DRIVER
 M:	Justin Chen <[email protected]>
Signature · 1 line
2.43.5
#1 lore raw
Quoted 3 lines · Andrii Nakryiko

Build ID fetching code originated from ([0]), and is still both owned and heavily relied upon by BPF subsystem.

Song,

since you've added this logic back in commit 615755a77b24 ("bpf: extend stackmap to save binary_build_id+offset instead of address")

Pls provide your Ack.

Quoted 3 lines

Fix the original omission in [0] to record this fact in MAINTAINERS.

[0] bd7525dacd7e ("bpf: Move stack_map_get_build_id into lib")

Jiri,

since you moved it in that commit pls Ack as well.

This change to the MAINTAINERS file should have been done back then.

So it's obvious who understands and maintains this code.

Currently get_maintainer.pl script is not helpful:

$ ./scripts/get_maintainer.pl lib/buildid.c
Andrew Morton <[email protected]> (supporter:LIBRARY CODE)
[email protected] (open list:LIBRARY CODE)
reviewer Acked-by on v1 1/1
#2 lore raw
In reply to Andrii Nakryiko
Quoted 9 lines · Andrii Nakryiko

Build ID fetching code originated from ([0]), and is still both owned and heavily relied upon by BPF subsystem.

Fix the original omission in [0] to record this fact in MAINTAINERS.

[0] bd7525dacd7e ("bpf: Move stack_map_get_build_id into lib")

Thanks for making buildid parsing more reliable!

Song

Acked-by on v1 1/1
#3 lore raw
In reply to Andrii Nakryiko
Quoted 8 lines · Andrii Nakryiko

Build ID fetching code originated from ([0]), and is still both owned and heavily relied upon by BPF subsystem.

Fix the original omission in [0] to record this fact in MAINTAINERS.

[0] bd7525dacd7e ("bpf: Move stack_map_get_build_id into lib")

thanks,
jirka

Quoted 27 lines
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index f328373463b0..a86834bb4c25 100644
@@ -4098,6 +4098,7 @@ F:	include/uapi/linux/btf*
 F:	include/uapi/linux/filter.h
 F:	kernel/bpf/
 F:	kernel/trace/bpf_trace.c
+F:	lib/buildid.c
 F:	lib/test_bpf.c
 F:	net/bpf/
 F:	net/core/filter.c
@@ -4218,6 +4219,7 @@ L:	[email protected]
 S:	Maintained
 F:	kernel/bpf/stackmap.c
 F:	kernel/trace/bpf_trace.c
+F:	lib/buildid.c
 
 BROADCOM ASP 2.0 ETHERNET DRIVER
 M:	Justin Chen <[email protected]>
Signature · 1 line
2.43.5
#4 lore raw
In reply to Andrii Nakryiko
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:

Quoted 8 lines · On Mon, 9 Sep 2024 12:04:26 -0700 you wrote:

Build ID fetching code originated from ([0]), and is still both owned and heavily relied upon by BPF subsystem.

Fix the original omission in [0] to record this fact in MAINTAINERS.

[0] bd7525dacd7e ("bpf: Move stack_map_get_build_id into lib")

[...]

Here is the summary with links:
- [bpf-next] MAINTAINERS: record lib/buildid.c as owned by BPF subsystem

    https://git.kernel.org/bpf/bpf-next/c/58ff04e2e223

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html