perf ftrace: Detect whether ftrace is enabled on system
PATCH 1/1 perf ftrace: Detect whether ftrace is enabled on system
To make error messages more accurate, this change detects whether ftrace is enabled on system by checking trace file "set_ftrace_pid".
Before:
~ # perf ftrace
failed to reset ftrace
After:
~ # perf ftrace
ftrace is not supported on this system
--- tools/perf/builtin-ftrace.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)
tools/perf/builtin-ftrace.c +24 -0
@@ -1112,6 +1112,24 @@ static int parse_graph_tracer_opts(const struct option *opt,return 0 ; } +static bool is_ftrace_supported (void ) +{ +char *file; +bool supported = false; + + file =get_tracing_file ("set_ftrace_pid" ); +if (!file) { +pr_debug ("cannot get tracing file set_ftrace_pid\n" ); +return false; + } + +if (!access (file,F_OK )) + supported = true; + +put_tracing_file (file); +return supported; +} +enum perf_ftrace_subcommand {PERF_FTRACE_NONE ,PERF_FTRACE_TRACE ,
@@ -1254,6 +1272,12 @@ int cmd_ftrace(int argc, const char **argv) goto out_delete_filters; } +if (!is_ftrace_supported ()) { +pr_err ("ftrace is not supported on this system\n" ); + ret = -ENOTSUP ; + goto out_delete_filters; + } + ret =target__validate (&ftrace.target);if (ret) {char errbuf[512 ];
Signature · 1 line
2.34.1
Quoted 46 lines · Changbin Du
To make error messages more accurate, this change detects whether ftrace is enabled on system by checking trace file "
set_ftrace_pid".Before:
~ # perf ftrace
failed to reset ftraceAfter:
~ # perf ftrace
ftrace is not supported on this systemSigned-off-by Changbin Du <[email protected]>--- tools/perf/builtin-ftrace.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)tools/perf/builtin-ftrace.c +18
-0@@ -1112,6 +1112,24 @@ static int parse_graph_tracer_opts(const struct option *opt,return 0 ; } +static bool is_ftrace_supported (void ) +{ +char *file; +bool supported = false; + + file =get_tracing_file ("set_ftrace_pid" ); +if (!file) { +pr_debug ("cannot get tracing file set_ftrace_pid\n" ); +return false; + } + +if (!access (file,F_OK )) + supported = true; + +put_tracing_file (file); +return supported; +} +enum perf_ftrace_subcommand {PERF_FTRACE_NONE ,PERF_FTRACE_TRACE ,
tools/perf/builtin-ftrace.c int cmd_ftrace(int argc, const char **argv) · line 1280
Quoted 9 lines
tools/perf/builtin-ftrace.c +6
-0@@ -1254,6 +1272,12 @@ int cmd_ftrace(int argc, const char **argv) goto out_delete_filters; } +if (!is_ftrace_supported ()) { +pr_err ("ftrace is not supported on this system\n" ); + ret = -ENOTSUP ; + goto out_delete_filters; + } +
Very minor nit, but you could probably put this earlier next to check_ftrace_capable(). It didn't look like it used any of the config or parsing results.
Either way:
Quoted 52 lines · James Clark
Quoted 49 lines · Changbin Du
To make error messages more accurate, this change detects whether ftrace is enabled on system by checking trace file "
set_ftrace_pid".Before:
~ # perf ftrace
failed to reset ftraceAfter:
~ # perf ftrace
ftrace is not supported on this systemSigned-off-by Changbin Du <[email protected]>--- tools/perf/builtin-ftrace.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)tools/perf/builtin-ftrace.c +20
-0@@ -1112,6 +1112,24 @@ static int parse_graph_tracer_opts(const struct option *opt,return 0 ; } +static bool is_ftrace_supported (void ) +{ +char *file; +bool supported = false; + + file =get_tracing_file ("set_ftrace_pid" ); +if (!file) { +pr_debug ("cannot get tracing file set_ftrace_pid\n" ); +return false; + } + +if (!access (file,F_OK )) + supported = true; + +put_tracing_file (file); +return supported; +} +enum perf_ftrace_subcommand {PERF_FTRACE_NONE ,PERF_FTRACE_TRACE ,@@ -1254,6 +1272,12 @@ int cmd_ftrace(int argc, const char **argv) goto out_delete_filters; } +if (!is_ftrace_supported ()) { +pr_err ("ftrace is not supported on this system\n" );
Quoted 9 lines
tools/perf/builtin-ftrace.c int cmd_ftrace(int argc, const char **argv) · line 1280
Quoted 4 lines
tools/perf/builtin-ftrace.c +4
-0+ ret = -ENOTSUP ; + goto out_delete_filters; + } +Very minor nit, but you could probably put this earlier next to
check_ftrace_capable(). It didn't look like it used any of the config or parsing results.
Thansk, I will rebase this on perf-tools-next branch.
Quoted 3 lines
Either way:
Reviewed-by James Clark <[email protected]>
Signature · 2 lines
Cheers, Changbin Du