Skip to contentSkip to conversation

bpftool: Fix undefined behavior in qsort(NULL, 0, ...)

PATCH Applied Kuan-Wei Chiu 3 participants 3 messages Sep 10, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 bpftool: Fix undefined behavior in qsort(NULL, 0, ...)

When netfilter has no entry to display, qsort is called with qsort(NULL, 0, ...). This results in undefined behavior, as UBSan reports:

net.c:827:2: runtime error: null pointer passed as argument 1, which is declared to never be null

Although the C standard does not explicitly state whether calling qsort with a NULL pointer when the size is 0 constitutes undefined behavior, Section 7.1.4 of the C standard (Use of library functions) mentions:

"Each of the following statements applies unless explicitly stated otherwise in the detailed descriptions that follow: If an argument to a function has an invalid value (such as a value outside the domain of the function, or a pointer outside the address space of the program, or a null pointer, or a pointer to non-modifiable storage when the corresponding parameter is not const-qualified) or a type (after promotion) not expected by a function with variable number of arguments, the behavior is undefined."

To avoid this, add an early return when nf_link_info is NULL to prevent calling qsort with a NULL pointer.

---
Changes in v2:
- Change from checking nf_link_count to checking nf_link_info.

 tools/bpf/bpftool/net.c | 3 +++
 1 file changed, 3 insertions(+)
tools/bpf/bpftool/net.c +3 -0
index 968714b4c3d4..0ad684e810f3 100644
@@ -824,6 +824,9 @@ static void show_link_netfilter(void)
 		nf_link_count++;
 	}
 
+	if (!nf_link_info)
+		return;
+
 	qsort(nf_link_info, nf_link_count, sizeof(*nf_link_info), netfilter_link_compar);
 
 	for (id = 0; id < nf_link_count; id++) {
Signature · 1 line
2.34.1
maintainer Reviewed-by on v2 1/1
#1 lore raw

2024-09-10 23:02 UTC+0800 ~ Kuan-Wei Chiu <[email protected]>

Quoted 35 lines

When netfilter has no entry to display, qsort is called with qsort(NULL, 0, ...). This results in undefined behavior, as UBSan reports:

net.c:827:2: runtime error: null pointer passed as argument 1, which is declared to never be null

Although the C standard does not explicitly state whether calling qsort with a NULL pointer when the size is 0 constitutes undefined behavior, Section 7.1.4 of the C standard (Use of library functions) mentions:

"Each of the following statements applies unless explicitly stated otherwise in the detailed descriptions that follow: If an argument to a function has an invalid value (such as a value outside the domain of the function, or a pointer outside the address space of the program, or a null pointer, or a pointer to non-modifiable storage when the corresponding parameter is not const-qualified) or a type (after promotion) not expected by a function with variable number of arguments, the behavior is undefined."

To avoid this, add an early return when nf_link_info is NULL to prevent calling qsort with a NULL pointer.

---
Changes in v2:
- Change from checking nf_link_count to checking nf_link_info.

  tools/bpf/bpftool/net.c | 3 +++
  1 file changed, 3 insertions(+)
tools/bpf/bpftool/net.c +0 -0
index 968714b4c3d4..0ad684e810f3 100644

tools/bpf/bpftool/net.c static void show_link_netfilter(void) · line 832

Quoted 9 lines
tools/bpf/bpftool/net.c +3 -0
@@ -824,6 +824,9 @@ static void show_link_netfilter(void)
  		nf_link_count++;
  	}
 
+	if (!nf_link_info)
+		return;
+
  	qsort(nf_link_info, nf_link_count, sizeof(*nf_link_info), netfilter_link_compar);
 
  	for (id = 0; id < nf_link_count; id++) {

Thanks!

#2 lore raw
In reply to Kuan-Wei Chiu
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:

Quoted 11 lines · On Tue, 10 Sep 2024 23:02:07 +0800 you wrote:

When netfilter has no entry to display, qsort is called with qsort(NULL, 0, ...). This results in undefined behavior, as UBSan reports:

net.c:827:2: runtime error: null pointer passed as argument 1, which is declared to never be null

Although the C standard does not explicitly state whether calling qsort with a NULL pointer when the size is 0 constitutes undefined behavior, Section 7.1.4 of the C standard (Use of library functions) mentions:

[...]

Here is the summary with links:
- [v2] bpftool: Fix undefined behavior in qsort(NULL, 0, ...)

    https://git.kernel.org/bpf/bpf-next/c/f04e2ad394e2

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html