Skip to contentSkip to conversation

Tegra234: Add AGX Orin SKU8 support

PATCH In review Dara Stotland 3 participants 6 messages Sep 10, 2024 – Sep 25, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Tegra234: Add AGX Orin SKU8 support

This patchset adds support for the AGX Orin Industrial Module (SKU8) in the AGX Orin Developer Kit.

Dara Stotland (2):
dt-bindings: arm: Tegra234 Industrial Module
arm64: tegra: Create SKU8 AGX Orin board file

 .../devicetree/bindings/arm/tegra.yaml        |   5 +
 arch/arm64/boot/dts/nvidia/Makefile           |   1 +
 .../nvidia/tegra234-p3737-0000+p3701-0000.dts | 544 +----------------
 .../nvidia/tegra234-p3737-0000+p3701-0008.dts |  11 +
 .../dts/nvidia/tegra234-p3737-0000+p3701.dtsi | 547 ++++++++++++++++++
 5 files changed, 566 insertions(+), 542 deletions(-)
 create mode 100644 arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dts
 create mode 100644 arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701.dtsi
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/2 dt-bindings: arm: Tegra234 Industrial Module

Add support for AGX Orin Industrial Module with AGX Orin Developer Kit.

---
 Documentation/devicetree/bindings/arm/tegra.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/tegra.yaml +5 -0
index 8fb4923517d0..e108ef0cde86 100644
@@ -175,6 +175,11 @@ properties:
           - const: nvidia,p3737-0000+p3701-0000
           - const: nvidia,p3701-0000
           - const: nvidia,tegra234
+      - description: Jetson AGX Orin Developer Kit with Industrial Module
+        items:
+          - const: nvidia,p3737-0000+p3701-0008
+          - const: nvidia,p3701-0008
+          - const: nvidia,tegra234
       - description: NVIDIA IGX Orin Development Kit
         items:
           - const: nvidia,p3740-0002+p3701-0008
Signature · 1 line
2.17.1
#3 lore raw

PATCH 2/2 arm64: tegra: Create SKU8 AGX Orin board file

In reply to Dara Stotland

The existing tegra234-p3737-0000+p3701-0000.dtb is compatible with the following modules:

p3701-0000
p3701-0004
p3701-0005

Add support for p3701-0008. Move data that is common to all SKUs to a new file called tegra234-p3737-0000+p3701.dtsi. Update Makefile.

---
 arch/arm64/boot/dts/nvidia/Makefile           |   1 +
 .../nvidia/tegra234-p3737-0000+p3701-0000.dts | 544 +----------------
 .../nvidia/tegra234-p3737-0000+p3701-0008.dts |  11 +
 .../dts/nvidia/tegra234-p3737-0000+p3701.dtsi | 547 ++++++++++++++++++
 4 files changed, 561 insertions(+), 542 deletions(-)
 create mode 100644 arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dts
 create mode 100644 arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701.dtsi
arch/arm64/boot/dts/nvidia/Makefile +1 -0
index c38c809fe577..0fbb8a494dba 100644
@@ -27,6 +27,7 @@ dtb-$(CONFIG_ARCH_TEGRA_194_SOC) += tegra194-p3509-0000+p3668-0000.dtb
 dtb-$(CONFIG_ARCH_TEGRA_194_SOC) += tegra194-p3509-0000+p3668-0001.dtb
 dtb-$(CONFIG_ARCH_TEGRA_234_SOC) += tegra234-sim-vdk.dtb
 dtb-$(CONFIG_ARCH_TEGRA_234_SOC) += tegra234-p3737-0000+p3701-0000.dtb
+dtb-$(CONFIG_ARCH_TEGRA_234_SOC) += tegra234-p3737-0000+p3701-0008.dtb
 dtb-$(CONFIG_ARCH_TEGRA_234_SOC) += tegra234-p3740-0002+p3701-0008.dtb
 dtb-$(CONFIG_ARCH_TEGRA_234_SOC) += tegra234-p3768-0000+p3767-0000.dtb
 dtb-$(CONFIG_ARCH_TEGRA_234_SOC) += tegra234-p3768-0000+p3767-0005.dtb
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts +2 -542

553 lines not on this page · raw message

arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dts new file +11 -0
new file mode 100644
index 000000000000..979f085691a1
@@ -0,0 +1,11 @@
+// SPDX-License-Identifier: GPL-2.0
+/dts-v1/;
+
+// Module files must be included first
+#include "tegra234-p3701-0008.dtsi"
+#include "tegra234-p3737-0000+p3701.dtsi"
+
+/ {
+	model = "NVIDIA Jetson AGX Orin Developer Kit";
+	compatible = "nvidia,p3737-0000+p3701-0008", "nvidia,p3701-0008", "nvidia,tegra234";
+};
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701.dtsi new file +547 -0

547 lines not on this page · raw message

Signature · 1 line
2.17.1
#4 lore raw
In reply to Dara Stotland
Quoted 16 lines · Dara Stotland

This patchset adds support for the AGX Orin Industrial Module (SKU8) in the AGX Orin Developer Kit.

Dara Stotland (2):
dt-bindings: arm: Tegra234 Industrial Module
arm64: tegra: Create SKU8 AGX Orin board file

 .../devicetree/bindings/arm/tegra.yaml        |   5 +
 arch/arm64/boot/dts/nvidia/Makefile           |   1 +
 .../nvidia/tegra234-p3737-0000+p3701-0000.dts | 544 +----------------
 .../nvidia/tegra234-p3737-0000+p3701-0008.dts |  11 +
 .../dts/nvidia/tegra234-p3737-0000+p3701.dtsi | 547 ++++++++++++++++++
 5 files changed, 566 insertions(+), 542 deletions(-)
 create mode 100644 arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dts
 create mode 100644 arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701.dtsi
Quoted 5 lines

--
2.17.1

My bot found new DTB warnings on the .dts files added or changed in this series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

New warnings running 'make CHECK_DTBS=y nvidia/tegra234-p3737-0000+p3701-0000.dtb nvidia/tegra234-p3737-0000+p3701-0008.dtb' for [email protected]:

arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: gpio@2200000: 'gpio-ranges' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/gpio/nvidia,tegra186-gpio.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: ahub@2900800: admaif@290f000: 'interconnect-names', 'interconnects', 'iommus' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/sound/nvidia,tegra210-ahub.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: admaif@290f000: 'interconnect-names', 'interconnects', 'iommus' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/sound/nvidia,tegra210-admaif.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: /bus@0/serial@31d0000: failed to match any schema with compatible: ['arm,sbsa-uart'] arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: /bus@0/i2c@31e0000/audio-codec@1c: failed to match any schema with compatible: ['realtek,rt5640'] arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: hda@3510000: compatible: 'oneOf' conditional failed, one must be fixed:
['nvidia,tegra234-hda'] is too short
'nvidia,tegra30-hda' was expected
'nvidia,tegra132-hda' was expected
from schema $id: http://devicetree.org/schemas/sound/nvidia,tegra30-hda.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: hda@3510000: clock-names:1: 'hda2hdmi' was expected
from schema $id: http://devicetree.org/schemas/sound/nvidia,tegra30-hda.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: hda@3510000: reset-names:1: 'hda2hdmi' was expected
from schema $id: http://devicetree.org/schemas/sound/nvidia,tegra30-hda.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: padctl@3520000: ports:usb2-0: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/phy/nvidia,tegra194-xusb-padctl.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: padctl@3520000: ports:usb2-0: 'connector' is a dependency of 'usb-role-switch'
from schema $id: http://devicetree.org/schemas/phy/nvidia,tegra194-xusb-padctl.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: padctl@3520000: ports:usb2-1: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/phy/nvidia,tegra194-xusb-padctl.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: padctl@3520000: ports:usb3-0: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/phy/nvidia,tegra194-xusb-padctl.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: padctl@3520000: ports:usb3-1: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/phy/nvidia,tegra194-xusb-padctl.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: ethernet@6800000: phy-mode: ['10gbase-r'] does not contain items matching the given schema
from schema $id: http://devicetree.org/schemas/net/nvidia,tegra234-mgbe.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: ethernet@6800000: 'snps,axi-config', 'stmmac-axi-config' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/net/nvidia,tegra234-mgbe.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: ethernet@6900000: 'snps,axi-config', 'stmmac-axi-config' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/net/nvidia,tegra234-mgbe.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: ethernet@6a00000: 'snps,axi-config', 'stmmac-axi-config' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/net/nvidia,tegra234-mgbe.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: gpio@c2f0000: 'gpio-ranges' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/gpio/nvidia,tegra186-gpio.yaml#

Reviewed-by on the v1 series
#5 lore raw
In reply to Dara Stotland
Quoted 7 lines · Dara Stotland

This patchset adds support for the AGX Orin Industrial Module (SKU8) in the AGX Orin Developer Kit.

Dara Stotland (2):
dt-bindings: arm: Tegra234 Industrial Module
arm64: tegra: Create SKU8 AGX Orin board file

Quoted 9 lines
  .../devicetree/bindings/arm/tegra.yaml        |   5 +
  arch/arm64/boot/dts/nvidia/Makefile           |   1 +
  .../nvidia/tegra234-p3737-0000+p3701-0000.dts | 544 +----------------
  .../nvidia/tegra234-p3737-0000+p3701-0008.dts |  11 +
  .../dts/nvidia/tegra234-p3737-0000+p3701.dtsi | 547 ++++++++++++++++++
  5 files changed, 566 insertions(+), 542 deletions(-)

create mode 100644 arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dts create mode 100644 arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701.dtsi

The warnings that Rob Herring's bot detected are pre-existing. These patches look good to me.