firmware: coreboot: Don't register a pdev if screen_info data is present
PATCH v3 1/1 firmware: coreboot: Don't register a pdev if screen_info data is present
On coreboot platforms, a system framebuffer may be provided to the Linux kernel by filling a LB_TAG_FRAMEBUFFER entry in the coreboot table. But a coreboot payload (e.g: SeaBIOS) could also provide its own framebuffer information to the Linux kernel.
If that's the case, arch x86 boot code will fill the global screen_info data and this used by the Generic System Framebuffers (sysfb) framework, to register a platform device with pdata about the system's framebuffer.
But later, the framebuffer_coreboot driver will try to do the same and attempt to register a "simple-framebuffer" platform device (using the information from the coreboot table), which will lead to an error due a device with the same name already being registered:
sysfs: cannot create duplicate filename '/bus/platform/devices/simple-framebuffer.0'
...
coreboot: could not register framebuffer
framebuffer coreboot8: probe with driver framebuffer failed with error -17
To prevent this issue, make the framebuffer_core driver to not register a platform device if the global struct screen_info data has been filled.
---
Changes in v3:
- Fix coreboot spelling to be all in lowercase (Julius Werner).
Changes in v2:
- Declare the struct screen_info as constant variable (Thomas Zimmermann).
- Use screen_info_video_type() instead of checking the screen_info video types directly (Thomas Zimmermann).
- Fix missing "device" word in a comment (Brian Norris).
- Fix some mispellings in a comment (Brian Norris).
- Change error code returned from -EINVAL to -ENODEV (Brian Norris).
drivers/firmware/google/framebuffer-coreboot.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
drivers/firmware/google/framebuffer-coreboot.c +17 -0
@@ -15,6 +15,7 @@#include <linux/module.h> #include <linux/platform_data/simplefb.h> #include <linux/platform_device.h> +#include <linux/screen_info.h> #include "coreboot_table.h"
@@ -27,8 +28,10 @@ static int framebuffer_probe(struct coreboot_device *dev)int i;u32 length;struct lb_framebuffer *fb = &dev->framebuffer; +const struct screen_info *si = &screen_info;struct platform_device *pdev;struct resource res; +unsigned int type;struct simplefb_platform_data pdata = { .width = fb->x_resolution, .height = fb->y_resolution,
@@ -36,6 +39,20 @@ static int framebuffer_probe(struct coreboot_device *dev) .format = NULL, }; +/* +* On coreboot systems, the advertised LB_TAG_FRAMEBUFFER entry +* in the coreboot table should only be used if the payload did +* not pass a framebuffer information to the Linux kernel. +* +* If the global screen_info data has been filled, the Generic +* System Framebuffers (sysfb) will already register a platform +* device and pass that screen_info as platform_data to a driver +* that can scan-out using the system provided framebuffer. +*/ + type =screen_info_video_type (si); +if (type) +return -ENODEV ; +if (!fb->physical_address)return -ENODEV ;
Signature · 1 line
2.46.0
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for firmware: coreboot: Don't register a pdev if screen_info data is present (rev2)
== Series Details ==
== Series Details ==
Series: firmware: coreboot: Don't register a pdev if screen_info data is present (rev2)
URL : https://patchwork.freedesktop.org/series/138665/
State : warning
== Summary ==
Error: dim checkpatch failed87d709d4b8a4 firmware: coreboot: Don't register a pdev if screen_info data is present
-:21: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #21:
sysfs: cannot create duplicate filename '/bus/platform/devices/simple-framebuffer.0'
total: 0 errors, 1 warnings, 0 checks, 37 lines checked
Patchwork
CI✗ Fi.CI.BAT: failure for firmware: coreboot: Don't register a pdev if screen_info data is present (rev2)
In reply to Javier Martinez Canillas== Series Details ==
== Series Details ==
Series: firmware: coreboot: Don't register a pdev if screen_info data is present (rev2)
URL : https://patchwork.freedesktop.org/series/138665/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_15418 -> Patchwork_138665v2
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_138665v2 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_138665v2, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138665v2/index.html
Participating hosts (42 -> 37)
------------------------------
Missing (5): bat-kbl-2 fi-bsw-n3050 fi-snb-2520m fi-kbl-8809g bat-dg2-11
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_138665v2:
### IGT changes ###
#### Possible regressions ####
* igt@kms_flip@basic-flip-vs-dpms:
- bat-arls-5: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15418/bat-arls-5/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138665v2/bat-arls-5/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_138665v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@fbdev@read:
- bat-arls-1: [PASS][3] -> [DMESG-WARN][4] ([i915#12102])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15418/bat-arls-1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138665v2/bat-arls-1/igt@[email protected]
* igt@kms_flip@basic-flip-vs-dpms@b-dp3:
- bat-arls-5: [PASS][5] -> [FAIL][6] ([i915#12143])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15418/bat-arls-5/igt@kms_flip@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138665v2/bat-arls-5/igt@kms_flip@[email protected]
* igt@kms_flip@basic-flip-vs-dpms@d-dp3:
- bat-arls-5: [PASS][7] -> [FAIL][8] ([i915#12144]) +1 other test fail
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15418/bat-arls-5/igt@kms_flip@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138665v2/bat-arls-5/igt@kms_flip@[email protected]
#### Possible fixes ####
* igt@fbdev@eof:
- bat-arls-1: [DMESG-WARN][9] ([i915#12102]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15418/bat-arls-1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138665v2/bat-arls-1/igt@[email protected]
* igt@i915_selftest@live:
- bat-arlh-2: [ABORT][11] ([i915#12133]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15418/bat-arlh-2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138665v2/bat-arlh-2/igt@[email protected]
* igt@i915_selftest@live@workarounds:
- bat-arlh-2: [ABORT][13] ([i915#12061]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15418/bat-arlh-2/igt@i915_selftest@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138665v2/bat-arlh-2/igt@i915_selftest@[email protected]
- bat-mtlp-6: [ABORT][15] ([i915#12061]) -> [PASS][16] +1 other test pass
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15418/bat-mtlp-6/igt@i915_selftest@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138665v2/bat-mtlp-6/igt@i915_selftest@[email protected]
#### Warnings ####
* igt@i915_selftest@live:
- bat-arls-5: [DMESG-WARN][17] ([i915#10341] / [i915#12133]) -> [ABORT][18] ([i915#12133] / [i915#12175])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15418/bat-arls-5/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138665v2/bat-arls-5/igt@[email protected]
* igt@i915_selftest@live@workarounds:
- bat-arls-5: [DMESG-WARN][19] ([i915#10341] / [i915#11637]) -> [ABORT][20] ([i915#12061])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15418/bat-arls-5/igt@i915_selftest@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138665v2/bat-arls-5/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#10341]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10341
[i915#11637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11637
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#12102]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12102
[i915#12133]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12133
[i915#12143]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12143
[i915#12144]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12144
[i915#12175]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12175
Build changes
-------------
* Linux: CI_DRM_15418 -> Patchwork_138665v2
CI-20190529: 20190529
CI_DRM_15418: 2530827ab017894f2339dd308356366d6e87a72d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8019: 8019
Patchwork_138665v2: 2530827ab017894f2339dd308356366d6e87a72d @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_138665v2/index.html
kernel test robot
build botkernel test robot noticed the following build errors:
Hi Javier,
kernel test robot noticed the following build errors:
[auto build test ERROR on chrome-platform/for-next]
[also build test ERROR on chrome-platform/for-firmware-next linus/master v6.11-rc7 next-20240913] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Javier-Martinez-Canillas/firmware-coreboot-Don-t-register-a-pdev-if-screen_info-data-is-present/20240914-053323 base: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next patch link: https://lore.kernel.org/r/20240913213246.1549213-1-javierm%40redhat.com patch subject: [PATCH v3] firmware: coreboot: Don't register a pdev if screen_info data is present config: csky-randconfig-002-20240915 (https://download.01.org/0day-ci/archive/20240915/[email protected]/config) compiler: csky-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240915/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>, old ones prefixed by <<):
WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/locking/test-ww_mutex.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/usb_debug.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/mxuport.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/symbolserial.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/devfreq/governor_simpleondemand.o
>> ERROR: modpost: "screen_info" [drivers/firmware/google/framebuffer-coreboot.ko] undefined!
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
kernel test robot
build botkernel test robot noticed the following build errors:
Hi Javier,
kernel test robot noticed the following build errors:
[auto build test ERROR on chrome-platform/for-next]
[also build test ERROR on chrome-platform/for-firmware-next linus/master v6.11-rc7 next-20240913] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Javier-Martinez-Canillas/firmware-coreboot-Don-t-register-a-pdev-if-screen_info-data-is-present/20240914-053323 base: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next patch link: https://lore.kernel.org/r/20240913213246.1549213-1-javierm%40redhat.com patch subject: [PATCH v3] firmware: coreboot: Don't register a pdev if screen_info data is present config: riscv-randconfig-001-20240915 (https://download.01.org/0day-ci/archive/20240915/[email protected]/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240915/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
>> ld.lld: error: undefined symbol: screen_info >>> referenced by framebuffer-coreboot.c:27 (drivers/firmware/google/framebuffer-coreboot.c:27) >>> drivers/firmware/google/framebuffer-coreboot.o:(framebuffer_probe) in archive vmlinux.a >>> referenced by framebuffer-coreboot.c:27 (drivers/firmware/google/framebuffer-coreboot.c:27) >>> drivers/firmware/google/framebuffer-coreboot.o:(framebuffer_probe) in archive vmlinux.a
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Hi
Am 15.09.24 um 09:44 schrieb kernel test robot:
Quoted 18 lines
Hi Javier,
kernel test robot noticed the following build errors:
[auto build test ERROR on chrome-platform/for-next]
[also build test ERROR on chrome-platform/for-firmware-next linus/master v6.11-rc7 next-20240913] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]url: https://github.com/intel-lab-lkp/linux/commits/Javier-Martinez-Canillas/firmware-coreboot-Don-t-register-a-pdev-if-screen_info-data-is-present/20240914-053323 base: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next patch link: https://lore.kernel.org/r/20240913213246.1549213-1-javierm%40redhat.com patch subject: [PATCH v3] firmware: coreboot: Don't register a pdev if screen_info data is present config: riscv-randconfig-001-20240915 (https://download.01.org/0day-ci/archive/20240915/[email protected]/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240915/[email protected]/reproduce)
Quoted 12 lines
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/All errors (new ones prefixed by >>):
Quoted 5 lines
Quoted 5 lines
ld.lld: error: undefined symbol:
screen_infoQuoted 4 lines
referenced by framebuffer-coreboot.c:27 (
drivers/firmware/google/framebuffer-coreboot.c:27)
drivers/firmware/google/framebuffer-coreboot.o:(framebuffer_probe) in archive vmlinux.a
referenced by framebuffer-coreboot.c:27 (drivers/firmware/google/framebuffer-coreboot.c:27)
drivers/firmware/google/framebuffer-coreboot.o:(framebuffer_probe) in archive vmlinux.a
Not all platforms define screen_info. Maybe fix this by following Tzung-Bi's advice of removing the local variables and then guard the test by CONFIG_SYSFB. If SYSFB has been defined, screen_info has to be there. It's not a super pretty solution, though.
Best regards
Thomas
Quoted 1 line
Signature · 7 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
Thomas Zimmermann <[email protected]> writes:
Hello Thomas and Tzung-Bi,
Quoted 28 lines
Hi
Am 15.09.24 um 09:44 schrieb kernel test robot:
Quoted 25 lines
Hi Javier,
kernel test robot noticed the following build errors:
[auto build test ERROR on chrome-platform/for-next]
[also build test ERROR on chrome-platform/for-firmware-next linus/master v6.11-rc7 next-20240913] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]url: https://github.com/intel-lab-lkp/linux/commits/Javier-Martinez-Canillas/firmware-coreboot-Don-t-register-a-pdev-if-screen_info-data-is-present/20240914-053323 base: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next patch link: https://lore.kernel.org/r/20240913213246.1549213-1-javierm%40redhat.com patch subject: [PATCH v3] firmware: coreboot: Don't register a pdev if screen_info data is present config: riscv-randconfig-001-20240915 (https://download.01.org/0day-ci/archive/20240915/[email protected]/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240915/[email protected]/reproduce)If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/All errors (new ones prefixed by >>):
Quoted 7 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
ld.lld: error: undefined symbol:
screen_infoQuoted 4 lines
referenced by framebuffer-coreboot.c:27 (
drivers/firmware/google/framebuffer-coreboot.c:27)
drivers/firmware/google/framebuffer-coreboot.o:(framebuffer_probe) in archive vmlinux.a
referenced by framebuffer-coreboot.c:27 (drivers/firmware/google/framebuffer-coreboot.c:27)
drivers/firmware/google/framebuffer-coreboot.o:(framebuffer_probe) in archive vmlinux.aNot all platforms define
screen_info. Maybe fix this by following
Yes, after reading the build errors reported by the robot I remembered that we had similar issues with sysfb, for example commit 1260b9a7020 ("drivers/firmware: fix SYSFB depends to prevent build failures") fixed one of those.
Quoted 4 lines
Tzung-Bi's advice of removing the local variables and then guard the test by
CONFIG_SYSFB. If SYSFB has been defined,screen_infohas to be there. It's not a super pretty solution, though.
If possible I would prefer to avoid the ifdefery in the driver. I also believe that the local variables makes the code easier to read. But if you folks think that's better to drop them, I can do it in the next rev.
Another option is to restrict the architectures where this driver could be build. As far as I understand it is mainly for x86 and ARM64 arches.
These two have a screen_info defined so the driver will build correctly. I can include a preparatory patch that adds a "depends on x86 || ARM64".
Quoted 3 lines
Best regards
Thomas
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat
Hi Javier
Am 16.09.24 um 10:36 schrieb Javier Martinez Canillas:
Quoted 51 lines
Thomas Zimmermann <[email protected]> writes:
Hello Thomas and Tzung-Bi,
Quoted 26 lines
Hi
Am 15.09.24 um 09:44 schrieb kernel test robot:
Quoted 23 lines
Hi Javier,
kernel test robot noticed the following build errors:
[auto build test ERROR on chrome-platform/for-next]
[also build test ERROR on chrome-platform/for-firmware-next linus/master v6.11-rc7 next-20240913] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]url: https://github.com/intel-lab-lkp/linux/commits/Javier-Martinez-Canillas/firmware-coreboot-Don-t-register-a-pdev-if-screen_info-data-is-present/20240914-053323 base: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next patch link: https://lore.kernel.org/r/20240913213246.1549213-1-javierm%40redhat.com patch subject: [PATCH v3] firmware: coreboot: Don't register a pdev if screen_info data is present config: riscv-randconfig-001-20240915 (https://download.01.org/0day-ci/archive/20240915/[email protected]/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240915/[email protected]/reproduce)If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/Quoted 8 lines
Quoted 7 lines
All errors (new ones prefixed by >>):
Quoted 1 line
Quoted 1 line
ld.lld: error: undefined symbol:
screen_info>>> referenced by framebuffer-coreboot.c:27 (
drivers/firmware/google/framebuffer-coreboot.c:27)
>>> drivers/firmware/google/framebuffer-coreboot.o:(framebuffer_probe) in archive vmlinux.a
>>> referenced by framebuffer-coreboot.c:27 (drivers/firmware/google/framebuffer-coreboot.c:27)
>>> drivers/firmware/google/framebuffer-coreboot.o:(framebuffer_probe) in archive vmlinux.aNot all platforms define
screen_info. Maybe fix this by followingYes, after reading the build errors reported by the robot I remembered that we had similar issues with sysfb, for example commit
1260b9a7020("drivers/firmware: fix SYSFB depends to prevent build failures") fixed one of those.Quoted 4 lines
Tzung-Bi's advice of removing the local variables and then guard the test by
CONFIG_SYSFB. If SYSFB has been defined,screen_infohas to be there. It's not a super pretty solution, though.If possible I would prefer to avoid the ifdefery in the driver. I also believe that the local variables makes the code easier to read. But if you folks think that's better to drop them, I can do it in the next rev.
Quoted 5 lines
Another option is to restrict the architectures where this driver could be build. As far as I understand it is mainly for x86 and ARM64 arches.
These two have a
screen_infodefined so the driver will build correctly. I can include a preparatory patch that adds a "depends on x86 || ARM64".
That feels arbitrary, as the dependency is not really in coreboot, but in sysbf. What you'd want is a HAVE_SCREEN_INFO define on the architectures that provide it. IIRC earlier attempts to add this have failed. :/
If you don't want the ifdef-ery in coreboot.c, you could add a helper to sysfb. Let's say
bool sysfb_handles_screen_info(void)
returns the result of the test. If you put it next to sysfb_disable(), you could add an empty wrapper into the sysfb.h header as well. [1]
(There's still the possibility that screen_info is available, but sysfb has been disabled. But that's not different from how it currently works.)
[1] https://elixir.bootlin.com/linux/v6.10.10/source/include/linux/sysfb.h#L65
Best regards
Thomas
Quoted 4 lines
Quoted 4 lines
Best regards
Thomas
Signature · 7 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
Thomas Zimmermann <[email protected]> writes:
Hello Thomas,
Quoted 68 lines
Hi Javier
Am 16.09.24 um 10:36 schrieb Javier Martinez Canillas:
Quoted 51 lines
Thomas Zimmermann <[email protected]> writes:
Hello Thomas and Tzung-Bi,
Quoted 26 lines
Hi
Am 15.09.24 um 09:44 schrieb kernel test robot:
Quoted 23 lines
Hi Javier,
kernel test robot noticed the following build errors:
[auto build test ERROR on chrome-platform/for-next]
[also build test ERROR on chrome-platform/for-firmware-next linus/master v6.11-rc7 next-20240913] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]url: https://github.com/intel-lab-lkp/linux/commits/Javier-Martinez-Canillas/firmware-coreboot-Don-t-register-a-pdev-if-screen_info-data-is-present/20240914-053323 base: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next patch link: https://lore.kernel.org/r/20240913213246.1549213-1-javierm%40redhat.com patch subject: [PATCH v3] firmware: coreboot: Don't register a pdev if screen_info data is present config: riscv-randconfig-001-20240915 (https://download.01.org/0day-ci/archive/20240915/[email protected]/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240915/[email protected]/reproduce)If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/Quoted 8 lines
Quoted 7 lines
All errors (new ones prefixed by >>):
Quoted 1 line
Quoted 1 line
ld.lld: error: undefined symbol:
screen_info>>> referenced by framebuffer-coreboot.c:27 (
drivers/firmware/google/framebuffer-coreboot.c:27)
>>> drivers/firmware/google/framebuffer-coreboot.o:(framebuffer_probe) in archive vmlinux.a
>>> referenced by framebuffer-coreboot.c:27 (drivers/firmware/google/framebuffer-coreboot.c:27)
>>> drivers/firmware/google/framebuffer-coreboot.o:(framebuffer_probe) in archive vmlinux.aNot all platforms define
screen_info. Maybe fix this by followingYes, after reading the build errors reported by the robot I remembered that we had similar issues with sysfb, for example commit
1260b9a7020("drivers/firmware: fix SYSFB depends to prevent build failures") fixed one of those.Quoted 4 lines
Tzung-Bi's advice of removing the local variables and then guard the test by
CONFIG_SYSFB. If SYSFB has been defined,screen_infohas to be there. It's not a super pretty solution, though.If possible I would prefer to avoid the ifdefery in the driver. I also believe that the local variables makes the code easier to read. But if you folks think that's better to drop them, I can do it in the next rev.
Quoted 5 lines
Another option is to restrict the architectures where this driver could be build. As far as I understand it is mainly for x86 and ARM64 arches.
These two have a
screen_infodefined so the driver will build correctly. I can include a preparatory patch that adds a "depends on x86 || ARM64".That feels arbitrary, as the dependency is not really in coreboot, but in sysbf. What you'd want is a
HAVE_SCREEN_INFOdefine on the architectures that provide it. IIRC earlier attempts to add this have failed. :/If you don't want the ifdef-ery in
coreboot.c, you could add a helper to sysfb. Let's say
Quoted 8 lines
bool
sysfb_handles_screen_info(void)returns the result of the test. If you put it next to
sysfb_disable(), you could add an empty wrapper into thesysfb.hheader as well. [1](There's still the possibility that
screen_infois available, but sysfb has been disabled. But that's not different from how it currently works.)
I like that. And when SYSFB is not enabled, sysfb_handles_screen_info() could just be defined as "return false;" which will indicate to drivers that would have to handle the system frambuffer themselves.
I'll try to type the patches later today.
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat
Quoted 18 lines · Javier Martinez Canillas
drivers/firmware/google/framebuffer-coreboot.c +5
-0@@ -27,8 +28,10 @@ static int framebuffer_probe(struct coreboot_device *dev)int i;u32 length;struct lb_framebuffer *fb = &dev->framebuffer; +const struct screen_info *si = &screen_info;struct platform_device *pdev;struct resource res; +unsigned int type;struct simplefb_platform_data pdata = { .width = fb->x_resolution, .height = fb->y_resolution,@@ -36,6 +39,20 @@ static int framebuffer_probe(struct coreboot_device *dev) .format = NULL, }; +/* +* On coreboot systems, the advertised LB_TAG_FRAMEBUFFER entry +* in the coreboot table should only be used if the payload did
drivers/firmware/google/framebuffer-coreboot.c static int framebuffer_probe(struct coreboot_device *dev) · line 54
Quoted 10 lines
drivers/firmware/google/framebuffer-coreboot.c +10
-0+* not pass a framebuffer information to the Linux kernel. +* +* If the global screen_info data has been filled, the Generic +* System Framebuffers (sysfb) will already register a platform +* device and pass that screen_info as platform_data to a driver +* that can scan-out using the system provided framebuffer. +*/ + type =screen_info_video_type (si); +if (type) +return -ENODEV ;
Given that type and si aren't used in otherwhere, the local variables can be dropped.
I haven't had chance to see how to fix the 0-day build errors properly. If you have chance to send the next versions, please drop the local variables.