linux-kbuild: fix: process configs set to "y"
v2 cover linux-kbuild: fix: process configs set to "y"
An assumption made in this script is that the config options do not need to be processed because they will simply be in the new config file. This assumption is incorrect.
Process the config entries set to "y" because those config entries might have dependencies set to "m". If a config entry is set to "m" and is not loaded directly into the machine, the script will currently turn off that config entry; however, if that turned off config entry is a dependency for a "y" option. that means the config entry set to "y" will also be turned off later when the conf executive file is called.
Here is a model of the problem (arrows show dependency):
Original config fileConfig_1 (m) <-- Config_2 (y)
Config_1 is not loaded in this example, so it is turned off. After scripts/kconfig/streamline_config.pl, but before scripts/kconfig/conf Config_1 (n) <-- Config_2 (y)
After scripts/kconfig/confConfig_1 (n) <-- Config_2 (n)
It should also be noted that any module in the dependency chain will also be turned off, even if that module is loaded directly onto the computer. Here is an example:
Original config fileConfig_1 (m) <-- Config_2 (y) <-- Config_3 (m)
Config_3 will be loaded in this example.
After scripts/kconfig/streamline_config.pl, but before scripts/kconfig/conf Config_1 (n) <-- Config_2 (y) <-- Config_3 (m)
After scripts/kconfig/confConfig_1 (n) <-- Config_2 (n) <-- Config_3 (n)
I discovered this problem when I ran "make localmodconfig" on a generic Ubuntu config file. Many hardware devices were not recognized once the kernel was installed and booted. Another way to reproduced the error I had is to run "make localmodconfig" twice. The standard error might display warnings that certain modules should be selected but no config files are turned on that select that module.
With the changes in this series patch, all modules are loaded properly and all of the hardware is loaded when the kernel is installed and booted.
David Hunter (7):
linux-kbuild: fix: config option can be bool
linux-kbuild: fix: missing variable operator
linux-kbuild: fix: ensure all defaults are tracked
linux-kbuild: fix: ensure selected configs were turned on in original
linux-kbuild: fix: implement choice for kconfigs
linux-kbuild: fix: configs with defaults do not need a prompt
linux-kbuild: fix: process config options set to "y"
---
V2:
- Put in subject.
V1:
- https://lore.kernel.org/all/[email protected]/
---
scripts/kconfig/streamline_config.pl | 77 ++++++++++++++++++++++++---- 1 file changed, 66 insertions(+), 11 deletions(-)
(+CC: Steven Rostedt, the author of this script)
Quoted 67 lines · David Hunter
An assumption made in this script is that the config options do not need to be processed because they will simply be in the new config file. This assumption is incorrect.
Process the config entries set to "y" because those config entries might have dependencies set to "m". If a config entry is set to "m" and is not loaded directly into the machine, the script will currently turn off that config entry; however, if that turned off config entry is a dependency for a "y" option. that means the config entry set to "y" will also be turned off later when the conf executive file is called.
Here is a model of the problem (arrows show dependency):
Original config file
Config_1(m) <--Config_2(y)
Config_1is not loaded in this example, so it is turned off. Afterscripts/kconfig/streamline_config.pl, but beforescripts/kconfig/confConfig_1(n) <--Config_2(y)After
scripts/kconfig/confConfig_1(n) <--Config_2(n)It should also be noted that any module in the dependency chain will also be turned off, even if that module is loaded directly onto the computer. Here is an example:
Original config file
Config_1(m) <--Config_2(y) <--Config_3(m)
Config_3will be loaded in this example.
Afterscripts/kconfig/streamline_config.pl, but beforescripts/kconfig/confConfig_1(n) <--Config_2(y) <--Config_3(m)After
scripts/kconfig/confConfig_1(n) <--Config_2(n) <--Config_3(n)I discovered this problem when I ran "make localmodconfig" on a generic Ubuntu config file. Many hardware devices were not recognized once the kernel was installed and booted. Another way to reproduced the error I had is to run "make localmodconfig" twice. The standard error might display warnings that certain modules should be selected but no config files are turned on that select that module.
With the changes in this series patch, all modules are loaded properly and all of the hardware is loaded when the kernel is installed and booted.
David Hunter (7):
linux-kbuild: fix: config option can be bool
linux-kbuild: fix: missing variable operator
linux-kbuild: fix: ensure all defaults are tracked
linux-kbuild: fix: ensure selected configs were turned on in original
linux-kbuild: fix: implement choice for kconfigs
linux-kbuild: fix: configs with defaults do not need a prompt
linux-kbuild: fix: process config options set to "y"---
V2:
- Put in subject.
V1:
- https://lore.kernel.org/all/[email protected]/
Quoted 7 lines
--- scripts/kconfig/streamline_config.pl | 77 ++++++++++++++++++++++++---- 1 file changed, 66 insertions(+), 11 deletions(-)
--
Best Regards
Masahiro Yamada
Quoted 2 lines · On Tue, 17 Sep 2024 23:45:36 +0900 Masahiro Yamada <[email protected]> wrote:
(+CC: Steven Rostedt, the author of this script)
Since my Out of Office message only goes to people who email me, and this was basically just adding me to someone else's email, I'll reply here to say I'm currently helping to running Linux Plumbers, and next week I'll be at Kernel Recipes. My inbox will be very full when I get back home and will likely not see this email again for a month or two.
If you want me to take a look, please ping me again sometime after September 30th.
-- Steve