Skip to contentSkip to conversation

bap: Set bap debug func at broadcast probe

PATCH Applied Iulia Tanasescu 3 participants 4 messages Sep 19, 2024 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

cover bap: Set bap debug func at broadcast probe

When a Broadcast Sink acting as a Scan Delegator probes a Broadcaster with the help of a Broadcast Assistant, a new BAP session is added for the Broadcaster device before additional session information is initialized (like the bt_bap session). This causes the bap debug func to not be set in bap_data_add.

This patch adds an explicit call to set the function after the bt_bap session is created.

Iulia Tanasescu (1):
bap: Set bap debug func at broadcast probe

 profiles/audio/bap.c | 3 +++
 1 file changed, 3 insertions(+)

base-commit: 7aa245979db6ee74b665154f5c1f203a277eb64a

Signature · 1 line
2.39.2
#1 lore raw

PATCH 1/1 bap: Set bap debug func at broadcast probe

When a Broadcast Sink acting as a Scan Delegator probes a Broadcaster with the help of a Broadcast Assistant, a new BAP session is added for the Broadcaster device before additional session information is initialized (like the bt_bap session). This causes the bap debug func to not be set in bap_data_add.

This commit adds an explicit call to set the function after the bt_bap session is created.

---
 profiles/audio/bap.c | 3 +++
 1 file changed, 3 insertions(+)
profiles/audio/bap.c +3 -0
index 100acca57..c45717ef2 100644
@@ -3243,6 +3243,9 @@ static int bap_bcast_probe(struct btd_service *service)
 		free(data);
 		return -EINVAL;
 	}
+
+	bt_bap_set_debug(data->bap, bap_debug, NULL, NULL);
+
 	data->bcast_snks = queue_new();
 
 	if (!bt_bap_attach(data->bap, NULL)) {
Signature · 1 line
2.39.2
#2 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=891354

---Test result---

Test Summary:

CheckPatch                    PASS      0.48 seconds
GitLint                       PASS      0.34 seconds
BuildEll                      PASS      24.11 seconds
BluezMake                     PASS      1659.41 seconds
MakeCheck                     PASS      13.50 seconds
MakeDistcheck                 PASS      181.74 seconds
CheckValgrind                 PASS      255.39 seconds
CheckSmatch                   PASS      358.33 seconds
bluezmakeextell               PASS      119.25 seconds
IncrementalBuild              PASS      1478.98 seconds
ScanBuild                     PASS      1078.56 seconds

---
Regards,
Linux Bluetooth

#3 lore raw
In reply to Iulia Tanasescu
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 10 lines · On Thu, 19 Sep 2024 11:20:45 +0300 you wrote:

When a Broadcast Sink acting as a Scan Delegator probes a Broadcaster with the help of a Broadcast Assistant, a new BAP session is added for the Broadcaster device before additional session information is initialized (like the bt_bap session). This causes the bap debug func to not be set in bap_data_add.

This patch adds an explicit call to set the function after the bt_bap session is created.

[...]

Here is the summary with links:
- [BlueZ,1/1] bap: Set bap debug func at broadcast probe

    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=ce6462eba2db

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html