Skip to contentSkip to conversation

manager: fix UseDefaultInterface warning

PATCH Applied James Prestwood 2 participants 2 messages Sep 20, 2024 – Sep 25, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 manager: fix UseDefaultInterface warning

This logic was incorrect here, we only want to print if the option is used, not if its unset.

---
 src/manager.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
src/manager.c +3 -3
index 5bedfcc5..436daa56 100644
@@ -894,11 +894,11 @@ static int manager_init(void)
 	}
 
 	if (!l_settings_get_bool(config, "General",
-				"UseDefaultInterface", &use_default)) {
+				"UseDefaultInterface", &use_default))
+		use_default = false;
+	else
 		l_warn("[General].UseDefaultInterface is deprecated, please "
 			"use [DriverQuirks].DefaultInterface instead");
-		use_default = false;
-	}
 
 	return 0;
 
Signature · 1 line
2.34.1
#1 lore raw

Hi James,

Quoted 6 lines · James Prestwood

This logic was incorrect here, we only want to print if the option is used, not if its unset.

---
  src/manager.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.

Regards,
-Denis