Skip to contentSkip to conversation

io_uring: fix memory leak when cache init fail

PATCH Applied Guixin Liu 3 participants 3 messages Sep 23, 2024 – Sep 24, 2024 io_uring

lore
Share & tools
lore

Guixin Liu

author
#0 lore raw

PATCH 1/1 io_uring: fix memory leak when cache init fail

We should exit the percpu ref when cache init fail to free the data memory with in struct percpu_ref.

Fixes 206aefde4f88 ("io_uring: reduce/pack size of io_ring_ctx")
---
 io_uring/io_uring.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
io_uring/io_uring.c +4 -1
index 154b25b8a613..a1cda4139c9f 100644
@@ -316,7 +316,7 @@ static __cold struct io_ring_ctx *io_ring_ctx_alloc(struct io_uring_params *p)
 			    sizeof(struct uring_cache));
 	ret |= io_futex_cache_init(ctx);
 	if (ret)
-		goto err;
+		goto free_ref;
 	init_completion(&ctx->ref_comp);
 	xa_init_flags(&ctx->personalities, XA_FLAGS_ALLOC1);
 	mutex_init(&ctx->uring_lock);
@@ -344,6 +344,9 @@ static __cold struct io_ring_ctx *io_ring_ctx_alloc(struct io_uring_params *p)
 	io_napi_init(ctx);
 
 	return ctx;
+
+free_ref:
+	percpu_ref_exit(&ctx->refs);
 err:
 	io_alloc_cache_free(&ctx->rsrc_node_cache, kfree);
 	io_alloc_cache_free(&ctx->apoll_cache, kfree);
Signature · 1 line
2.43.0
maintainer Applied
#2 lore raw
In reply to Guixin Liu
Quoted 4 lines · Guixin Liu

We should exit the percpu ref when cache init fail to free the data memory with in struct percpu_ref.

Applied, thanks!

[1/1] io_uring: fix memory leak when cache init fail

      commit: 638e6c7dc0d957018e466e6247fea2932c6cfb85

Best regards,

Signature · 1 line
Jens Axboe