Skip to contentSkip to conversation

xhci: Don't use "proxy" headers

PATCH In review Andy Shevchenko 1 participant 2 messages Sep 23, 2024 – Nov 7, 2024

Subsystems (2)
USB USB xHCI driver
lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH 1/1 xhci: Don't use "proxy" headers

Update header inclusions to follow IWYU (Include What You Use) principle.

Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/usb/host/xhci.h       | 22 +++++++++++++++++++---
 include/linux/usb/xhci-dbgp.h |  3 +++
 2 files changed, 22 insertions(+), 3 deletions(-)
drivers/usb/host/xhci.h +19 -3
index 620502de971a..b617de4d4c76 100644
@@ -12,15 +12,31 @@
 #ifndef __LINUX_XHCI_HCD_H
 #define __LINUX_XHCI_HCD_H
 
+#include <linux/bitops.h>
+#include <linux/completion.h>
+#include <linux/dev_printk.h>
+#include <linux/irqreturn.h>
+#include <linux/mutex.h>
+#include <linux/pm.h>
+#include <linux/spinlock.h>
+#include <linux/sprintf.h>
+#include <linux/timer_types.h>
+#include <linux/types.h>
 #include <linux/usb.h>
-#include <linux/timer.h>
-#include <linux/kernel.h>
 #include <linux/usb/hcd.h>
+#include <linux/workqueue.h>
+
 #include <linux/io-64-nonatomic-lo-hi.h>
 #include <linux/io-64-nonatomic-hi-lo.h>
 
+struct clk;
+struct dentry;
+struct dma_pool;
+struct radix_tree_root;
+struct reset_control;
+
 /* Code sharing between pci-quirks and xhci hcd */
-#include	"xhci-ext-caps.h"
+#include "xhci-ext-caps.h"
 #include "pci-quirks.h"
 
 #include "xhci-port.h"
include/linux/usb/xhci-dbgp.h +3 -0
index 171fd74b1cfc..880d1421df4b 100644
@@ -10,6 +10,9 @@
 #ifndef __LINUX_XHCI_DBGP_H
 #define __LINUX_XHCI_DBGP_H
 
+#include <linux/errno.h>
+#include <linux/init.h>
+
 #ifdef CONFIG_EARLY_PRINTK_USB_XDBC
 int __init early_xdbc_parse_parameter(char *s, int keep_early);
 int __init early_xdbc_setup_hardware(void);
Signature · 1 line
2.43.0.rc1.1336.g36b5255a03ac
author
#1 lore raw
Quoted 2 lines · Andy Shevchenko

Update header inclusions to follow IWYU (Include What You Use) principle.

Mathias, any comments on this change?

Signature · 2 lines
With Best Regards,
Andy Shevchenko