tirpc_clnt_destroy: Determine the return value of clnt_create()
PATCH 1/1 tirpc_clnt_destroy: Determine the return value of clnt_create()
Determine the return value of clnt_create() to avoid segmentation fault when executing clnt_destroy() when the return value of create is NULL.
--- .../tirpc/tirpc_toplevel_clnt_destroy/tirpc_clnt_destroy.c | 7 +++++++ 1 file changed, 7 insertions(+)
testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_toplevel_clnt_destroy/tirpc_clnt_destroy.c +7 -0
@@ -58,6 +58,13 @@ int main(int argn, char *argc[])//first create client clnt =clnt_create (argc[1 ], progNum,VERSNUM , nettype); +if (clnt ==NULL ) { +clnt_pcreateerror ("err" ); +printf ("%d\n" , rpc_createerr.cf_stat); + +return 1 ; + } +//then call destroy macro clnt_destroy (clnt);
Signature · 5 lines
2.42.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 29 lines · Ma Xinjian
Determine the return value of
clnt_create()to avoid segmentation fault when executingclnt_destroy()when the return value of create is NULL.Signed-off-by Ma Xinjian <[email protected]>--- .../tirpc/tirpc_toplevel_clnt_destroy/tirpc_clnt_destroy.c | 7 +++++++ 1 file changed, 7 insertions(+)testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_toplevel_clnt_destroy/tirpc_clnt_destroy.c +7
-0@@ -58,6 +58,13 @@ int main(int argn, char *argc[])//first create client clnt =clnt_create (argc[1 ], progNum,VERSNUM , nettype); +if (clnt ==NULL ) { +clnt_pcreateerror ("err" ); +printf ("%d\n" , rpc_createerr.cf_stat); + +return 1 ; + } +//then call destroy macro clnt_destroy (clnt);Signature · 1 line
2.42.0
That's the basic idea. And then apply the same fix to other tests that call the clnt_create(3) APIs.
Signature · 4 lines
Chuck Lever -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi all,
Quoted 3 lines · Ma Xinjian
Quoted 2 lines
Determine the return value of
clnt_create()to avoid segmentation fault when executingclnt_destroy()when the return value of create is NULL.
...
Quoted 2 lines
That's the basic idea. And then apply the same fix to other tests that call the
clnt_create(3)APIs.
Thanks a lot for fix and review, very much appreciated.
@Ma Xinjian or @Chen Hanxiao, could you please add this cleanup to all tests which use clnt_create() as Chuck suggested?
Kind regards,
Petr
Quoted 1 line
Reviewed-by Chuck Lever <[email protected]>
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 34 lines
-----邮件原件-----
发件人: Ma Xinjian <[email protected]>
发送时间: 2024年9月26日 12:14
收件人: [email protected]; [email protected]; Chen, Hanxiao <[email protected]>
抄送: Ma, Xinjian <[email protected]>
主题: [PATCH]tirpc_clnt_destroy: Determine the return value ofclnt_create()Determine the return value of
clnt_create()to avoid segmentation fault when executingclnt_destroy()when the return value of create is NULL.Signed-off-by Ma Xinjian <[email protected]>--- .../tirpc/tirpc_toplevel_clnt_destroy/tirpc_clnt_destroy.c | 7 +++++++ 1 file changed, 7 insertions(+)diff --git a/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_toplevel_cl
nt_destroy/tirpc_clnt_destroy.cb/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_toplevel_clnt_destroy/tirpc_clnt_destroy.c
index939ff3e4a..bb9a47503100644
---
a/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_toplevel_clnt_destroy/tirpc_clnt_destroy.c
+++
b/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_toplevel_clnt_destroy/tirpc_clnt_destroy.ctestcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_toplevel_clnt_destroy/tirpc_clnt_destroy.c +0
-0@@ -58,6 +58,13 @@ int main(int argn, char *argc[])//first create client clnt =clnt_create (argc[1 ], progNum,VERSNUM , nettype);
testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_toplevel_clnt_destroy/tirpc_clnt_destroy.c int main(int argn, char *argc[]) · line 70
Quoted 10 lines
testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_toplevel_clnt_destroy/tirpc_clnt_destroy.c +7
-0+if (clnt ==NULL ) { +clnt_pcreateerror ("err" ); +printf ("%d\n" , rpc_createerr.cf_stat); + +return 1 ; + } +//then call destroy macro clnt_destroy (clnt);
With the patch above, no segfault found
And logs look better:
rpc_test 1 TINFO: 192.168.122.147/24 -- 192.168.122.148/24 rpc_test 1 TINFO: fd00::1/64 -- fd00::2/64 rpc_test 1 TINFO: timeout per run is 0h 10m 0s rpc_test 1 TINFO: check registered RPC with rpcinfo rpc_test 1 TINFO: registered RPC:
program vers proto port service
100000 4 tcp 111 portmapper
100000 3 tcp 111 portmapper
100000 2 tcp 111 portmapper
100000 4 udp 111 portmapper
100000 3 udp 111 portmapper
100000 2 udp 111 portmapperrpc_test 1 TINFO: using libtirpc: yesrpc_test 1 TFAIL: tirpc_clnt_destroy 192.168.122.147 536875000 failed unexpectedly 12
err: RPC: Remote system error - No route to host
Regards,
- Chen
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp