RDMA/cxgb4: fix kernel panic for RDMA loopback test over VLAN
Subsystems (2)
PATCH 1/1 RDMA/cxgb4: fix kernel panic for RDMA loopback test over VLAN
ip_dev_find() always returns real net_device address, whether traffic is running on a vlan or real device, if traffic is over vlan, further derefencing real net_device address leads to kernel panic. This patch fixes the issue by using vlan_dev_real_dev().
--- drivers/infiniband/hw/cxgb4/cm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/infiniband/hw/cxgb4/cm.c +3 -3
@@ -2086,7 +2086,7 @@ static int import_ep(struct c4iw_ep *ep, int iptype, __u8 *peer_ip, err = -ENOMEM ;if (n->dev->flags &IFF_LOOPBACK ) {if (iptype ==4 ) - pdev =ip_dev_find (&init_net, *(__be32 *)peer_ip); + pdev =__ip_dev_find (&init_net, *(__be32 *)peer_ip, false);else if (IS_ENABLED (CONFIG_IPV6 ))for_each_netdev (&init_net, pdev) { if (ipv6_chk_addr(&init_net,
@@ -2101,10 +2101,11 @@ static int import_ep(struct c4iw_ep *ep, int iptype, __u8 *peer_ip, err = -ENODEV ; goto out; } +if (is_vlan_dev (pdev)) + pdev =vlan_dev_real_dev (pdev); ep->l2t =cxgb4_l2t_get (cdev->rdev.lldi.l2t, n, pdev,rt_tos2priority (tos));if (!ep->l2t) { -dev_put (pdev); goto out; } ep->mtu = pdev->mtu;
@@ -2119,7 +2120,6 @@ static int import_ep(struct c4iw_ep *ep, int iptype, __u8 *peer_ip, ep->rss_qid = cdev->rdev.lldi.rxq_ids[cxgb4_port_idx (pdev) * step];set_tcp_window (ep, (struct port_info *)netdev_priv (pdev)); -dev_put (pdev); }else { pdev =get_real_dev (n->dev); ep->l2t = cxgb4_l2t_get(cdev->rdev.lldi.l2t,
Signature · 1 line
2.39.3
Quoted 4 lines · Anumula Murali Mohan Reddy
ip_dev_find()always returns realnet_deviceaddress, whether traffic is running on a vlan or real device, if traffic is over vlan, further derefencing realnet_deviceaddress leads to kernel panic. This patch fixes the issue by usingvlan_dev_real_dev().
Please add kernel panic message and Fixes tag to the commit message.
Thanks
Quoted 6 lines
Signed-off-by Anumula Murali Mohan Reddy <[email protected]>Signed-off-by Potnuri Bharat Teja <[email protected]>--- drivers/infiniband/hw/cxgb4/cm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Hi Leon Romanovsky,
My apologies, I hurriedly mistyped. Issue is not panic but a connection error . Please ignore this patch. I will send a new patch with right subject line.
Thanks & Regards,
Murali
-----Original Message-----
From: Leon Romanovsky <[email protected]>
Sent: 26 September 2024 11:35
To: Anumula Murali Mohan Reddy <[email protected]>
Cc: [email protected]; [email protected]; Potnuri Bharat Teja <[email protected]>
Subject: Re: [PATCH for-next] RDMA/cxgb4: fix kernel panic for RDMA loopback test over VLAN
Quoted 4 lines · Anumula Murali Mohan Reddy
ip_dev_find()always returns realnet_deviceaddress, whether traffic is running on a vlan or real device, if traffic is over vlan, further derefencing realnet_deviceaddress leads to kernel panic. This patch fixes the issue by usingvlan_dev_real_dev().
Please add kernel panic message and Fixes tag to the commit message.
Thanks
Quoted 6 lines
Signed-off-by Anumula Murali Mohan Reddy <[email protected]>Signed-off-by Potnuri Bharat Teja <[email protected]>--- drivers/infiniband/hw/cxgb4/cm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)