Skip to contentSkip to conversation

perf test: Use ARRAY_SIZE for array length

PATCH Superseded Jiapeng Chong 2 participants 2 messages Sep 27, 2024 – Sep 29, 2024 perf events

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf test: Use ARRAY_SIZE for array length

Use of macro ARRAY_SIZE to calculate array size minimizes the redundant code and improves code reusability.

./tools/perf/tests/demangle-java-test.c:31:34-35: WARNING: Use ARRAY_SIZE.

---
 tools/perf/tests/demangle-java-test.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/perf/tests/demangle-java-test.c +2 -1
index 44d1be303b67..611c18cdf4d3 100644
@@ -6,6 +6,7 @@
 #include "session.h"
 #include "debug.h"
 #include "demangle-java.h"
+#include "kselftest.h"
 
 static int test__demangle_java(struct test_suite *test __maybe_unused, int subtest __maybe_unused)
 {
@@ -28,7 +29,7 @@ static int test__demangle_java(struct test_suite *test __maybe_unused, int subte
 		  "void java.lang.Object<init>()" },
 	};
 
-	for (i = 0; i < sizeof(test_cases) / sizeof(test_cases[0]); i++) {
+	for (i = 0; i < ARRAY_SIZE(test_cases); i++) {
 		buf = java_demangle_sym(test_cases[i].mangled, 0);
 		if (strcmp(buf, test_cases[i].demangled)) {
 			pr_debug("FAILED: %s: %s != %s\n", test_cases[i].mangled,
Signature · 1 line
2.32.0.3.g01195cf9f
#1 lore raw

Hello,

Quoted 17 lines · Jiapeng Chong

Use of macro ARRAY_SIZE to calculate array size minimizes the redundant code and improves code reusability.

./tools/perf/tests/demangle-java-test.c:31:34-35: WARNING: Use ARRAY_SIZE.

---
  tools/perf/tests/demangle-java-test.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
tools/perf/tests/demangle-java-test.c +0 -0
index 44d1be303b67..611c18cdf4d3 100644

tools/perf/tests/demangle-java-test.c line 9

Quoted 4 lines
tools/perf/tests/demangle-java-test.c +1 -0
@@ -6,6 +6,7 @@
  #include "session.h"
  #include "debug.h"
  #include "demangle-java.h"
+#include "kselftest.h"

The wrong header file is included here, causing the build to fail:

CC tests/demangle-java-test.o
tests/demangle-java-test.c:9:10: fatal error: kselftest.h: No such file or directory
9 | #include "kselftest.h"
| ^~~~~~~~~~

The correct header file to include should be: <linux/kernel.h>

Thanks,
Yang

Quoted 12 lines
tools/perf/tests/demangle-java-test.c +1 -1
  static int test__demangle_java(struct test_suite *test __maybe_unused, int subtest __maybe_unused)
  {
@@ -28,7 +29,7 @@ static int test__demangle_java(struct test_suite *test __maybe_unused, int subte
  		  "void java.lang.Object<init>()" },
  	};
 
-	for (i = 0; i < sizeof(test_cases) / sizeof(test_cases[0]); i++) {
+	for (i = 0; i < ARRAY_SIZE(test_cases); i++) {
  		buf = java_demangle_sym(test_cases[i].mangled, 0);
  		if (strcmp(buf, test_cases[i].demangled)) {
  			pr_debug("FAILED: %s: %s != %s\n", test_cases[i].mangled,