Skip to contentSkip to conversation

media: i2c: Add AR0233 camera sensor driver

RFC PATCH New Alexander Shiyan 2 participants 2 messages Sep 27, 2024 – Sep 29, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 media: i2c: Add AR0233 camera sensor driver

This is a new driver for the AR0233 ON Semiconductor camera sensor. The patch does not provide devicetree bindings yet and is published as RFC.

Tested on Rockchip RK3568 with DS90UB953 serializer and DS90UB954 deserializer.

---
 drivers/media/i2c/Kconfig  |   11 +
 drivers/media/i2c/Makefile |    1 +
 drivers/media/i2c/ar0233.c | 1179 ++++++++++++++++++++++++++++++++++++
 3 files changed, 1191 insertions(+)
 create mode 100644 drivers/media/i2c/ar0233.c
drivers/media/i2c/Kconfig +11 -0
index 8ba096b8ebca..327e68b5fe0b 100644
@@ -51,6 +51,17 @@ config VIDEO_ALVIUM_CSI2
 	  To compile this driver as a module, choose M here: the
 	  module will be called alvium-csi2.
 
+config VIDEO_AR0233
+	tristate "onsemi AR0233 sensor support"
+	depends on OF || COMPILE_TEST
+	select V4L2_CCI_I2C
+	help
+	  This is a Video4Linux2 sensor driver for the onsemi AR0233 camera
+	  sensor.
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called ar0233.
+
 config VIDEO_AR0521
 	tristate "ON Semiconductor AR0521 sensor support"
 	help
drivers/media/i2c/Makefile +1 -0
index fbb988bd067a..055123335a28 100644
@@ -19,6 +19,7 @@ obj-$(CONFIG_VIDEO_AK7375) += ak7375.o
 obj-$(CONFIG_VIDEO_AK881X) += ak881x.o
 obj-$(CONFIG_VIDEO_ALVIUM_CSI2) += alvium-csi2.o
 obj-$(CONFIG_VIDEO_APTINA_PLL) += aptina-pll.o
+obj-$(CONFIG_VIDEO_AR0233) += ar0233.o
 obj-$(CONFIG_VIDEO_AR0521) += ar0521.o
 obj-$(CONFIG_VIDEO_BT819) += bt819.o
 obj-$(CONFIG_VIDEO_BT856) += bt856.o
drivers/media/i2c/ar0233.c new file +1179 -0

1,179 lines not on this page · raw message

Signature · 1 line
2.38.2
#1 lore raw
kernel test robot noticed the following build warnings:

Hi Alexander,

[This is a private test report for your RFC patch.] kernel test robot noticed the following build warnings:

[auto build test WARNING on media-tree/master]
[also build test WARNING on linuxtv-media-stage/master sailus-media-tree/master linus/master v6.11 next-20240927] [cannot apply to sailus-media-tree/streams]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Alexander-Shiyan/media-i2c-Add-AR0233-camera-sensor-driver/20240927-213931
base:   git://linuxtv.org/media_tree.git master
patch link:    https://lore.kernel.org/r/20240927133654.2389990-1-eagle.alexander923%40gmail.com
patch subject: [RFC PATCH] media: i2c: Add AR0233 camera sensor driver
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20240930/[email protected]/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240930/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

drivers/media/i2c/ar0233.c: In function 'ar0233_s_ctrl':

>> drivers/media/i2c/ar0233.c:429:42: warning: variable 'info' set but not used [-Wunused-but-set-variable]
     429 |         const struct ar0233_format_info *info;
         |                                          ^~~~

vim +/info +429 drivers/media/i2c/ar0233.c

423
424 static int ar0233_s_ctrl(struct v4l2_ctrl *ctrl)
425 {
426 struct ar0233 *sensor = container_of(ctrl->handler, struct ar0233, ctrls);
427 const struct v4l2_subdev_state *state;
428 const struct v4l2_mbus_framefmt *format;

 > 429		const struct ar0233_format_info *info;
   430		const struct v4l2_rect *crop;
   431		int ret = 0;
   432		u16 reg;
   433	
   434		/*
   435		 * Return immediately for controls that don't need to be applied to the
   436		 * device.
   437		 */
   438		if (ctrl->flags & (V4L2_CTRL_FLAG_READ_ONLY | V4L2_CTRL_FLAG_GRABBED))
   439			return 0;
   440	
   441		state = v4l2_subdev_get_locked_active_state(&sensor->sd);
   442		format = v4l2_subdev_state_get_format(state, 0);
   443		info = ar0233_format_info(sensor, format->code, true);
   444		crop = v4l2_subdev_state_get_crop(state, 0);
   445	
   446		switch (ctrl->id) {
   447		case V4L2_CID_VBLANK:
   448			ret = ar0233_update_exposure(sensor, crop);
   449			break;
   450		default:
   451			break;
   452		}
   453	
   454		if (ret)
   455			return ret;
   456	
   457		if (!pm_runtime_get_if_in_use(sensor->dev))
   458			return 0;
   459	
   460		switch (ctrl->id) {
   461		case V4L2_CID_ANALOGUE_GAIN:
   462			reg = ctrl->val << 12;
   463			reg |= ctrl->val << 8;
   464			reg |= ctrl->val << 4;
   465			reg |= ctrl->val << 0;

466 cci_write(sensor->cci, AR0233_ANALOG_GAIN, reg, &ret);
467 break;
468 case V4L2_CID_DIGITAL_GAIN:
469 cci_write(sensor->cci, AR0233_GLOBAL_GAIN, ctrl->val, &ret);
470 break;
471 case V4L2_CID_EXPOSURE:
472 cci_write(sensor->cci, AR0233_COARSE_INTEGRATION_TIME,
473 ctrl->val, &ret);
474 break;
475 case V4L2_CID_HBLANK:
476 cci_write(sensor->cci, AR0233_LINE_LENGTH_PCK,
477 crop->width + ctrl->val, &ret);
478 break;
479 case V4L2_CID_VBLANK:
480 cci_write(sensor->cci, AR0233_FRAME_LENGTH_LINES,
481 crop->height + ctrl->val, &ret);
482 break;
483 case V4L2_CID_TEST_PATTERN:
484 cci_write(sensor->cci, AR0233_TEST_PATTERN_MODE,
485 ar0233_test_pattern_values[ctrl->val], &ret);
486 break;
487 case V4L2_CID_TEST_PATTERN_RED:
488 case V4L2_CID_TEST_PATTERN_GREENR:
489 case V4L2_CID_TEST_PATTERN_BLUE:
490 case V4L2_CID_TEST_PATTERN_GREENB:
491 cci_write(sensor->cci, AR0233_GROUPED_PARAMETER_HOLD,
492 AR0233_RESET_REGISTER_GROUPED_PARAMETER_HOLD, &ret);
493
494 cci_write(sensor->cci, AR0233_TEST_DATA_RED,
495 sensor->test_data[0]->val, &ret);
496 cci_write(sensor->cci, AR0233_TEST_DATA_GREENR,
497 sensor->test_data[1]->val, &ret);
498 cci_write(sensor->cci, AR0233_TEST_DATA_BLUE,
499 sensor->test_data[2]->val, &ret);
500 cci_write(sensor->cci, AR0233_TEST_DATA_GREENB,
501 sensor->test_data[3]->val, &ret);
502
503 cci_write(sensor->cci, AR0233_GROUPED_PARAMETER_HOLD,
504 0, &ret);
505 break;
506 case V4L2_CID_HFLIP:
507 case V4L2_CID_VFLIP:
508 reg = sensor->hflip->val ? AR0233_ORIENTATION_HORIZ_MIRROR : 0;
509 reg |= sensor->vflip->val ? AR0233_ORIENTATION_VERT_FLIP : 0;
510
511 cci_write(sensor->cci, AR0233_IMAGE_ORIENTATION, reg, &ret);
512 break;
513 default:
514 ret = -EINVAL;
515 break;
516 }
517
518 pm_runtime_put(sensor->dev);
519
520 return ret;
521 }
522

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki