Skip to contentSkip to conversation

crypto: qat - remove unused adf_devmgr_get_first

PATCH In review [email protected] 3 participants 3 messages Sep 29, 2024 – Oct 5, 2024

Subsystems (2)
Crypto API QAT driver
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 crypto: qat - remove unused adf_devmgr_get_first

From: "Dr. David Alan Gilbert" <[email protected]>

adf_devmgr_get_first has been unused since commit 4a4b0bad0653 ("crypto: qat - fix crypto_get_instance_node function")

Remove it.

(Build tested only, I don't own the hardware)

Signed-off-by Dr. David Alan Gilbert <[email protected]>
---
 drivers/crypto/intel/qat/qat_common/adf_common_drv.h |  1 -
 drivers/crypto/intel/qat/qat_common/adf_dev_mgr.c    | 10 ----------
 2 files changed, 11 deletions(-)
drivers/crypto/intel/qat/qat_common/adf_common_drv.h +0 -1
index f7ecabdf7805..eaa6388a6678 100644
@@ -69,7 +69,6 @@ void adf_devmgr_rm_dev(struct adf_accel_dev *accel_dev,
 		       struct adf_accel_dev *pf);
 struct list_head *adf_devmgr_get_head(void);
 struct adf_accel_dev *adf_devmgr_get_dev_by_id(u32 id);
-struct adf_accel_dev *adf_devmgr_get_first(void);
 struct adf_accel_dev *adf_devmgr_pci_to_accel_dev(struct pci_dev *pci_dev);
 int adf_devmgr_verify_id(u32 id);
 void adf_devmgr_get_num_dev(u32 *num);
drivers/crypto/intel/qat/qat_common/adf_dev_mgr.c +0 -10
index 96ddd1c419c4..34b9f7731c78 100644
@@ -276,16 +276,6 @@ void adf_devmgr_rm_dev(struct adf_accel_dev *accel_dev,
 }
 EXPORT_SYMBOL_GPL(adf_devmgr_rm_dev);
 
-struct adf_accel_dev *adf_devmgr_get_first(void)
-{
-	struct adf_accel_dev *dev = NULL;
-
-	if (!list_empty(&accel_table))
-		dev = list_first_entry(&accel_table, struct adf_accel_dev,
-				       list);
-	return dev;
-}
-
 /**
  * adf_devmgr_pci_to_accel_dev() - Get accel_dev associated with the pci_dev.
  * @pci_dev:  Pointer to PCI device.
Signature · 1 line
2.46.2
maintainer
#2 lore raw
In reply to [email protected]
Quoted 7 lines · On Sun, Sep 29, 2024 at 02:24:41AM +0100, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

adf_devmgr_get_first has been unused since commit 4a4b0bad0653 ("crypto: qat - fix crypto_get_instance_node function")

Remove it.

Quoted 7 lines

(Build tested only, I don't own the hardware)

Signed-off-by Dr. David Alan Gilbert <[email protected]>
---
 drivers/crypto/intel/qat/qat_common/adf_common_drv.h |  1 -
 drivers/crypto/intel/qat/qat_common/adf_dev_mgr.c    | 10 ----------
 2 files changed, 11 deletions(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt