Skip to contentSkip to conversation

ARM: dts: nuvoton: Add OHCI node

PATCH In review William A. Kennington III 2 participants 2 messages Sep 30, 2024 – Oct 2, 2024 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: nuvoton: Add OHCI node

From: "William A. Kennington III" <[email protected]>

The EHCI peripheral already exists in the devicetree, but the hardware also supports a discrete OHCI unit on the same USB PHY. Generic OHCI works fine for this device already and has been tested on real hardware.

---
 arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi +7 -0
index 358b52894ac0..5aeb5009a5d7 100644
@@ -142,6 +142,13 @@ gmac0: eth@f0802000 {
 			status = "disabled";
 		};
 
+		ohci1: ohci@f0807000 {
+			compatible = "generic-ohci";
+			reg = <0xf0807000 0x1000>;
+			interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disabled";
+		};
+
 		ehci1: usb@f0806000 {
 			compatible = "nuvoton,npcm750-ehci";
 			reg = <0xf0806000 0x1000>;
Signature · 1 line
2.46.1.824.gd892dcdcdd-goog
#1 lore raw

Hi William,

Quoted 16 lines · William A. Kennington III

From: "William A. Kennington III" <[email protected]>

The EHCI peripheral already exists in the devicetree, but the hardware also supports a discrete OHCI unit on the same USB PHY. Generic OHCI works fine for this device already and has been tested on real hardware.

---
 arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi +0 -0
index 358b52894ac0..5aeb5009a5d7 100644

arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi gmac0: eth@f0802000 { · line 145

Quoted 4 lines
arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi +1 -0
@@ -142,6 +142,13 @@ gmac0: eth@f0802000 {
 			status = "disabled";
 		};
 
+		ohci1: ohci@f0807000 {

I got an additional warning here too:

+/home/andrew/src/kernel.org/linux/origin/build.multi_v5/arch/arm/boot/dts/nuvoton/nuvoton-npcm750-evb.dtb: ohci@f0807000: $nodename:0: 'ohci@f0807000' does not match '^usb(@.*)?'
+ from schema $id: http://devicetree.org/schemas/usb/generic-ohci.yaml#

Andrew

Quoted 9 lines
arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi +6 -0
+			compatible = "generic-ohci";
+			reg = <0xf0807000 0x1000>;
+			interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disabled";
+		};
+
 		ehci1: usb@f0806000 {
 			compatible = "nuvoton,npcm750-ehci";
 			reg = <0xf0806000 0x1000>;