Skip to contentSkip to conversation

qa_image: move image_qa to between image and image_complete

PATCH New Louis Rannou 1 participant 1 message Oct 1, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qa_image: move image_qa to between image and image_complete

Commit 62ce334e583ecdf1f93619f4131c0fa5d88d5b02 moved this after image as it was noticed that do_image_qa is useless when rm_work is enabled as the rootfs directory is deleted before image_qa is called.

However, this pactch made impossible the creation of a dependance from image_qa to any image_* task where various types of images are generated. This disabled the possibility to test a specific type of image (eg. a FIT image).

As rm_work is called as a postprocess of image_complete, qa_image can be done after image as long as it is done before image_complete.

---
 meta/classes-recipe/image.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes-recipe/image.bbclass +1 -1
index 00f1d58f23777d40da47d4932140be4779a62ec1..445080c94151e48b23c93530bb7e6e41bb5794c2 100644
@@ -341,7 +341,7 @@ fakeroot python do_image_qa () {
 
     oe.qa.exit_if_errors(d)
 }
-addtask do_image_qa after do_rootfs before do_image
+addtask do_image_qa after do_image before do_image_complete
 
 SSTATETASKS += "do_image_qa"
 SSTATE_SKIP_CREATION:task-image-qa = '1'

---
base-commit: 64c06dd06d747d7b53fb6ae6cf0550e13d63d8f6
change-id: 20240926-qa32-ac1a44323605

Best regards,

Signature · 1 line
Louis Rannou <[email protected]>