Skip to contentSkip to conversation

i3c: master: Fix miss free init_dyn_addr at i3c_master_put_i3c_addrs()

PATCH Applied Frank Li 2 participants 2 messages Oct 1, 2024 – Oct 31, 2024

Subsystems (2)
lore
Share & tools
lore

Frank Li

author maintainer
#0 lore raw

PATCH v5 1/1 i3c: master: Fix miss free init_dyn_addr at i3c_master_put_i3c_addrs()

if (dev->boardinfo && dev->boardinfo->init_dyn_addr)

                                      ^^^ here check "init_dyn_addr"
	i3c_bus_set_addr_slot_status(&master->bus, dev->info.dyn_addr, ...)
						             ^^^^
							free "dyn_addr"

Fix copy/paste error "dyn_addr" by replacing it with "init_dyn_addr".

Fixes 3a379bbcea0a ("i3c: Add core I3C infrastructure")

---
Change from v4 to v5
- none
- just split from big series
https://lore.kernel.org/linux-i3c/[email protected]/
that needs more discussion about dt assign-address.

change from v3 to v4
- mention copy/paste error
- Add Miquel's review tag

---
 drivers/i3c/master.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i3c/master.c +1 -1
index 82f031928e413..402a71313985f 100644
@@ -1417,7 +1417,7 @@ static void i3c_master_put_i3c_addrs(struct i3c_dev_desc *dev)
 					     I3C_ADDR_SLOT_FREE);
 
 	if (dev->boardinfo && dev->boardinfo->init_dyn_addr)
-		i3c_bus_set_addr_slot_status(&master->bus, dev->info.dyn_addr,
+		i3c_bus_set_addr_slot_status(&master->bus, dev->boardinfo->init_dyn_addr,
 					     I3C_ADDR_SLOT_FREE);
 }
 
Signature · 1 line
2.34.1
maintainer Applied
#1 lore raw
Quoted 8 lines · Frank Li

if (dev->boardinfo && dev->boardinfo->init_dyn_addr)

                                      ^^^ here check "init_dyn_addr"
	i3c_bus_set_addr_slot_status(&master->bus, dev->info.dyn_addr, ...)
						             ^^^^
							free "dyn_addr"

Fix copy/paste error "dyn_addr" by replacing it with "init_dyn_addr".

[...]

Applied, thanks!

[1/1] i3c: master: Fix miss free init_dyn_addr at i3c_master_put_i3c_addrs()

      https://git.kernel.org/abelloni/c/3082990592f7

Best regards,

Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com