Skip to contentSkip to conversation

xfs: fix a typo

PATCH Superseded Andrew Kreimer 3 participants 4 messages Oct 2, 2024 – Oct 3, 2024

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs: fix a typo

Fix a typo in comments.

---
 fs/xfs/xfs_log_recover.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_log_recover.c +1 -1
index ec766b4bc853..a13bf53fea49 100644
@@ -1849,7 +1849,7 @@ xlog_find_item_ops(
  *	   from the transaction. However, we can't do that until after we've
  *	   replayed all the other items because they may be dependent on the
  *	   cancelled buffer and replaying the cancelled buffer can remove it
- *	   form the cancelled buffer table. Hence they have tobe done last.
+ *	   form the cancelled buffer table. Hence they have to be done last.
  *
  *	3. Inode allocation buffers must be replayed before inode items that
  *	   read the buffer and replay changes into it. For filesystems using the
Signature · 1 line
2.39.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Andrew Kreimer

Fix a typo in comments.

Looks good,

--D

Quoted 21 lines
---
 fs/xfs/xfs_log_recover.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_log_recover.c +1 -1
index ec766b4bc853..a13bf53fea49 100644
@@ -1849,7 +1849,7 @@ xlog_find_item_ops(
  *	   from the transaction. However, we can't do that until after we've
  *	   replayed all the other items because they may be dependent on the
  *	   cancelled buffer and replaying the cancelled buffer can remove it
- *	   form the cancelled buffer table. Hence they have tobe done last.
+ *	   form the cancelled buffer table. Hence they have to be done last.
  *
  *	3. Inode allocation buffers must be replayed before inode items that
  *	   read the buffer and replay changes into it. For filesystems using the
Signature · 1 line
2.39.5
#2 lore raw
In reply to Andrew Kreimer
Quoted 2 lines · Andrew Kreimer

Fix a typo in comments.

Could you explain what the typos are in the commit message so that we can spot it more easily? It saves a little review time.

regards,
dan carpenter

#3 lore raw
Quoted 6 lines · Dan Carpenter
Quoted 2 lines · Andrew Kreimer

Fix a typo in comments.

Could you explain what the typos are in the commit message so that we can spot it more easily? It saves a little review time.

Noted, thank you.