Recent changes (master)
The following changes since commit 92245726b7f608a7e6e294222e68821b4dcc38ea:
docs: addtions to client/server section (2024-10-02 17:15:40 -0400)
are available in the Git repository at:
git://git.kernel.dk/fio.git master
for you to fetch changes up to cd56c0af6f3e1ec3cad49ab0d0c002f2c7de3f90:
docs: mention unsupported configuration (2024-10-03 20:39:38 +0000)
----------------------------------------------------------------
Vincent Fu (2):
client/server: enable "All clients" latency percentiles
docs: mention unsupported configuration
HOWTO.rst | 11 ++++++++++- client.c | 10 ++++++++++ fio.1 | 10 +++++++++- 3 files changed, 29 insertions(+), 2 deletions(-)
---
Diff of recent changes:
HOWTO.rst +10 -1
@@ -4128,6 +4128,11 @@ Measurements and reporting `job_start`. For these properties, the values for the first job are recorded for the group. + Also, options like :option:`percentile_list` and + :option:`unified_rw_reporting` should be consistent among the jobs in a + reporting group. Having options like these vary across the jobs in a + reporting group is an unsupported configuration. + .. option:: new_group Start a new reporting group. See: :option:`group_reporting`. If not given,
@@ -5391,4 +5396,8 @@ Terse output in client/server mode will differ slightly from what is produced when fio is run in stand-alone mode. See the terse output section for details. Also, if one fio invocation runs workloads on multiple servers, fio will -provide at the end an aggregate summary report for all workloads. +provide at the end an aggregate summary report for all workloads. This +aggregate summary report assumes that options affecting reporting like +:option:`unified_rw_reporting` and :option:`percentile_list` are identical +across all the jobs summarized. Having different values for these options is an +unsupported configuration.
client.c +10 -0
@@ -1128,6 +1128,16 @@ static void handle_ts(struct fio_client *client, struct fio_net_cmd *cmd)sum_thread_stats (&client_ts, &p->ts);sum_group_stats (&client_gs, &p->rs); +if (!client_ts.members) { +/* Arbitrarily use the percentile toggles and percentile list +* from the first thread_stat that comes our way */ + client_ts.slat_percentiles = p->ts.slat_percentiles; + client_ts.clat_percentiles = p->ts.clat_percentiles; + client_ts.lat_percentiles = p->ts.lat_percentiles; + +for (int i =0 ; i <FIO_IO_U_LIST_MAX_LEN ; i++) + client_ts.percentile_list[i] = p->ts.percentile_list[i]; + } client_ts.members++; client_ts.thread_number = p->ts.thread_number; client_ts.groupid = p->ts.groupid;
fio.1 +9 -1
@@ -3844,6 +3844,10 @@ have a natural group-level equivalent. Examples include \fBkb_base\fR, \fBunit_base\fR, \fBsig_figs\fR, \fBthread_number\fR, \fBpid\fR, and \fBjob_start\fR. For these properties, the values for the first job are recorded for the group. +.P +Also, options like \fBpercentile_list\fR and \fBunified_rw_reporting\fR should +be consistent among the jobs in a reporting group. Having options like these +vary across the jobs in a reporting group is an unsupported configuration. .RE .TP .BI new_group
@@ -5148,7 +5152,11 @@ Terse output in client/server mode will differ slightly from what is produced when fio is run in stand-alone mode. See the terse output section for details. .P Also, if one fio invocation runs workloads on multiple servers, fio will -provide at the end an aggregate summary report for all workloads. +provide at the end an aggregate summary report for all workloads. This +aggregate summary report assumes that options affecting reporting like +\fBunified_rw_reporting\fR and \fBpercentile_list\fR are identical across all +the jobs summarized. Having different values for these options is an +unsupported configuration. .SH AUTHORS .B fio was written by Jens Axboe <[email protected]>.