Skip to contentSkip to conversation

Fix now playing list on playlist change

PATCH Applied Frédéric Danis 3 participants 7 messages Oct 4, 2024 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

cover Fix now playing list on playlist change

Some devices reuse the item ids for the Now Playing list on playlist change, e.g. using the Samsung Music on Samsung S23. These changes allows to clear the list and prevent to keep the previous tracks information.
This also extend the ListItems method to get the Artist, Album, Track number, Duration and Cover art handle.

This has been tested with Samsung S23 and iPhone 14.

Frédéric Danis (3):
audio/player: Fix media_player_set_metadata item destination audio/player: Clear playlist on Now Playing Changed AVRCP event audio/avrcp: Extend ListItems to get more metadata

 profiles/audio/avrcp.c  | 65 ++++++++++++++++++++++++++++++++---------
 profiles/audio/avrcp.h  |  1 +
 profiles/audio/player.c | 16 ++++++++--
 profiles/audio/player.h |  1 +
 4 files changed, 67 insertions(+), 16 deletions(-)
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/3 audio/player: Fix media_player_set_metadata item destination

Use item provided as parameter, or mp->track if NULL which is used by MCP.

---
 profiles/audio/player.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
profiles/audio/player.c +3 -2
index b3a6920fc..5bb3bc1a9 100644
@@ -1438,18 +1438,19 @@ void media_player_set_metadata(struct media_player *mp,
 				void *data, size_t len)
 {
 	char *value, *curval;
+	GHashTable *metadata = item ? item->metadata : mp->track;
 
 	value = g_strndup(data, len);
 
 	DBG("%s: %s", key, value);
 
-	curval = g_hash_table_lookup(mp->track, key);
+	curval = g_hash_table_lookup(metadata, key);
 	if (g_strcmp0(curval, value) == 0) {
 		g_free(value);
 		return;
 	}
 
-	g_hash_table_replace(mp->track, g_strdup(key), value);
+	g_hash_table_replace(metadata, g_strdup(key), value);
 }
 
 void media_player_metadata_changed(struct media_player *mp)
Signature · 1 line
2.34.1
#2 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=895618

---Test result---

Test Summary:

CheckPatch                    PASS      1.45 seconds
GitLint                       PASS      1.25 seconds
BuildEll                      PASS      24.25 seconds
BluezMake                     PASS      1588.13 seconds
MakeCheck                     PASS      13.20 seconds
MakeDistcheck                 PASS      182.09 seconds
CheckValgrind                 PASS      250.48 seconds
CheckSmatch                   PASS      349.91 seconds
bluezmakeextell               PASS      117.60 seconds
IncrementalBuild              PASS      4269.75 seconds
ScanBuild                     PASS      1023.16 seconds

---
Regards,
Linux Bluetooth

#3 lore raw

PATCH 2/3 audio/player: Clear playlist on Now Playing Changed AVRCP event

In reply to Frédéric Danis

Some devices reuse the item ids for the Now Playing list on playlist change. This commit allows to clear the list and prevent to keep the previous tracks information.

---
 profiles/audio/avrcp.c  | 15 +++++++++++++++
 profiles/audio/avrcp.h  |  1 +
 profiles/audio/player.c | 11 +++++++++++
 profiles/audio/player.h |  1 +
 4 files changed, 28 insertions(+)
profiles/audio/avrcp.c +15 -0
index ee750f50b..cab9fb4b2 100644
@@ -3819,6 +3819,17 @@ static void avrcp_setting_changed(struct avrcp *session,
 	}
 }
 
+static void avrcp_now_playing_changed(struct avrcp *session,
+						struct avrcp_header *pdu)
+{
+	struct avrcp_player *player = session->controller->player;
+	struct media_player *mp = player->user_data;
+
+	DBG("NowPlaying changed");
+
+	media_player_clear_playlist(mp);
+}
+
 static void avrcp_available_players_changed(struct avrcp *session,
 						struct avrcp_header *pdu)
 {
@@ -3909,6 +3920,9 @@ static gboolean avrcp_handle_event(struct avctp *conn, uint8_t code,
 	case AVRCP_EVENT_SETTINGS_CHANGED:
 		avrcp_setting_changed(session, pdu);
 		break;
+	case AVRCP_EVENT_NOW_PLAYING_CHANGED:
+		avrcp_now_playing_changed(session, pdu);
+		break;
 	case AVRCP_EVENT_AVAILABLE_PLAYERS_CHANGED:
 		avrcp_available_players_changed(session, pdu);
 		break;
@@ -4000,6 +4014,7 @@ static gboolean avrcp_get_capabilities_resp(struct avctp *conn, uint8_t code,
 		case AVRCP_EVENT_TRACK_CHANGED:
 		case AVRCP_EVENT_PLAYBACK_POS_CHANGED:
 		case AVRCP_EVENT_SETTINGS_CHANGED:
+		case AVRCP_EVENT_NOW_PLAYING_CHANGED:
 		case AVRCP_EVENT_ADDRESSED_PLAYER_CHANGED:
 		case AVRCP_EVENT_UIDS_CHANGED:
 		case AVRCP_EVENT_AVAILABLE_PLAYERS_CHANGED:
profiles/audio/avrcp.h +1 -0
index 59117e946..887753ddf 100644
@@ -64,6 +64,7 @@
 #define AVRCP_EVENT_TRACK_REACHED_START		0x04
 #define AVRCP_EVENT_PLAYBACK_POS_CHANGED	0x05
 #define AVRCP_EVENT_SETTINGS_CHANGED		0x08
+#define AVRCP_EVENT_NOW_PLAYING_CHANGED		0x09
 #define AVRCP_EVENT_AVAILABLE_PLAYERS_CHANGED	0x0a
 #define AVRCP_EVENT_ADDRESSED_PLAYER_CHANGED	0x0b
 #define AVRCP_EVENT_UIDS_CHANGED		0x0c
profiles/audio/player.c +11 -0
index 5bb3bc1a9..0f72d7601 100644
@@ -2024,6 +2024,17 @@ struct media_item *media_player_set_playlist_item(struct media_player *mp,
 	return item;
 }
 
+void media_player_clear_playlist(struct media_player *mp)
+{
+	if (mp->playlist) {
+		g_slist_free_full(mp->playlist->items, media_item_destroy);
+		mp->playlist->items = NULL;
+	}
+
+	g_dbus_emit_property_changed(btd_get_dbus_connection(), mp->path,
+					MEDIA_PLAYER_INTERFACE, "Playlist");
+}
+
 void media_player_set_obex_port(struct media_player *mp, uint16_t port)
 {
 	mp->obex_port = port;
profiles/audio/player.h +1 -0
index 0076c4641..5e181591c 100644
@@ -86,6 +86,7 @@ void media_player_set_folder(struct media_player *mp, const char *path,
 void media_player_set_playlist(struct media_player *mp, const char *name);
 struct media_item *media_player_set_playlist_item(struct media_player *mp,
 								uint64_t uid);
+void media_player_clear_playlist(struct media_player *mp);
 void media_player_set_obex_port(struct media_player *mp, uint16_t port);
 
 struct media_item *media_player_create_folder(struct media_player *mp,
Signature · 1 line
2.34.1
#4 lore raw

PATCH 3/3 audio/avrcp: Extend ListItems to get more metadata

In reply to Frédéric Danis

This allows user applications to display the playlist with Artist, Album, Track number, Duration and Cover art handle.

---
 profiles/audio/avrcp.c | 50 ++++++++++++++++++++++++++++++------------
 1 file changed, 36 insertions(+), 14 deletions(-)
profiles/audio/avrcp.c +36 -14
index cab9fb4b2..1622734b3 100644
@@ -2414,16 +2414,12 @@ static void avrcp_list_player_attributes(struct avrcp *session)
 }
 
 static void avrcp_parse_attribute_list(struct avrcp_player *player,
+					struct media_item *item,
 					uint8_t *operands, uint8_t count)
 {
 	struct media_player *mp = player->user_data;
-	struct media_item *item;
 	int i;
 
-	media_player_clear_metadata(mp);
-
-	item = media_player_set_playlist_item(mp, player->uid);
-
 	for (i = 0; count > 0; count--) {
 		uint32_t id;
 		uint16_t charset, len;
@@ -2448,8 +2444,6 @@ static void avrcp_parse_attribute_list(struct avrcp_player *player,
 
 		i += len;
 	}
-
-	media_player_metadata_changed(mp);
 }
 
 static gboolean avrcp_get_element_attributes_rsp(struct avctp *conn,
@@ -2462,6 +2456,8 @@ static gboolean avrcp_get_element_attributes_rsp(struct avctp *conn,
 	struct avrcp *session = user_data;
 	struct avrcp_player *player = session->controller->player;
 	struct avrcp_header *pdu = (void *) operands;
+	struct media_player *mp = player->user_data;
+	struct media_item *item;
 	uint8_t count;
 
 	if (code == AVC_CTYPE_REJECTED)
@@ -2474,7 +2470,13 @@ static gboolean avrcp_get_element_attributes_rsp(struct avctp *conn,
 		return FALSE;
 	}
 
-	avrcp_parse_attribute_list(player, &pdu->params[1], count);
+	media_player_clear_metadata(mp);
+
+	item = media_player_set_playlist_item(mp, player->uid);
+
+	avrcp_parse_attribute_list(player, item, &pdu->params[1], count);
+
+	media_player_metadata_changed(mp);
 
 	avrcp_get_play_status(session);
 
@@ -2560,9 +2562,10 @@ static struct media_item *parse_media_element(struct avrcp *session,
 	struct avrcp_player *player;
 	struct media_player *mp;
 	struct media_item *item;
-	uint16_t namelen;
+	uint16_t namelen, namesize;
 	char name[255];
 	uint64_t uid;
+	uint8_t count;
 
 	if (len < 13)
 		return NULL;
@@ -2570,10 +2573,13 @@ static struct media_item *parse_media_element(struct avrcp *session,
 	uid = get_be64(&operands[0]);
 
 	memset(name, 0, sizeof(name));
-	namelen = MIN(get_be16(&operands[11]), sizeof(name) - 1);
+	namesize = get_be16(&operands[11]);
+	namelen = MIN(namesize, sizeof(name) - 1);
 	if (namelen > 0)
 		memcpy(name, &operands[13], namelen);
 
+	count = operands[13 + namesize];
+
 	player = session->controller->player;
 	mp = player->user_data;
 
@@ -2583,6 +2589,9 @@ static struct media_item *parse_media_element(struct avrcp *session,
 
 	media_item_set_playable(item, true);
 
+	avrcp_parse_attribute_list(player, item, &operands[14 + namesize],
+					count);
+
 	return item;
 }
 
@@ -2717,20 +2726,25 @@ static void avrcp_list_items(struct avrcp *session, uint32_t start,
 	memset(buf, 0, sizeof(buf));
 
 	pdu->pdu_id = AVRCP_GET_FOLDER_ITEMS;
-	pdu->param_len = cpu_to_be16(10 + sizeof(uint32_t));
+	pdu->param_len = cpu_to_be16(10 + (6 * sizeof(uint32_t)));
 
 	pdu->params[0] = player->scope;
 
 	put_be32(start, &pdu->params[1]);
 	put_be32(end, &pdu->params[5]);
 
-	pdu->params[9] = 1;
+	pdu->params[9] = 6;
 
 	/* Only the title (0x01) is mandatory. This can be extended to
 	 * support AVRCP_MEDIA_ATTRIBUTE_* attributes */
 	put_be32(AVRCP_MEDIA_ATTRIBUTE_TITLE, &pdu->params[10]);
+	put_be32(AVRCP_MEDIA_ATTRIBUTE_ARTIST, &pdu->params[14]);
+	put_be32(AVRCP_MEDIA_ATTRIBUTE_ALBUM, &pdu->params[18]);
+	put_be32(AVRCP_MEDIA_ATTRIBUTE_TRACK, &pdu->params[22]);
+	put_be32(AVRCP_MEDIA_ATTRIBUTE_DURATION, &pdu->params[26]);
+	put_be32(AVRCP_MEDIA_ATTRIBUTE_IMG_HANDLE, &pdu->params[30]);
 
-	length += sizeof(uint32_t);
+	length += 6 * sizeof(uint32_t);
 
 	avctp_send_browsing_req(session->conn, buf, length,
 					avrcp_list_items_rsp, session);
@@ -2855,6 +2869,8 @@ static gboolean avrcp_get_item_attributes_rsp(struct avctp *conn,
 	struct avrcp *session = user_data;
 	struct avrcp_player *player = session->controller->player;
 	struct avrcp_browsing_header *pdu = (void *) operands;
+	struct media_player *mp = player->user_data;
+	struct media_item *item;
 	uint8_t count;
 
 	if (pdu == NULL) {
@@ -2874,7 +2890,13 @@ static gboolean avrcp_get_item_attributes_rsp(struct avctp *conn,
 		return FALSE;
 	}
 
-	avrcp_parse_attribute_list(player, &pdu->params[2], count);
+	media_player_clear_metadata(mp);
+
+	item = media_player_set_playlist_item(mp, player->uid);
+
+	avrcp_parse_attribute_list(player, item, &pdu->params[2], count);
+
+	media_player_metadata_changed(mp);
 
 	avrcp_get_play_status(session);
 
Signature · 1 line
2.34.1
#5 lore raw
In reply to Frédéric Danis

Hi,

Quoted 14 lines · Frédéric Danis

Some devices reuse the item ids for the Now Playing list on playlist change, e.g. using the Samsung Music on Samsung S23. These changes allows to clear the list and prevent to keep the previous tracks information.
This also extend the ListItems method to get the Artist, Album, Track number, Duration and Cover art handle.

This has been tested with Samsung S23 and iPhone 14.

Frédéric Danis (3):
audio/player: Fix media_player_set_metadata item destination audio/player: Clear playlist on Now Playing Changed AVRCP event audio/avrcp: Extend ListItems to get more metadata

Quoted 6 lines
  profiles/audio/avrcp.c  | 65 ++++++++++++++++++++++++++++++++---------
  profiles/audio/avrcp.h  |  1 +
  profiles/audio/player.c | 16 ++++++++--
  profiles/audio/player.h |  1 +
  4 files changed, 67 insertions(+), 16 deletions(-)

To be more clear and with samples here is what occurs in bluetoothctl currently, after playlist change on the phone only items with an UID greater than the last one of the previous playlist are displayed as new and metadata of the others are not updated:

[bluetooth]# connect 24:24:B7:11:82:6C
Attempting to connect to 24:24:B7:11:82:6C
[bluetooth]# [CHG] Device 24:24:B7:11:82:6C Connected: yes [Frédéric's S23]# [NEW] Endpoint /org/bluez/hci0/dev_24_24_B7_11_82_6C/sep3
[Frédéric's S23]# [NEW] Endpoint /org/bluez/hci0/dev_24_24_B7_11_82_6C/sep1
[Frédéric's S23]# [NEW] Endpoint /org/bluez/hci0/dev_24_24_B7_11_82_6C/sep2
[Frédéric's S23]# [NEW] Endpoint /org/bluez/hci0/dev_24_24_B7_11_82_6C/sep4
[Frédéric's S23]# [NEW] Endpoint /org/bluez/hci0/dev_24_24_B7_11_82_6C/sep5
[Frédéric's S23]# [NEW] Transport /org/bluez/hci0/dev_24_24_B7_11_82_6C/sep2/fd2
[Frédéric's S23]# Connection successful
[Frédéric's S23]# [NEW] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 [default] [Frédéric's S23]# [CHG] Device 24:24:B7:11:82:6C ServicesResolved: yes [Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/Filesystem /Filesystem [Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying /NowPlaying [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Type: Audio [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Subtype: Audio Book [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Status: paused [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Browsable: yes [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Playlist:
/org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Name: Samsung Music [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Repeat: off [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Shuffle: off [Frédéric's S23]# [NEW] Folder /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0
[Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Duration:
0x00036a1b (223771)
[Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Genre: Rock [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Title: Death On Two Legs
[Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Item:
/org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item1 [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.TrackNumber:
0x00000001 (1)
[Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Artist: Queen [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.NumberOfTracks:
0x0000000b (11)
[Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Album: A Night At The Opera
[Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.ImgHandle: 0000004 [Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item1 <unknown> [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Position: 0x00000000 (0) [Frédéric's S23]# player.change-folder /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying Attempting to change folder
[Frédéric's S23]# [CHG] Folder /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Name: /NowPlaying [Frédéric's S23]# ChangeFolder successful
[Frédéric's S23]# player.list-items 0 50
Attempting to list items
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item2 Lazing On A Sunday Afternoon
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item3 I'm In Love With My Car
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item4 You're My Best Friend
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item5 Sweet Lady
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item6 Seaside Rendezvous
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item7 The Prophet's Song
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item8 Love Of My Life
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item9 Good Company
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item10 Bohemian Rhapsody
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item11 God Save The Queen
[Frédéric's S23]# ListItems successful
[Frédéric's S23]# player.show-item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item2 Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item2
    Player: /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0
    Name: Lazing On A Sunday Afternoon
    Type: audio
    Playable: yes
    Metadata.Title: Lazing On A Sunday Afternoon
[CHG] Transport /org/bluez/hci0/dev_24_24_B7_11_82_6C/sep2/fd2
State: pending
[Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Position: 0x0000012b (299) [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Status: playing [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Position: 0x00000151 (337) [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Duration:
0x0001a8e6 (108774)
[Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Genre: <unknown> [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Title: Prologue [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Item:
/org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item1 [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.TrackNumber:
0x00000001 (1)
[Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Artist: Toto [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.NumberOfTracks:
0x00000011 (17)
[Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Album: Dune [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.ImgHandle: 0000006 [Frédéric's S23]# [CHG] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item1 Metadata.Duration: 0x0001a8e6 (108774)
[Frédéric's S23]# [CHG] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item1 Metadata.Genre: <unknown>
[Frédéric's S23]# [CHG] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item1 Metadata.Title: Prologue
[Frédéric's S23]# [CHG] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item1 Metadata.TrackNumber: 0x00000001 (1)
[Frédéric's S23]# [CHG] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item1 Metadata.Artist: Toto
[Frédéric's S23]# [CHG] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item1 Metadata.NumberOfTracks: 0x00000011 (17)
[Frédéric's S23]# [CHG] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item1 Metadata.Album: Dune
[Frédéric's S23]# [CHG] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item1 Metadata.ImgHandle: 0000006
[Frédéric's S23]# [CHG] Transport /org/bluez/hci0/dev_24_24_B7_11_82_6C/sep2/fd2 State: active [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Position: 0x00000173 (371) [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Position: 0x00000058 (88) [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Status: paused [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Position: 0x00000058 (88) [Frédéric's S23]# [CHG] Transport /org/bluez/hci0/dev_24_24_B7_11_82_6C/sep2/fd2 State: idle [Frédéric's S23]# list-items 0 50
Attempting to list items
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item12 Prelude (Take My Hand)
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item13 Paul Takes the Water of Life
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item14 Big Battle
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item15 Paul Kills Feyd
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item16 Final Dream
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item17 Take My Hand
[Frédéric's S23]# ListItems successful
[Frédéric's S23]# player.show-item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item2 Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item2
    Player: /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0
    Name: Lazing On A Sunday Afternoon
    Type: audio
    Playable: yes
    Metadata.Title: Lazing On A Sunday Afternoon

While with those commits, the items are deleted on playlist change and all new ones are created with correct metadata:

[bluetooth]# connect 24:24:B7:11:82:6C
Attempting to connect to 24:24:B7:11:82:6C
[bluetooth]# [CHG] Device 24:24:B7:11:82:6C Connected: yes [Frédéric's S23]# [NEW] Endpoint /org/bluez/hci0/dev_24_24_B7_11_82_6C/sep3
[Frédéric's S23]# [NEW] Endpoint /org/bluez/hci0/dev_24_24_B7_11_82_6C/sep1
[Frédéric's S23]# [NEW] Endpoint /org/bluez/hci0/dev_24_24_B7_11_82_6C/sep2
[Frédéric's S23]# [NEW] Endpoint /org/bluez/hci0/dev_24_24_B7_11_82_6C/sep4
[Frédéric's S23]# [NEW] Endpoint /org/bluez/hci0/dev_24_24_B7_11_82_6C/sep5
[Frédéric's S23]# [NEW] Transport /org/bluez/hci0/dev_24_24_B7_11_82_6C/sep2/fd0
[Frédéric's S23]# Connection successful
[Frédéric's S23]# [NEW] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 [default] [Frédéric's S23]# [CHG] Device 24:24:B7:11:82:6C ServicesResolved: yes [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Playlist is nil [Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/Filesystem /Filesystem [Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying /NowPlaying [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Type: Audio [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Subtype: Audio Book [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Status: paused [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Browsable: yes [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Playlist:
/org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Name: Samsung Music [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Repeat: off [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Shuffle: off [Frédéric's S23]# [NEW] Folder /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0
[Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Duration:
0x00036a1b (223771)
[Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Genre: Rock [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Title: Death On Two Legs
[Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Item:
/org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item1 [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.TrackNumber:
0x00000001 (1)
[Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Artist: Queen [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.NumberOfTracks:
0x0000000b (11)
[Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Album: A Night At The Opera
[Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.ImgHandle: 0000004 [Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item1 <unknown> [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Position: 0x00000590 (1424)
[Frédéric's S23]# player.change-folder /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying Attempting to change folder
[Frédéric's S23]# [CHG] Folder /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Name: /NowPlaying [Frédéric's S23]# ChangeFolder successful
[Frédéric's S23]# player.list-items 0 50
Attempting to list items
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item2 Lazing On A Sunday Afternoon
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item3 I'm In Love With My Car
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item4 You're My Best Friend
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item5 Sweet Lady
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item6 Seaside Rendezvous
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item7 The Prophet's Song
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item8 Love Of My Life
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item9 Good Company
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item10 Bohemian Rhapsody
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item11 God Save The Queen
[Frédéric's S23]# show-item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item2 Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item2
    Player: /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0
    Name: Lazing On A Sunday Afternoon
    Type: audio
    Playable: yes
    Metadata.Title: Lazing On A Sunday Afternoon Metadata.TrackNumber: 0x00000002 (2)
    Metadata.Duration: 0x0001077f (67455)
    Metadata.Album: A Night At The Opera
    Metadata.Artist: Queen
[Frédéric's S23]# ListItems successful
[Frédéric's S23]# [CHG] Transport /org/bluez/hci0/dev_24_24_B7_11_82_6C/sep2/fd0 State: pending [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Status: playing [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Position: 0x00000598 (1432)
[Frédéric's S23]# [CHG] Transport /org/bluez/hci0/dev_24_24_B7_11_82_6C/sep2/fd0 State: active [Frédéric's S23]# [CHG] Transport /org/bluez/hci0/dev_24_24_B7_11_82_6C/sep2/fd0 State: idle [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Position: 0x00000598 (1432)
[Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Status: paused [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Position: 0x00000598 (1432)
[Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Position: 0x00000030 (48) [Frédéric's S23]# [CHG] Transport /org/bluez/hci0/dev_24_24_B7_11_82_6C/sep2/fd0 State: pending [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Status: playing [Frédéric's S23]# [CHG] Transport /org/bluez/hci0/dev_24_24_B7_11_82_6C/sep2/fd0 State: active [Frédéric's S23]# [DEL] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item11 God Save The Queen
[Frédéric's S23]# [DEL] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item10 Bohemian Rhapsody
[Frédéric's S23]# [DEL] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item9 Good Company
[Frédéric's S23]# [DEL] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item8 Love Of My Life
[Frédéric's S23]# [DEL] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item7 The Prophet's Song
[Frédéric's S23]# [DEL] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item6 Seaside Rendezvous
[Frédéric's S23]# [DEL] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item5 Sweet Lady
[Frédéric's S23]# [DEL] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item4 You're My Best Friend
[Frédéric's S23]# [DEL] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item3 I'm In Love With My Car
[Frédéric's S23]# [DEL] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item2 Lazing On A Sunday Afternoon
[Frédéric's S23]# [DEL] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item1 <unknown> [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Playlist:
/org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Position: 0x0000023e (574) [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Duration:
0x0001a8e6 (108774)
[Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Genre: <unknown> [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Title: Prologue [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Item:
/org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item1 [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.TrackNumber:
0x00000001 (1)
[Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Artist: Toto [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.NumberOfTracks:
0x00000011 (17)
[Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.Album: Dune [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Track.ImgHandle: 0000006 [Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item1 <unknown> [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Position: 0x00000255 (597) [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Position: 0x00000000 (0) [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Status: paused [Frédéric's S23]# [CHG] Player /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0 Position: 0x00000000 (0) [Frédéric's S23]# [CHG] Transport /org/bluez/hci0/dev_24_24_B7_11_82_6C/sep2/fd0 State: idle [Frédéric's S23]# list-items 0 50
Attempting to list items
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item2 Main Title
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item3 Robot Fight
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item4 Leto's Theme
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item5 The Box [Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item6 The Floating Fat Man (The Baron)
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item7 Trip to Arrakis
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item8 First Attack
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item9 Prophecy Theme
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item10 Dune (Desert Theme)
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item11 Paul Meets Chani
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item12 Prelude (Take My Hand)
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item13 Paul Takes the Water of Life
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item14 Big Battle
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item15 Paul Kills Feyd
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item16 Final Dream
[Frédéric's S23]# [NEW] Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item17 Take My Hand
[Frédéric's S23]# ListItems successful
[Frédéric's S23]# player.show-item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item2 Item /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item2

        Player: /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0
        Name: Main Title
        Type: audio
        Playable: yes
        Metadata.Title: Main Title
        Metadata.TrackNumber: 0x00000002 (2)
        Metadata.Duration: 0x00013c54 (80980)
        Metadata.Album: Dune
        Metadata.Artist: Toto
Signature · 6 lines
Frédéric Danis
Senior Software Engineer

Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, United Kingdom
Registered in England & Wales, no. 5513718
#6 lore raw
In reply to Frédéric Danis
This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 8 lines · On Fri, 4 Oct 2024 16:40:40 +0200 you wrote:

Some devices reuse the item ids for the Now Playing list on playlist change, e.g. using the Samsung Music on Samsung S23. These changes allows to clear the list and prevent to keep the previous tracks information.
This also extend the ListItems method to get the Artist, Album, Track number, Duration and Cover art handle.

[...]

Here is the summary with links:
- [BlueZ,1/3] audio/player: Fix media_player_set_metadata item destination

    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=098b94ed6262
  - [BlueZ,2/3] audio/player: Clear playlist on Now Playing Changed AVRCP event
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=671f370a8e34
  - [BlueZ,3/3] audio/avrcp: Extend ListItems to get more metadata
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=31e5b8f20679

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html