Add mmc support for mt7988
Subsystems (5)
cover Add mmc support for mt7988
From: Frank Wunderlich <[email protected]>
Add MMC-Support for MT798 SoC
Frank Wunderlich (2):
dt-bindings: mmc: mtk-sd: Add mt7988 SoC
mmc: mtk-sd: add support for mt7988
.../devicetree/bindings/mmc/mtk-sd.yaml | 24 +++++++++++++++++++ drivers/mmc/host/mtk-sd.c | 14 +++++++++++ 2 files changed, 38 insertions(+)
Signature · 1 line
2.43.0
PATCH 1/2 dt-bindings: mmc: mtk-sd: Add mt7988 SoC
From: Frank Wunderlich <[email protected]>
Add binding definitions for mmc on MT7988 SoC.
--- .../devicetree/bindings/mmc/mtk-sd.yaml | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+)
Documentation/devicetree/bindings/mmc/mtk-sd.yaml +24 -0
@@ -21,6 +21,7 @@ properties: - mediatek,mt7620-mmc - mediatek,mt7622-mmc - mediatek,mt7986-mmc + - mediatek,mt7988-mmc - mediatek,mt8135-mmc - mediatek,mt8173-mmc - mediatek,mt8183-mmc
@@ -263,6 +264,29 @@ allOf: - const: bus_clk - const: sys_cg + - if: + properties: + compatible: + contains: + enum: + - mediatek,mt7988-mmc + then: + properties: + clocks: + minItems: 3 + items: + - description: source clock + - description: HCLK which used for host + - description: Advanced eXtensible Interface + - description: Advanced High-performance Bus clock + clock-names: + minItems: 3 + items: + - const: source + - const: hclk + - const: axi_cg + - const: ahb_cg + - if: properties: compatible:
Signature · 1 line
2.43.0
PATCH 2/2 mmc: mtk-sd: add support for mt7988
In reply to Frank WunderlichFrom: Frank Wunderlich <[email protected]>
Add support for mmc on MT7988 SoC.
--- drivers/mmc/host/mtk-sd.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
drivers/mmc/host/mtk-sd.c +14 -0
@@ -571,6 +571,19 @@ static const struct mtk_mmc_compatible mt7986_compat = { .support_64g = true, }; +static const struct mtk_mmc_compatible mt7988_compat = { + .clk_div_bits =12 , + .recheck_sdio_irq = true, + .hs400_tune = false, + .pad_tune_reg =MSDC_PAD_TUNE0 , + .async_fifo = true, + .data_tune = true, + .busy_check = true, + .stop_clk_fix = true, + .enhance_rx = true, + .support_64g = true, +}; +static const struct mtk_mmc_compatible mt8135_compat = { .clk_div_bits =8 , .recheck_sdio_irq = true,
@@ -629,6 +642,7 @@ static const struct of_device_id msdc_of_ids[] = { { .compatible = "mediatek,mt7620-mmc", .data = &mt7620_compat}, { .compatible = "mediatek,mt7622-mmc", .data = &mt7622_compat}, { .compatible = "mediatek,mt7986-mmc", .data = &mt7986_compat}, + { .compatible = "mediatek,mt7988-mmc", .data = &mt7988_compat}, { .compatible = "mediatek,mt8135-mmc", .data = &mt8135_compat}, { .compatible = "mediatek,mt8173-mmc", .data = &mt8173_compat}, { .compatible = "mediatek,mt8183-mmc", .data = &mt8183_compat},
Signature · 1 line
2.43.0
Re: [PATCH v1 1/2] dt-bindings: mmc: mtk-sd: Add mt7988 SoC
In reply to Frank WunderlichQuoted 30 lines · Frank Wunderlich
From: Frank Wunderlich <[email protected]>
Add binding definitions for mmc on MT7988 SoC.
Signed-off-by Frank Wunderlich <[email protected]>--- .../devicetree/bindings/mmc/mtk-sd.yaml | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+)Documentation/devicetree/bindings/mmc/mtk-sd.yaml +6
-0@@ -21,6 +21,7 @@ properties: - mediatek,mt7620-mmc - mediatek,mt7622-mmc - mediatek,mt7986-mmc + - mediatek,mt7988-mmc - mediatek,mt8135-mmc - mediatek,mt8173-mmc - mediatek,mt8183-mmc@@ -263,6 +264,29 @@ allOf: - const: bus_clk - const: sys_cg + - if: + properties: + compatible: + contains: + enum:
Documentation/devicetree/bindings/mmc/mtk-sd.yaml allOf: · line 281
Quoted 10 lines
Documentation/devicetree/bindings/mmc/mtk-sd.yaml +10
-0+ - mediatek,mt7988-mmc + then: + properties: + clocks: + minItems: 3 + items: + - description: source clock + - description: HCLK which used for host + - description: Advanced eXtensible Interface + - description: Advanced High-performance Bus clock
Why ahb is optional?
Best regards,
Krzysztof
Aw: Re: [PATCH v1 1/2] dt-bindings: mmc: mtk-sd: Add mt7988 SoC
Hi
Quoted 40 lines
Gesendet: Sonntag, 06. Oktober 2024 um 14:47 Uhr
Von: "Krzysztof Kozlowski" <[email protected]>
An: "Frank Wunderlich" <[email protected]>
Betreff: Re: [PATCH v1 1/2] dt-bindings: mmc: mtk-sd: Add mt7988 SoCQuoted 34 lines · Frank Wunderlich
From: Frank Wunderlich <[email protected]>
Add binding definitions for mmc on MT7988 SoC.
Signed-off-by Frank Wunderlich <[email protected]>--- .../devicetree/bindings/mmc/mtk-sd.yaml | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+)Documentation/devicetree/bindings/mmc/mtk-sd.yaml +10
-0@@ -21,6 +21,7 @@ properties: - mediatek,mt7620-mmc - mediatek,mt7622-mmc - mediatek,mt7986-mmc + - mediatek,mt7988-mmc - mediatek,mt8135-mmc - mediatek,mt8173-mmc - mediatek,mt8183-mmc@@ -263,6 +264,29 @@ allOf: - const: bus_clk - const: sys_cg + - if: + properties: + compatible: + contains: + enum: + - mediatek,mt7988-mmc + then: + properties: + clocks:
Quoted 8 lines
Documentation/devicetree/bindings/mmc/mtk-sd.yaml allOf: · line 281
Quoted 6 lines
Documentation/devicetree/bindings/mmc/mtk-sd.yaml +6
-0+ minItems: 3 + items: + - description: source clock + - description: HCLK which used for host + - description: Advanced eXtensible Interface + - description: Advanced High-performance Bus clockWhy ahb is optional?
sorry, my fault, forgot to change the minitems property after copy the block
Quoted 2 lines
Best regards,
Krzysztof