Skip to contentSkip to conversation

dt-bindings: spi: add compatibles for mt7988

PATCH In review Frank Wunderlich 4 participants 4 messages Oct 6, 2024 – Oct 7, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: spi: add compatibles for mt7988

From: Frank Wunderlich <[email protected]>

MT7988 has 2 different spi controllers. Add mediatek,ipm-spi-single and mediatek,ipm-spi-quad compatibles.

---
 Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml +2 -0
index e1f5bfa4433c..3c707e5de5fb 100644
@@ -33,6 +33,8 @@ properties:
           - const: mediatek,mt6765-spi
       - items:
           - enum:
+              - mediatek,ipm-spi-quad
+              - mediatek,ipm-spi-single
               - mediatek,mt7981-spi-ipm
               - mediatek,mt7986-spi-ipm
               - mediatek,mt8188-spi-ipm
Signature · 1 line
2.43.0
#1 lore raw
Quoted 4 lines · Frank Wunderlich

From: Frank Wunderlich <[email protected]>

MT7988 has 2 different spi controllers. Add mediatek,ipm-spi-single and mediatek,ipm-spi-quad compatibles.

Why generic compatibles?

These are supposed to be SoC-specific.

Best regards,
Krzysztof

#2 lore raw

Hi

Quoted 5 lines

Gesendet: Sonntag, 06. Oktober 2024 um 14:48 Uhr
Von: "Krzysztof Kozlowski" <[email protected]>
Betreff: Re: [PATCH v1] dt-bindings: spi: add compatibles for mt7988

On Sun, Oct 06, 2024 at 12:27:39PM +0200, Frank Wunderlich wrote:

Quoted 8 lines
Quoted 4 lines

From: Frank Wunderlich <[email protected]>

MT7988 has 2 different spi controllers. Add mediatek,ipm-spi-single and mediatek,ipm-spi-quad compatibles.

Why generic compatibles?

These are supposed to be SoC-specific.

currently i used the compatibles used in SDK, but got info now, that there is some more discussion needed with mtk.

Quoted 4 lines

Best regards,
Krzysztof

maintainer
#3 lore raw
Quoted 9 lines · Frank Wunderlich

Hi

Quoted 7 lines

Gesendet: Sonntag, 06. Oktober 2024 um 14:48 Uhr
Von: "Krzysztof Kozlowski" <[email protected]>
Betreff: Re: [PATCH v1] dt-bindings: spi: add compatibles for mt7988

Quoted 2 lines · Frank Wunderlich

From: Frank Wunderlich <[email protected]>

Quoted 9 lines
Quoted 6 lines
Quoted 2 lines

MT7988 has 2 different spi controllers. Add mediatek,ipm-spi-single and mediatek,ipm-spi-quad compatibles.

Why generic compatibles?

These are supposed to be SoC-specific.

currently i used the compatibles used in SDK, but got info now, that there is some more discussion needed with mtk.

Ok, but please don't introduce generic compatibles. We prever SoC specific ones with a fall-back (to a different SoC specific one).

Regards,
Matthias