iio: {amplifiers,dac,frequency,resolver}: add missing selects in Kconfig
v2 cover iio: {amplifiers,dac,frequency,resolver}: add missing selects in Kconfig
This series adds some missing selects in the Kconfig entry for the following drivers:
- ad2s1210 (BUFFER, TRIGGERED_BUFFER, REGMAP)
- adf4377 (REGMAP_SPI)
- admv4420 (REMGAP_SPI)
- ada4250 (REGMAP_SPI)
- ad4770r (REGMAP_SPI)
- ltc1660 (REGMAP_SPI)
- stm32-dac-core (REGMAP_MMIO)
Usually you will not notice the missing dependencies, but tiny config files where those drivers are include will lead to multiple errors when compiling and linking.
The issue was found while compiling the ad2s1210, and then I looked for other cases where REGMAP was missing.
---
Changes in v2:
- rebase onto iio/fixes-togreg to drop applied patches.
- Split [4/8] and extend the code formatting to adrf6780.
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Javier Carrasco (2):
iio: frequency: {admv4420,adrf6780}: format Kconfig entries
iio: frequency: admv4420: fix missing select REMAP_SPI in Kconfig
drivers/iio/frequency/Kconfig | 33 +++++++++++++++++---------------- 1 file changed, 17 insertions(+), 16 deletions(-)
---
base-commit: ccf9af8b0dadd0aecc24503ef289cbc178208418
change-id: 20241003-ad2s1210-select-a0a73a48038a
Best regards,
Signature · 1 line
Javier Carrasco <[email protected]>
PATCH v2 1/2 iio: frequency: {admv4420,adrf6780}: format Kconfig entries
Format the entries of these drivers in the Kconfig, where spaces instead of tabs were used.
--- drivers/iio/frequency/Kconfig | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-)
drivers/iio/frequency/Kconfig +16 -16
@@ -92,25 +92,25 @@ config ADMV1014 module will be called admv1014. config ADMV4420 - tristate "Analog Devices ADMV4420 K Band Downconverter" - depends on SPI - help - Say yes here to build support for Analog Devices K Band - Downconverter with integrated Fractional-N PLL and VCO. + tristate "Analog Devices ADMV4420 K Band Downconverter" + depends on SPI + help + Say yes here to build support for Analog Devices K Band + Downconverter with integrated Fractional-N PLL and VCO. - To compile this driver as a module, choose M here: the - module will be called admv4420. + To compile this driver as a module, choose M here: the + module will be called admv4420. config ADRF6780 - tristate "Analog Devices ADRF6780 Microwave Upconverter" - depends on SPI - depends on COMMON_CLK - help - Say yes here to build support for Analog Devices ADRF6780 - 5.9 GHz to 23.6 GHz, Wideband, Microwave Upconverter. - - To compile this driver as a module, choose M here: the - module will be called adrf6780. + tristate "Analog Devices ADRF6780 Microwave Upconverter" + depends on SPI + depends on COMMON_CLK + help + Say yes here to build support for Analog Devices ADRF6780 + 5.9 GHz to 23.6 GHz, Wideband, Microwave Upconverter. + + To compile this driver as a module, choose M here: the + module will be called adrf6780. endmenu endmenu
Signature · 1 line
2.43.0
PATCH v2 2/2 iio: frequency: admv4420: fix missing select REMAP_SPI in Kconfig
In reply to Javier CarrascoThis driver makes use of regmap_spi, but does not select the required module.
Add the missing 'select REGMAP_SPI'.
--- drivers/iio/frequency/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/iio/frequency/Kconfig +1 -0
@@ -94,6 +94,7 @@ config ADMV1014 config ADMV4420 tristate "Analog Devices ADMV4420 K Band Downconverter" depends on SPI + select REGMAP_SPI help Say yes here to build support for Analog Devices K Band Downconverter with integrated Fractional-N PLL and VCO.
Signature · 1 line
2.43.0
Jonathan Cameron
maintainerQuoted 10 lines · On Mon, 07 Oct 2024 22:06:37 +0200 Javier Carrasco…
This series adds some missing selects in the
Kconfigentry for the following drivers:
- ad2s1210 (BUFFER,TRIGGERED_BUFFER, REGMAP)
- adf4377 (REGMAP_SPI)
- admv4420 (REMGAP_SPI)
- ada4250 (REGMAP_SPI)
- ad4770r (REGMAP_SPI)
- ltc1660 (REGMAP_SPI)
- stm32-dac-core (REGMAP_MMIO)
Quoted 8 lines
Usually you will not notice the missing dependencies, but tiny config files where those drivers are include will lead to multiple errors when compiling and linking.
The issue was found while compiling the ad2s1210, and then I looked for other cases where REGMAP was missing.
Signed-off-by Javier Carrasco <[email protected]>
This is a pain. I was going to just flip the order of these, but turns out that not only was it spaces rather than tabs but there weren't even the right number of spaces. As such I can't just have a mix briefly and fix it up once I can take the white space patch.
Ah well, it's not that large to have as a precursor to a fix. Applied both patches to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
Quoted 18 lines
---
Changes in v2:
- rebase onto iio/fixes-togreg to drop applied patches.
- Split [4/8] and extend the code formatting to adrf6780.
- Link to v1: https://lore.kernel.org/r/[email protected]---
Javier Carrasco (2):
iio: frequency: {admv4420,adrf6780}: formatKconfigentries
iio: frequency: admv4420: fix missing selectREMAP_SPIinKconfigdrivers/iio/frequency/Kconfig | 33 +++++++++++++++++---------------- 1 file changed, 17 insertions(+), 16 deletions(-)---
base-commit:ccf9af8b0dadd0aecc24503ef289cbc178208418
change-id: 20241003-ad2s1210-select-a0a73a48038aBest regards,