dma-buf: Use atomic64_inc_return() in dma_buf_getfile()
Subsystems (2)
PATCH 1/1 dma-buf: Use atomic64_inc_return() in dma_buf_getfile()
Use atomic64_inc_return(&ref) instead of atomic64_add_return(1, &ref) to use optimized implementation and ease register pressure around the primitive for targets that implement optimized variant.
--- drivers/dma-buf/dma-buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma-buf/dma-buf.c +1 -1
@@ -558,7 +558,7 @@ static struct file *dma_buf_getfile(size_t size, int flags)* Override ->i_ino with the unique and dmabuffs specific * value. */ - inode->i_ino =atomic64_add_return (1 , &dmabuf_inode); + inode->i_ino =atomic64_inc_return (&dmabuf_inode); flags &=O_ACCMODE |O_NONBLOCK ; file =alloc_file_pseudo (inode, dma_buf_mnt,"dmabuf" , flags, &dma_buf_fops);
Signature · 1 line
2.46.2
Quoted 10 lines · Patchwork Integration
Dear Uros Bizjak:
The unreliable Media-CI system has found some issues with your series.
Check the report at: https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/64723788/artifacts/report.htmPlease fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded.
If you believe that the CI is wrong, kindly reply-all to this email.
I don't think CI is correct in my case, the failure log says that I should prefix my patch with "media:":
WARNING: ./0001-dma-buf-Use-atomic64_inc_return-in-dma_buf_getfile.patch:
Missing 'media:' prefix in Subject
But the patch is not specific to media, it is specific to dma-buf.
Best regards,
Uros.
Hi Uros
Thanks for the email! We have fixed it in the latest version
Regards!
Quoted 24 lines · Uros Bizjak
Quoted 10 lines · Patchwork Integration
Dear Uros Bizjak:
The unreliable Media-CI system has found some issues with your series.
Check the report at: https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/64723788/artifacts/report.htmPlease fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded.
If you believe that the CI is wrong, kindly reply-all to this email.
I don't think CI is correct in my case, the failure log says that I should prefix my patch with "media:":
WARNING: ./0001-dma-buf-Use-atomic64_inc_return-in-dma_buf_getfile.patch:
Missing 'media:' prefix in SubjectBut the patch is not specific to media, it is specific to dma-buf.
Best regards,
Uros.
Signature · 1 line
Ricardo Ribalda