net: ibm: emac: mal: fix wrong goto
Subsystems (2)
PATCH 1/1 net: ibm: emac: mal: fix wrong goto
dcr_map is called in the previous if and therefore needs to be unmapped.
Fixes 1ff0fcfcb1a6 ("ibm_newemac: Fix new MAL feature handling")
Signed-off-by Rosen Penev <[email protected]>
--- drivers/net/ethernet/ibm/emac/mal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/ibm/emac/mal.c +1 -1
@@ -578,7 +578,7 @@ static int mal_probe(struct platform_device *ofdev)printk (KERN_ERR "%pOF: Support for 405EZ not enabled!\n" , ofdev->dev.of_node); err = -ENODEV ; - goto fail; + goto fail_unmap;#endif }
Signature · 1 line
2.46.2
Quoted 1 line
dcr_mapis called in the previous if and therefore needs to be unmapped.
How do you think about to choose an additional imperative wording for an improved change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n94
Regards,
Markus
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Mon, 7 Oct 2024 16:57:11 -0700 you wrote:
dcr_mapis called in the previous if and therefore needs to be unmapped.Fixes 1ff0fcfcb1a6 ("ibm_newemac: Fix new MAL feature handling")Signed-off-by Rosen Penev <[email protected]>--- drivers/net/ethernet/ibm/emac/mal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net] net: ibm: emac: mal: fix wrong goto
https://git.kernel.org/netdev/net/c/08c8acc9d8f3
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html