Automatically generate syscalls.h
v4 cover Automatically generate syscalls.h
The problem we have at the moment is that all syscalls input files must be changed by hand each time we need to test a new syscall. The idea is to simplify this process, providing a script that is able to read from kernel sources and to generate all syscalls files we need.
This patch set adds a new command inside the syscalls folder and it refactors the previous regen.sh code.
The new way we have to generate the syscalls.h file is the following:
include/lapi/syscalls/generate_arch.sh path/to/kernel/source
include/lapi/syscalls/generate_syscalls.sh path/to/syscalls.h
Scripts are independent and they can be run separately. generate_syscalls.sh is the equivalent of regen.sh, but its code has been cleaned up.
---
Changes in v4:
- remove blacklist file
- update syscalls files
- Link to v3: https://lore.kernel.org/r/[email protected]
Changes in v3:
- fix generate_arch.sh to work properly for all architectures
- rename some arch .in files and handle renaming inside
generate_syscalls.sh using the right gcc directives
- Link to v2: https://lore.kernel.org/r/[email protected]
Changes in v2:
- refactor regen.sh
- split syscalls.h and syscalls .in files creation
- updated syscalls .in files
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Andrea Cervesato (4):
Refactor regen.sh script to generate syscalls Add script to generate arch(s) dependant syscalls Delete obsolete strip_syscall.awk file Update syscalls files
configure.ac | 2 +-
include/lapi/syscalls/arc.in | 41 +-
include/lapi/syscalls/arm.in | 819 +++++++++++----------
include/lapi/syscalls/{loongarch.in => arm64.in} | 12 +-
include/lapi/syscalls/generate_arch.sh | 205 ++++++
include/lapi/syscalls/generate_syscalls.sh | 118 +++
include/lapi/syscalls/hppa.in | 52 --
include/lapi/syscalls/i386.in | 18 +-
include/lapi/syscalls/ia64.in | 10 +-
.../lapi/syscalls/{aarch64.in => loongarch64.in} | 20 +-
include/lapi/syscalls/{mips_n64.in => mips64.in} | 13 +-
.../lapi/syscalls/{mips_n32.in => mips64n32.in} | 13 +-
include/lapi/syscalls/{mips_o32.in => mipso32.in} | 19 +-
include/lapi/syscalls/parisc.in | 397 ++++++++++
include/lapi/syscalls/powerpc.in | 19 +-
include/lapi/syscalls/powerpc64.in | 47 +-
include/lapi/syscalls/regen.sh | 129 ----
include/lapi/syscalls/s390.in | 15 +-
include/lapi/syscalls/s390x.in | 15 +-
include/lapi/syscalls/sh.in | 15 +-
include/lapi/syscalls/sparc.in | 14 +-
include/lapi/syscalls/sparc64.in | 16 +-
include/lapi/syscalls/strip_syscall.awk | 19 -
.../lapi/syscalls/{order => supported-arch.txt} | 12 +-
include/lapi/syscalls/x86_64.in | 51 +-
25 files changed, 1356 insertions(+), 735 deletions(-)---
base-commit: 701212f08d6e850457cc2b10238f28662ef48471
change-id: 20240923-generate_syscalls-780dc2227bdb
Best regards,
Signature · 5 lines
Andrea Cervesato <[email protected]> -- Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH v4 1/4 Refactor regen.sh script to generate syscalls
From: Andrea Cervesato <[email protected]>
Rename regen.sh into a more meaningful generate_syscalls.sh name, rename order into a more meaningful supported-syscalls.txt name and rewrite part of the regen.sh script code in order to execute it from anywhere in the filesystem, without need to be in its own folder. The new code is also more clear and concise, using native sh features which are simplifying the code.
---
configure.ac | 2 +-
include/lapi/syscalls/generate_syscalls.sh | 115 ++++++++++++++++++
include/lapi/syscalls/regen.sh | 129 ---------------------
.../lapi/syscalls/{order => supported-arch.txt} | 0
4 files changed, 116 insertions(+), 130 deletions(-)configure.ac +1 -1
@@ -384,7 +384,7 @@ else AC_SUBST([WITH_REALTIME_TESTSUITE],["no"]) fi -AC_CONFIG_COMMANDS([syscalls.h], [cd ${ac_top_srcdir}/include/lapi/syscalls; ./regen.sh]) +AC_CONFIG_COMMANDS([syscalls.h], [cd ${ac_top_srcdir}/include/lapi/syscalls; ./generate_syscalls.sh ../syscalls.h]) # custom functions # NOTE: don't create custom functions for simple checks, put them into this file
include/lapi/syscalls/generate_syscalls.sh new file +115 -0
115 lines not on this page · raw message
include/lapi/syscalls/regen.sh deleted +0 -129
129 lines not on this page · raw message
include/lapi/syscalls/supported-arch.txt renamed from include/lapi/syscalls/order +0 -0
Signature · 5 lines
2.43.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH v4 1/4] Refactor regen.sh script to generate syscalls
Quoted 30 lines · Andrea Cervesato
From: Andrea Cervesato <[email protected]>
Rename
regen.shinto a more meaningfulgenerate_syscalls.shname, rename order into a more meaningful supported-syscalls.txt name and rewrite part of theregen.shscript code in order to execute it from anywhere in the filesystem, without need to be in its own folder. The new code is also more clear and concise, using native sh features which are simplifying the code.Signed-off-by Andrea Cervesato <[email protected]>--- configure.ac | 2 +- include/lapi/syscalls/generate_syscalls.sh | 115 ++++++++++++++++++ include/lapi/syscalls/regen.sh | 129 --------------------- .../lapi/syscalls/{order => supported-arch.txt} | 0 4 files changed, 116 insertions(+), 130 deletions(-)configure.ac +1
-1@@ -384,7 +384,7 @@ else AC_SUBST([WITH_REALTIME_TESTSUITE],["no"]) fi -AC_CONFIG_COMMANDS([syscalls.h], [cd ${ac_top_srcdir}/include/lapi/syscalls; ./regen.sh]) +AC_CONFIG_COMMANDS([syscalls.h], [cd
Quoted 3 lines
${ac_top_srcdir}/include/lapi/syscalls; ./generate_syscalls.sh
../syscalls.h])
You probably need to rebase this line if Zhijian's patch gets applied first.
https://lists.linux.it/pipermail/ltp/2024-October/040574.html
Otherwise, this one looks pretty good.
Signature · 5 lines
Regards, Li Wang -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH v4 1/4] Refactor regen.sh script to generate syscalls
In reply to Andrea CervesatoHi Andrea,
nice improvement.
TL;DR typo "kj" + missing SPDX and copyright would be worth to fix before merge.
Below are other minor notes, feel free to ignore.
Quoted 20 lines
Rename
regen.shinto a more meaningfulgenerate_syscalls.shname, rename order into a more meaningful supported-syscalls.txt name and rewrite part of theregen.shscript code in order to execute it from anywhere in the filesystem, without need to be in its own folder. The new code is also more clear and concise, using native sh features which are simplifying the code.Signed-off-by Andrea Cervesato <[email protected]>--- configure.ac | 2 +- include/lapi/syscalls/generate_syscalls.sh | 115 ++++++++++++++++++ include/lapi/syscalls/regen.sh | 129 --------------------- .../lapi/syscalls/{order => supported-arch.txt} | 0 4 files changed, 116 insertions(+), 130 deletions(-)configure.ac +0
-0
configure.ac else · line 387
Quoted 5 lines
configure.ac +1
-1@@ -384,7 +384,7 @@ else AC_SUBST([WITH_REALTIME_TESTSUITE],["no"]) fi -AC_CONFIG_COMMANDS([syscalls.h], [cd ${ac_top_srcdir}/include/lapi/syscalls; ./regen.sh]) +AC_CONFIG_COMMANDS([syscalls.h], [cd ${ac_top_srcdir}/include/lapi/syscalls; ./generate_syscalls.sh ../syscalls.h])
As Li noted, this will need to be rebasedAC_CONFIG_COMMANDS([syscalls.h], [cd ${ac_top_srcdir}/include/lapi/syscalls; ./generate_syscalls.sh; cd - >/dev/null])
But as you don't do cd, that fix "cd - > /dev/null" can be again removed.
include/lapi/syscalls/generate_syscalls.sh line 1
Quoted 9 lines
configure.ac +0
-0# custom functions # NOTE: don't create custom functions for simple checks, put them into this fileinclude/lapi/syscalls/generate_syscalls.sh new file +1
-0@@ -0,0 +1,115 @@ +#!/bin/sh
The script should have SPDX + some copyright, right? # SPDX-License-Identifier: GPL-2.0-or-later
include/lapi/syscalls/generate_syscalls.sh line 6
Quoted 5 lines
include/lapi/syscalls/generate_syscalls.sh new file +5
-0+# +# Generate the syscalls.h file, merging all architectures syscalls input file +# which are in the current folder and defined inside supported-arch.txt file. + +SYSCALLS_FILE="${1}"
nit: {} are not needed
SYSCALLS_FILE="$1"
I would personally use ${..} only when needed (IMHO everywhere in the script just $... can be used (readability).
Quoted 11 lines
include/lapi/syscalls/generate_syscalls.sh new file +11
-0+ +if [ -z "${SYSCALLS_FILE}" ]; then + echo "Please provide the syscalls.h directory:" + echo "" + echo "$0 path/of/syscalls.h" + echo "" + exit 1 +fi + +SCRIPT_DIR="$(realpath $(dirname "$0"))" +SUPPORTED_ARCH="${SCRIPT_DIR}/supported-arch.txt"
include/lapi/syscalls/generate_syscalls.sh line 27
Quoted 10 lines
include/lapi/syscalls/generate_syscalls.sh new file +10
-0+ +merge_syscalls() { + echo ' +/************************************************ +* GENERATED FILE: DO NOT EDIT/PATCH THIS FILE * +* change your arch specific .in file instead * +************************************************/ + +/* +kj* Here we stick all the ugly *fallback* logic for linux
typo "kj", can you please remove it?
Quoted 58 lines
include/lapi/syscalls/generate_syscalls.sh new file +58
-0+* system call numbers (those __NR_ thingies). +* +* Licensed under the GPLv2 or later, see the COPYING file. +*/ + +#ifndef LAPI_SYSCALLS_H__ +#define LAPI_SYSCALLS_H__ + +#include <errno.h> +#include <sys/syscall.h> +#include <asm/unistd.h> + +#ifdef TST_TEST_H__ +#define TST_SYSCALL_BRK__(NR, SNR) ({ \ +tst_brk(TCONF, \ + "syscall(%d) " SNR " not supported on your arch", NR); \ +}) +#else +inline static void dummy_cleanup(void) {} + +#define TST_SYSCALL_BRK__(NR, SNR) ({ \ +tst_brkm(TCONF, dummy_cleanup, \ + "syscall(%d) " SNR " not supported on your arch", NR); \ +}) +#endif + +#define tst_syscall(NR, ...) ({ \ +intptr_t tst_ret; \ +if (NR == __LTP__NR_INVALID_SYSCALL) { \ + errno = ENOSYS; \ + tst_ret = -1; \ +} else { \ + tst_ret = syscall(NR, ##__VA_ARGS__); \ +} \ +if (tst_ret == -1 && errno == ENOSYS) { \ + TST_SYSCALL_BRK__(NR, #NR); \ +} \ +tst_ret; \ +}) + +#define __LTP__NR_INVALID_SYSCALL -1' >${SYSCALLS_FILE} + + while IFS= read -r arch; do + ( + echo + case ${arch} in + sparc64) echo "#if defined(__sparc__) && defined(__arch64__)" ;; + sparc) echo "#if defined(__sparc__) && !defined(__arch64__)" ;; + s390) echo "#if defined(__s390__) && !defined(__s390x__)" ;; + mips_n32) echo "#if defined(__mips__) && defined(_ABIN32)" ;; + mips_n64) echo "#if defined(__mips__) && defined(_ABI64)" ;; + mips_o32) echo "#if defined(__mips__) && defined(_ABIO32) && _MIPS_SZLONG == 32" ;; + *) echo "#ifdef __${arch}__" ;; + esac + + while read -r line; do + set -- ${line} + syscall_nr="__NR_$1"
include/lapi/syscalls/generate_syscalls.sh line 95
Quoted 10 lines
include/lapi/syscalls/generate_syscalls.sh new file +10
-0+ shift + + echo "# ifndef ${syscall_nr}" + echo "# define ${syscall_nr} $*" + echo "# endif" + done <"${SCRIPT_DIR}/${arch}.in" + echo "#endif" + echo + ) >>${SYSCALLS_FILE} + done <${SUPPORTED_ARCH}
nit: I would either don't define any function at all (have everything as inline, thus save 1 indent) or, have this part of the code as a function.
Kind regards,
Petr
Quoted 20 lines
include/lapi/syscalls/generate_syscalls.sh new file +20
-0+ + ( + echo + echo "/* Common stubs */" + while IFS= read -r arch; do + while IFS= read -r line; do + set -- ${line} + syscall_nr="__NR_$1" + shift + + echo "# ifndef ${syscall_nr}" + echo "# define ${syscall_nr} __LTP__NR_INVALID_SYSCALL" + echo "# endif" + done <"${SCRIPT_DIR}/${arch}.in" + done <${SUPPORTED_ARCH} + echo "#endif" + ) >>${SYSCALLS_FILE} +} + +merge_syscalls
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH v4 2/4 Add script to generate arch(s) dependant syscalls
In reply to Andrea CervesatoFrom: Andrea Cervesato <[email protected]>
Add generate_arch.sh script which can be used to generate arch(s) dependant syscalls file. The way it works is pretty simple: for each architecture defined into supported-arch.txt, compile kernel headers, extract the list of syscalls and generate a .in file containing all of them, associated with their own syscall's number.
The way syscalls files are generated, passes through a C application which is automatically checking the availability of the syscalls in the user space environment.
---
include/lapi/syscalls/{aarch64.in => arm64.in} | 0
include/lapi/syscalls/generate_arch.sh | 205 +++++++++++++++++++++
include/lapi/syscalls/generate_syscalls.sh | 9 +-
.../lapi/syscalls/{loongarch.in => loongarch64.in} | 0
include/lapi/syscalls/{mips_n64.in => mips64.in} | 0
.../lapi/syscalls/{mips_n32.in => mips64n32.in} | 0
include/lapi/syscalls/{mips_o32.in => mipso32.in} | 0
include/lapi/syscalls/{hppa.in => parisc.in} | 0
include/lapi/syscalls/supported-arch.txt | 12 +-
9 files changed, 217 insertions(+), 9 deletions(-)include/lapi/syscalls/arm64.in renamed from include/lapi/syscalls/aarch64.in +0 -0
include/lapi/syscalls/generate_arch.sh new file +205 -0
205 lines not on this page · raw message
include/lapi/syscalls/generate_syscalls.sh +6 -3
@@ -74,9 +74,12 @@ tst_ret; \ sparc64) echo "#if defined(__sparc__) && defined(__arch64__)" ;; sparc) echo "#if defined(__sparc__) && !defined(__arch64__)" ;; s390) echo "#if defined(__s390__) && !defined(__s390x__)" ;; - mips_n32) echo "#if defined(__mips__) && defined(_ABIN32)" ;; - mips_n64) echo "#if defined(__mips__) && defined(_ABI64)" ;; - mips_o32) echo "#if defined(__mips__) && defined(_ABIO32) && _MIPS_SZLONG == 32" ;; + mips64n32) echo "#if defined(__mips__) && defined(_ABIN32)" ;; + mips64) echo "#if defined(__mips__) && defined(_ABI64)" ;; + mipso32) echo "#if defined(__mips__) && defined(_ABIO32) && _MIPS_SZLONG == 32" ;; + parisc) echo "#ifdef __hppa__" ;; + loongarch64) echo "#ifdef __loongarch__" ;; + arm64) echo "#ifdef __aarch64__" ;; *) echo "#ifdef __${arch}__" ;; esac
include/lapi/syscalls/loongarch64.in renamed from include/lapi/syscalls/loongarch.in +0 -0
include/lapi/syscalls/mips64.in renamed from include/lapi/syscalls/mips_n64.in +0 -0
include/lapi/syscalls/mips64n32.in renamed from include/lapi/syscalls/mips_n32.in +0 -0
include/lapi/syscalls/mipso32.in renamed from include/lapi/syscalls/mips_o32.in +0 -0
include/lapi/syscalls/parisc.in renamed from include/lapi/syscalls/hppa.in +0 -0
include/lapi/syscalls/supported-arch.txt +6 -6
@@ -1,13 +1,13 @@ -aarch64 arc +arm64 arm -hppa i386 ia64 -loongarch -mips_n32 -mips_n64 -mips_o32 +loongarch64 +mips64n32 +mips64 +mipso32 +parisc powerpc64 powerpc s390x
Signature · 5 lines
2.43.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH v4 2/4] Add script to generate arch(s) dependant syscalls
Quoted 9 lines · Andrea Cervesato
Add
generate_arch.shscript which can be used to generate arch(s) dependant syscalls file. The way it works is pretty simple: for each architecture defined into supported-arch.txt, compile kernel headers, extract the list of syscalls and generate a .in file containing all of them, associated with their own syscall's number.
The way syscalls files are generated, passes through a C application which is automatically checking the availability of the syscalls in the user space environment.
This is a great idea, thanks for achieving it.
Signature · 5 lines
Regards, Li Wang -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH v4 2/4] Add script to generate arch(s) dependant syscalls
In reply to Andrea CervesatoHi Andrea,
Quoted 5 lines
Add
generate_arch.shscript which can be used to generate arch(s) dependant syscalls file. The way it works is pretty simple: for each architecture defined into supported-arch.txt, compile kernel headers, extract the list of syscalls and generate a .in file containing all of them, associated with their own syscall's number.
Nice improvement, thanks!
Quoted 3 lines
The way syscalls files are generated, passes through a C application which is automatically checking the availability of the syscalls in the user space environment.
This C application is in the Linux kernel and we only consume the result right?
If the C app was needed to be run for LTP, that would broke LTP cross compilation. (There are people compiling LTP with cross compilation, e.g. arm folks in yocto and Buildroot, riscv64 on openSUSE Tumbleweed).
Quoted 6 lines
include/lapi/syscalls/generate_arch.sh new file +0
-0
include/lapi/syscalls/generate_arch.sh line 7
Quoted 8 lines
include/lapi/syscalls/generate_arch.sh new file +7
-0@@ -0,0 +1,205 @@ +#!/bin/sh +# +# This is an adaptation of the update-tables.sh script, included in the +# syscalls-table project (https://github.com/hrw/syscalls-table) and released +# under the MIT license. +# +# Author: Andrea Cervesato <[email protected]>
nit: I would still use some SPDX + copyright here.
include/lapi/syscalls/generate_arch.sh line 9
Quoted 2 lines
include/lapi/syscalls/generate_arch.sh new file +2
-0+ +KERNELSRC=$1
Generally all shell variables should be quoted to avoid problems with space. Feel free to do that before merge.
KERNELSRC="$1"
include/lapi/syscalls/generate_arch.sh line 14
Quoted 5 lines
include/lapi/syscalls/generate_arch.sh new file +5
-0+ +# to keep sorting in order +export LC_ALL=C + +if [ -z $KERNELSRC ]; then
Also here and on other places.
if [ -z "$KERNELSRC" ]; then
Try run script with:
KERNELSRC="foo bar"
[: aa: unexpected operator
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH v4 2/4] Add script to generate arch(s) dependant syscalls
Hi Petr,
Quoted 9 lines · Petr Vorel
Hi Andrea,
Quoted 5 lines
Add
generate_arch.shscript which can be used to generate arch(s) dependant syscalls file. The way it works is pretty simple: for each architecture defined into supported-arch.txt, compile kernel headers, extract the list of syscalls and generate a .in file containing all of them, associated with their own syscall's number.Nice improvement, thanks!
Quoted 8 lines
Quoted 3 lines
The way syscalls files are generated, passes through a C application which is automatically checking the availability of the syscalls in the user space environment.
This C application is in the Linux kernel and we only consume the result right?
If the C app was needed to be run for LTP, that would broke LTP cross compilation. (There are people compiling LTP with cross compilation, e.g. arm folks in yocto and Buildroot, riscv64 on openSUSE Tumbleweed).
The application is auto generated and compiled by this script during syscalls files generation. It's the same approach syscalls-table project is using https://github.com/hrw/syscalls-table/blob/master/scripts/update-tables.sh#L69
Quoted 6 lines
Quoted 6 lines
include/lapi/syscalls/generate_arch.sh new file +0
-0@@ -0,0 +1,205 @@
Quoted 8 lines
include/lapi/syscalls/generate_arch.sh line 7
Quoted 7 lines
include/lapi/syscalls/generate_arch.sh new file +7
-0+#!/bin/sh +# +# This is an adaptation of the update-tables.sh script, included in the +# syscalls-table project (https://github.com/hrw/syscalls-table) and released +# under the MIT license. +# +# Author: Andrea Cervesato <[email protected]>nit: I would still use some SPDX + copyright here.
Sure
Quoted 17 lines
include/lapi/syscalls/generate_arch.sh line 9
Quoted 3 lines
include/lapi/syscalls/generate_arch.sh new file +2
-0+ +KERNELSRC=$1Generally all shell variables should be quoted to avoid problems with space. Feel free to do that before merge.
KERNELSRC="$1"
include/lapi/syscalls/generate_arch.sh line 14
Quoted 5 lines
include/lapi/syscalls/generate_arch.sh new file +5
-0+ +# to keep sorting in order +export LC_ALL=C + +if [ -z $KERNELSRC ]; thenAlso here and on other places.
if [ -z "$KERNELSRC" ]; then
Quoted 7 lines
Try run script with:
KERNELSRC="foo bar"[: aa: unexpected operator
Kind regards,
Petr
Good point.
Andrea
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH v4 3/4 Delete obsolete strip_syscall.awk file
In reply to Andrea CervesatoFrom: Andrea Cervesato <[email protected]>
--- include/lapi/syscalls/strip_syscall.awk | 19 ------------------- 1 file changed, 19 deletions(-)
include/lapi/syscalls/strip_syscall.awk deleted +0 -19
@@ -1,19 +0,0 @@ -#!/usr/bin/awk -f -# -# Dumb script that can be used to strip all of the syscall information from -# the arch-respective unistd*.h. -# -# Examples: -# -# 1. Grab the i386 32-bit syscalls from unistd_32.h and put them in i386.in -# strip_syscall.awk arch/x86/include/asm/unistd_32.h > i386.in -# - -/^#define[[:space:]]+__NR_[0-9a-z]+/ { - - sub (/#define[[:space:]]+__NR_/, "", $0); - sub (/[[:space:]]*(\/\*.*)/, "", $0); - sub (/[[:space:]]+/, " ", $0); - - print -}
Signature · 5 lines
2.43.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH v4 3/4] Delete obsolete strip_syscall.awk file
Quoted 4 lines · Andrea Cervesato
From: Andrea Cervesato <[email protected]>
Signed-off-by Andrea Cervesato <[email protected]>
Quoted 41 lines
--- include/lapi/syscalls/strip_syscall.awk | 19 ------------------- 1 file changed, 19 deletions(-)include/lapi/syscalls/strip_syscall.awk deleted +0
-3@@ -1,19 +0,0 @@ -#!/usr/bin/awk -f -# -# Dumb script that can be used to strip all of the syscall informationfrom
include/lapi/syscalls/strip_syscall.awk deleted +0
-5-# the arch-respective unistd*.h. -# -# Examples: -# -# 1. Grab the i386 32-bit syscalls from unistd_32.h and put them ini386.in
include/lapi/syscalls/strip_syscall.awk deleted +0
-12-# strip_syscall.awk arch/x86/include/asm/unistd_32.h > i386.in -# - -/^#define[[:space:]]+__NR_[0-9a-z]+/ { - - sub (/#define[[:space:]]+__NR_/, "", $0); - sub (/[[:space:]]*(\/\*.*)/, "", $0); - sub (/[[:space:]]+/, " ", $0); - - print -} --2.43.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
Signature · 5 lines
Regards, Li Wang -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH v4 3/4] Delete obsolete strip_syscall.awk file
In reply to Andrea CervesatoHi Andrea,
obviously correct.
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH v4 4/4 Update syscalls files
In reply to Andrea CervesatoFrom: Andrea Cervesato <[email protected]>
Update syscalls .in files to the newest kernel development branch at commit 75b607fab38d.
--- include/lapi/syscalls/arc.in | 41 +- include/lapi/syscalls/arm.in | 819 ++++++++++++++++++----------------- include/lapi/syscalls/arm64.in | 18 +- include/lapi/syscalls/i386.in | 18 +- include/lapi/syscalls/ia64.in | 10 +- include/lapi/syscalls/loongarch64.in | 16 +- include/lapi/syscalls/mips64.in | 13 +- include/lapi/syscalls/mips64n32.in | 13 +- include/lapi/syscalls/mipso32.in | 19 +- include/lapi/syscalls/parisc.in | 373 +++++++++++++++- include/lapi/syscalls/powerpc.in | 19 +- include/lapi/syscalls/powerpc64.in | 47 +- include/lapi/syscalls/s390.in | 15 +- include/lapi/syscalls/s390x.in | 15 +- include/lapi/syscalls/sh.in | 15 +- include/lapi/syscalls/sparc.in | 14 +- include/lapi/syscalls/sparc64.in | 16 +- include/lapi/syscalls/x86_64.in | 51 +-- 18 files changed, 989 insertions(+), 543 deletions(-)
include/lapi/syscalls/arc.in +29 -12
@@ -23,7 +23,7 @@ epoll_ctl 21 epoll_pwait 22 dup 23 dup3 24 -fcntl 25 +fcntl64 25 inotify_init1 26 inotify_add_watch 27 inotify_rm_watch 28
@@ -41,10 +41,10 @@ umount2 39 mount 40 pivot_root 41 nfsservctl 42 -statfs 43 -fstatfs 44 -truncate 45 -ftruncate 46 +statfs64 43 +fstatfs64 44 +truncate64 45 +ftruncate64 46 fallocate 47 faccessat 48 chdir 49
@@ -60,7 +60,7 @@ vhangup 58 pipe2 59 quotactl 60 getdents64 61 -lseek 62 +llseek 62 read 63 write 64 readv 65
@@ -69,7 +69,7 @@ pread64 67 pwrite64 68 preadv 69 pwritev 70 -sendfile 71 +sendfile64 71 pselect6 72 ppoll 73 signalfd4 74
@@ -77,12 +77,11 @@ vmsplice 75 splice 76 tee 77 readlinkat 78 -fstatat 79 -fstat 80 +fstatat64 79 +fstat64 80 sync 81 fsync 82 fdatasync 83 -sync_file_range2 84 sync_file_range 84 timerfd_create 85 timerfd_settime 86
@@ -221,8 +220,8 @@ request_key 218 keyctl 219 clone 220 execve 221 -mmap 222 -fadvise64 223 +mmap2 222 +fadvise64_64 223 swapon 224 swapoff 225 mprotect 226
@@ -261,6 +260,11 @@ sendmmsg 269 process_vm_readv 270 process_vm_writev 271 kcmp 272 +finit_module 273 +sched_setattr 274 +sched_getattr 275 +renameat2 276 +seccomp 277 getrandom 278 memfd_create 279 bpf 280
@@ -314,12 +318,25 @@ close_range 436 openat2 437 pidfd_getfd 438 faccessat2 439 +process_madvise 440 epoll_pwait2 441 +mount_setattr 442 quotactl_fd 443 landlock_create_ruleset 444 landlock_add_rule 445 landlock_restrict_self 446 +process_mrelease 448 futex_waitv 449 +set_mempolicy_home_node 450 cachestat 451 fchmodat2 452 +map_shadow_stack 453 +futex_wake 454 +futex_wait 455 +futex_requeue 456 +statmount 457 +listmount 458 +lsm_get_self_attr 459 +lsm_set_self_attr 460 +lsm_list_modules 461 mseal 462
include/lapi/syscalls/arm.in +415 -404
819 lines not on this page · raw message
include/lapi/syscalls/arm64.in +15 -3
@@ -77,12 +77,11 @@ vmsplice 75 splice 76 tee 77 readlinkat 78 -fstatat 79 +newfstatat 79 fstat 80 sync 81 fsync 82 fdatasync 83 -sync_file_range2 84 sync_file_range 84 timerfd_create 85 timerfd_settime 86
@@ -294,13 +293,26 @@ close_range 436 openat2 437 pidfd_getfd 438 faccessat2 439 +process_madvise 440 epoll_pwait2 441 +mount_setattr 442 quotactl_fd 443 landlock_create_ruleset 444 landlock_add_rule 445 landlock_restrict_self 446 +memfd_secret 447 +process_mrelease 448 futex_waitv 449 +set_mempolicy_home_node 450 cachestat 451 fchmodat2 452 +map_shadow_stack 453 +futex_wake 454 +futex_wait 455 +futex_requeue 456 +statmount 457 +listmount 458 +lsm_get_self_attr 459 +lsm_set_self_attr 460 +lsm_list_modules 461 mseal 462 -_sysctl 1078
include/lapi/syscalls/i386.in +14 -4
@@ -111,7 +111,6 @@ olduname 109 iopl 110 vhangup 111 idle 112 -vm86old 113 wait4 114 swapoff 115 sysinfo 116
@@ -132,7 +131,6 @@ get_kernel_syms 130 quotactl 131 getpgid 132 fchdir 133 -bdflush 134 sysfs 135 personality 136 afs_syscall 137
@@ -164,7 +162,6 @@ nanosleep 162 mremap 163 setresuid 164 getresuid 165 -vm86 166 query_module 167 poll 168 nfsservctl 169
@@ -218,7 +215,6 @@ setfsgid32 216 pivot_root 217 mincore 218 madvise 219 -madvise1 219 getdents64 220 fcntl64 221 gettid 224
@@ -428,12 +424,26 @@ close_range 436 openat2 437 pidfd_getfd 438 faccessat2 439 +process_madvise 440 epoll_pwait2 441 +mount_setattr 442 quotactl_fd 443 landlock_create_ruleset 444 landlock_add_rule 445 landlock_restrict_self 446 +memfd_secret 447 +process_mrelease 448 futex_waitv 449 +set_mempolicy_home_node 450 cachestat 451 fchmodat2 452 +map_shadow_stack 453 +futex_wake 454 +futex_wait 455 +futex_requeue 456 +statmount 457 +listmount 458 +lsm_get_self_attr 459 +lsm_set_self_attr 460 +lsm_list_modules 461 mseal 462
include/lapi/syscalls/ia64.in +5 -5
@@ -18,6 +18,7 @@ lseek 1040 getpid 1041 getppid 1042 mount 1043 +umount 1044 umount2 1044 setuid 1045 getuid 1046
@@ -109,7 +110,6 @@ quotactl 1137 bdflush 1138 sysfs 1139 personality 1140 -afs_syscall 1141 setfsuid 1142 setfsgid 1143 getdents 1144
@@ -143,7 +143,6 @@ old_getpagesize 1171 mmap2 1172 pciconfig_read 1173 pciconfig_write 1174 -perfmonctl 1175 sigaltstack 1176 rt_sigaction 1177 rt_sigpending 1178
@@ -157,7 +156,6 @@ capget 1185 capset 1186 sendfile 1187 getpmsg 1188 -putpmsg 1189 socket 1190 bind 1191 connect 1192
@@ -237,7 +235,6 @@ mq_timedreceive 1265 mq_notify 1266 mq_getsetattr 1267 kexec_load 1268 -vserver 1269 waitid 1270 add_key 1271 request_key 1272
@@ -341,12 +338,15 @@ close_range 1460 openat2 1461 pidfd_getfd 1462 faccessat2 1463 +process_madvise 1464 epoll_pwait2 1465 +mount_setattr 1466 quotactl_fd 1467 landlock_create_ruleset 1468 landlock_add_rule 1469 landlock_restrict_self 1470 +process_mrelease 1472 futex_waitv 1473 +set_mempolicy_home_node 1474 cachestat 1475 fchmodat2 1476 -mseal 1486
include/lapi/syscalls/loongarch64.in +10 -6
@@ -36,7 +36,6 @@ mkdirat 34 unlinkat 35 symlinkat 36 linkat 37 -renameat 38 umount2 39 mount 40 pivot_root 41
@@ -77,12 +76,11 @@ vmsplice 75 splice 76 tee 77 readlinkat 78 -fstatat 79 +newfstatat 79 fstat 80 sync 81 fsync 82 fdatasync 83 -sync_file_range2 84 sync_file_range 84 timerfd_create 85 timerfd_settime 86
@@ -162,8 +160,6 @@ setgroups 159 uname 160 sethostname 161 setdomainname 162 -getrlimit 163 -setrlimit 164 getrusage 165 umask 166 prctl 167
@@ -301,10 +297,18 @@ quotactl_fd 443 landlock_create_ruleset 444 landlock_add_rule 445 landlock_restrict_self 446 -memfd_secret 447 process_mrelease 448 futex_waitv 449 set_mempolicy_home_node 450 cachestat 451 fchmodat2 452 +map_shadow_stack 453 +futex_wake 454 +futex_wait 455 +futex_requeue 456 +statmount 457 +listmount 458 +lsm_get_self_attr 459 +lsm_set_self_attr 460 +lsm_list_modules 461 mseal 462
include/lapi/syscalls/mips64.in +11 -2
@@ -175,7 +175,6 @@ nfsservctl 5173 getpmsg 5174 putpmsg 5175 afs_syscall 5176 -reserved177 5177 gettid 5178 readahead 5179 setxattr 5180
@@ -191,7 +190,6 @@ removexattr 5189 lremovexattr 5190 fremovexattr 5191 tkill 5192 -reserved193 5193 futex 5194 sched_setaffinity 5195 sched_getaffinity 5196
@@ -349,7 +347,18 @@ quotactl_fd 5443 landlock_create_ruleset 5444 landlock_add_rule 5445 landlock_restrict_self 5446 +process_mrelease 5448 futex_waitv 5449 +set_mempolicy_home_node 5450 cachestat 5451 fchmodat2 5452 +map_shadow_stack 5453 +futex_wake 5454 +futex_wait 5455 +futex_requeue 5456 +statmount 5457 +listmount 5458 +lsm_get_self_attr 5459 +lsm_set_self_attr 5460 +lsm_list_modules 5461 mseal 5462
include/lapi/syscalls/mips64n32.in +11 -2
@@ -175,7 +175,6 @@ nfsservctl 6173 getpmsg 6174 putpmsg 6175 afs_syscall 6176 -reserved177 6177 gettid 6178 readahead 6179 setxattr 6180
@@ -191,7 +190,6 @@ removexattr 6189 lremovexattr 6190 fremovexattr 6191 tkill 6192 -reserved193 6193 futex 6194 sched_setaffinity 6195 sched_getaffinity 6196
@@ -373,7 +371,18 @@ quotactl_fd 6443 landlock_create_ruleset 6444 landlock_add_rule 6445 landlock_restrict_self 6446 +process_mrelease 6448 futex_waitv 6449 +set_mempolicy_home_node 6450 cachestat 6451 fchmodat2 6452 +map_shadow_stack 6453 +futex_wake 6454 +futex_wait 6455 +futex_requeue 6456 +statmount 6457 +listmount 6458 +lsm_get_self_attr 6459 +lsm_set_self_attr 6460 +lsm_list_modules 6461 mseal 6462
include/lapi/syscalls/mipso32.in +11 -8
@@ -16,7 +16,6 @@ mknod 4014 chmod 4015 lchown 4016 break 4017 -unused18 4018 lseek 4019 getpid 4020 mount 4021
@@ -26,7 +25,6 @@ getuid 4024 stime 4025 ptrace 4026 alarm 4027 -unused28 4028 pause 4029 utime 4030 stty 4031
@@ -80,9 +78,7 @@ gettimeofday 4078 settimeofday 4079 getgroups 4080 setgroups 4081 -reserved82 4082 symlink 4083 -unused84 4084 readlink 4085 uselib 4086 swapon 4087
@@ -111,7 +107,6 @@ unused109 4109 iopl 4110 vhangup 4111 idle 4112 -vm86 4113 wait4 4114 swapoff 4115 sysinfo 4116
@@ -132,7 +127,6 @@ get_kernel_syms 4130 quotactl 4131 getpgid 4132 fchdir 4133 -bdflush 4134 sysfs 4135 personality 4136 afs_syscall 4137
@@ -148,7 +142,6 @@ writev 4146 cacheflush 4147 cachectl 4148 sysmips 4149 -unused150 4150 getsid 4151 fdatasync 4152 _sysctl 4153
@@ -219,7 +212,6 @@ mincore 4217 madvise 4218 getdents64 4219 fcntl64 4220 -reserved221 4221 gettid 4222 readahead 4223 setxattr 4224
@@ -419,7 +411,18 @@ quotactl_fd 4443 landlock_create_ruleset 4444 landlock_add_rule 4445 landlock_restrict_self 4446 +process_mrelease 4448 futex_waitv 4449 +set_mempolicy_home_node 4450 cachestat 4451 fchmodat2 4452 +map_shadow_stack 4453 +futex_wake 4454 +futex_wait 4455 +futex_requeue 4456 +statmount 4457 +listmount 4458 +lsm_get_self_attr 4459 +lsm_set_self_attr 4460 +lsm_list_modules 4461 mseal 4462
include/lapi/syscalls/parisc.in +359 -14
406 lines not on this page · raw message
include/lapi/syscalls/powerpc.in +13 -6
@@ -111,7 +111,6 @@ olduname 109 iopl 110 vhangup 111 idle 112 -vm86 113 wait4 114 swapoff 115 sysinfo 116
@@ -132,7 +131,6 @@ get_kernel_syms 130 quotactl 131 getpgid 132 fchdir 133 -bdflush 134 sysfs 135 personality 136 afs_syscall 137
@@ -199,7 +197,6 @@ fstat64 197 pciconfig_read 198 pciconfig_write 199 pciconfig_iobase 200 -multiplexer 201 getdents64 202 pivot_root 203 fcntl64 204
@@ -253,7 +250,6 @@ statfs64 252 fstatfs64 253 fadvise64_64 254 rtas 255 -sys_debug_setcontext 256 migrate_pages 258 mbind 259 get_mempolicy 260
@@ -287,7 +283,6 @@ mkdirat 287 mknodat 288 fchownat 289 futimesat 290 -newfstatat 291 fstatat64 291 unlinkat 292 renameat 293
@@ -374,7 +369,6 @@ pkey_free 385 pkey_mprotect 386 rseq 387 io_pgetevents 388 -semtimedop 392 semget 393 semctl 394 shmget 395
@@ -421,12 +415,25 @@ close_range 436 openat2 437 pidfd_getfd 438 faccessat2 439 +process_madvise 440 epoll_pwait2 441 +mount_setattr 442 quotactl_fd 443 landlock_create_ruleset 444 landlock_add_rule 445 landlock_restrict_self 446 +process_mrelease 448 futex_waitv 449 +set_mempolicy_home_node 450 cachestat 451 fchmodat2 452 +map_shadow_stack 453 +futex_wake 454 +futex_wait 455 +futex_requeue 456 +statmount 457 +listmount 458 +lsm_get_self_attr 459 +lsm_set_self_attr 460 +lsm_list_modules 461 mseal 462
include/lapi/syscalls/powerpc64.in +13 -34
107 lines not on this page · raw message
include/lapi/syscalls/s390.in +14 -1
@@ -112,7 +112,6 @@ get_kernel_syms 130 quotactl 131 getpgid 132 fchdir 133 -bdflush 134 sysfs 135 personality 136 afs_syscall 137
@@ -408,12 +407,26 @@ close_range 436 openat2 437 pidfd_getfd 438 faccessat2 439 +process_madvise 440 epoll_pwait2 441 +mount_setattr 442 quotactl_fd 443 landlock_create_ruleset 444 landlock_add_rule 445 landlock_restrict_self 446 +memfd_secret 447 +process_mrelease 448 futex_waitv 449 +set_mempolicy_home_node 450 cachestat 451 fchmodat2 452 +map_shadow_stack 453 +futex_wake 454 +futex_wait 455 +futex_requeue 456 +statmount 457 +listmount 458 +lsm_get_self_attr 459 +lsm_set_self_attr 460 +lsm_list_modules 461 mseal 462
include/lapi/syscalls/s390x.in +14 -1
@@ -96,7 +96,6 @@ get_kernel_syms 130 quotactl 131 getpgid 132 fchdir 133 -bdflush 134 sysfs 135 personality 136 afs_syscall 137
@@ -356,12 +355,26 @@ close_range 436 openat2 437 pidfd_getfd 438 faccessat2 439 +process_madvise 440 epoll_pwait2 441 +mount_setattr 442 quotactl_fd 443 landlock_create_ruleset 444 landlock_add_rule 445 landlock_restrict_self 446 +memfd_secret 447 +process_mrelease 448 futex_waitv 449 +set_mempolicy_home_node 450 cachestat 451 fchmodat2 452 +map_shadow_stack 453 +futex_wake 454 +futex_wait 455 +futex_requeue 456 +statmount 457 +listmount 458 +lsm_get_self_attr 459 +lsm_set_self_attr 460 +lsm_list_modules 461 mseal 462
include/lapi/syscalls/sh.in +14 -1
@@ -115,7 +115,6 @@ delete_module 129 quotactl 131 getpgid 132 fchdir 133 -bdflush 134 sysfs 135 personality 136 setfsuid 138
@@ -357,6 +356,7 @@ pkey_mprotect 384 pkey_alloc 385 pkey_free 386 rseq 387 +sync_file_range2 388 semget 393 semctl 394 shmget 395
@@ -402,12 +402,25 @@ close_range 436 openat2 437 pidfd_getfd 438 faccessat2 439 +process_madvise 440 epoll_pwait2 441 +mount_setattr 442 quotactl_fd 443 landlock_create_ruleset 444 landlock_add_rule 445 landlock_restrict_self 446 +process_mrelease 448 futex_waitv 449 +set_mempolicy_home_node 450 cachestat 451 fchmodat2 452 +map_shadow_stack 453 +futex_wake 454 +futex_wait 455 +futex_requeue 456 +statmount 457 +listmount 458 +lsm_get_self_attr 459 +lsm_set_self_attr 460 +lsm_list_modules 461 mseal 462
include/lapi/syscalls/sparc.in +13 -1
@@ -221,7 +221,6 @@ create_module 221 delete_module 222 get_kernel_syms 223 getpgid 224 -bdflush 225 sysfs 226 afs_syscall 227 setfsuid 228
@@ -407,12 +406,25 @@ close_range 436 openat2 437 pidfd_getfd 438 faccessat2 439 +process_madvise 440 epoll_pwait2 441 +mount_setattr 442 quotactl_fd 443 landlock_create_ruleset 444 landlock_add_rule 445 landlock_restrict_self 446 +process_mrelease 448 futex_waitv 449 +set_mempolicy_home_node 450 cachestat 451 fchmodat2 452 +map_shadow_stack 453 +futex_wake 454 +futex_wait 455 +futex_requeue 456 +statmount 457 +listmount 458 +lsm_get_self_attr 459 +lsm_set_self_attr 460 +lsm_list_modules 461 mseal 462
include/lapi/syscalls/sparc64.in +13 -3
@@ -29,8 +29,6 @@ alarm 27 sigaltstack 28 pause 29 utime 30 -lchown32 31 -fchown32 32 access 33 nice 34 sync 36
@@ -206,7 +204,6 @@ create_module 221 delete_module 222 get_kernel_syms 223 getpgid 224 -bdflush 225 sysfs 226 afs_syscall 227 setfsuid 228
@@ -372,12 +369,25 @@ close_range 436 openat2 437 pidfd_getfd 438 faccessat2 439 +process_madvise 440 epoll_pwait2 441 +mount_setattr 442 quotactl_fd 443 landlock_create_ruleset 444 landlock_add_rule 445 landlock_restrict_self 446 +process_mrelease 448 futex_waitv 449 +set_mempolicy_home_node 450 cachestat 451 fchmodat2 452 +map_shadow_stack 453 +futex_wake 454 +futex_wait 455 +futex_requeue 456 +statmount 457 +listmount 458 +lsm_get_self_attr 459 +lsm_set_self_attr 460 +lsm_list_modules 461 mseal 462
include/lapi/syscalls/x86_64.in +15 -36
69 lines not on this page · raw message
Signature · 5 lines
2.43.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH v4 4/4] Update syscalls files
Andrea Cervesato <[email protected]> wrote:
Quoted 8 lines
--- include/lapi/syscalls/arc.in | 41 +- include/lapi/syscalls/arm.in | 819 ++++++++++++++++++----------------- include/lapi/syscalls/arm64.in | 18 +- include/lapi/syscalls/i386.in | 18 +- include/lapi/syscalls/ia64.in | 10 +-
The mainline kernel has dropped support for Itanium IA-64 from kernel-v6.7.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cf8e8658100d4eae80ce9b21f7a81cb024dd5057
I'm wondering if we should remove IA64 support for LTP as well.
But whatever LTP keeps the code for IA64 or not, maybe we don't need these update for ia64, right?
Signature · 5 lines
Regards, Li Wang -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH v4 4/4] Update syscalls files
Hi All,
Quoted 17 lines · Li Wang
Andrea Cervesato <[email protected]> wrote:
Signed-off-by Andrea Cervesato <[email protected]>Quoted 8 lines
--- include/lapi/syscalls/arc.in | 41 +- include/lapi/syscalls/arm.in | 819 ++++++++++++++++++----------------- include/lapi/syscalls/arm64.in | 18 +- include/lapi/syscalls/i386.in | 18 +- include/lapi/syscalls/ia64.in | 10 +-The mainline kernel has dropped support for Itanium IA-64 from kernel-v6.7 .
Quoted 7 lines
I'm wondering if we should remove IA64 support for LTP as well.
But whatever LTP keeps the code for IA64 or not, maybe we don't need these update for ia64, right?
BTW, The below link here may not be directly relevant to your patch, but I think of we have discussed cleaning up the IA64 code in LTP before.
https://lists.linux.it/pipermail/ltp/2024-January/036611.html
Signature · 5 lines
Regards, Li Wang -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH v4 4/4] Update syscalls files
Hi Andrea, Li, all,
Quoted 25 lines
Hi All,
Quoted 19 lines · Li Wang
Andrea Cervesato <[email protected]> wrote:
Signed-off-by Andrea Cervesato <[email protected]>Quoted 7 lines
--- include/lapi/syscalls/arc.in | 41 +- include/lapi/syscalls/arm.in | 819 ++++++++++++++++++----------------- include/lapi/syscalls/arm64.in | 18 +- include/lapi/syscalls/i386.in | 18 +- include/lapi/syscalls/ia64.in | 10 +-The mainline kernel has dropped support for Itanium IA-64 from kernel-v6.7 .
I'm wondering if we should remove IA64 support for LTP as well.
Quoted 8 lines
Quoted 2 lines
But whatever LTP keeps the code for IA64 or not, maybe we don't need these update for ia64, right?
BTW, The below link here may not be directly relevant to your patch, but I think of we have discussed cleaning up the IA64 code in LTP before.
https://lists.linux.it/pipermail/ltp/2024-January/036611.html
Yes, it's time to drop IA64 code (as a separate effort, there are #ifdef).
It would be cleaner if you instead of modifying ia64.in just remove the file in a separate commit before (unrelated change). But I'm ok also with single commit if you're not going to send another version.
I also wonder if we should add PA-RISC, HP stop supporting servers in 2013 [1]. Sure, kernel is still contains this arch, but I doubt anybody uses LTP for testing. The arch is IMHO not supported directly by any distro (it was dropped from Debian 6 squeeze [2], which was released 2011 and EOL 2016), moved to Debian ports [3]. The community is still somehow active, but few people just fight to fix compilation issues [4].
Sure, it's jut a single file (parisc.in) and we have other legacy architectures which are passing away but not yet removed from kernel tree due few people using them (at least sh, s390, sparc). Having these files we suggest somebody is actually taking care about these archs. But as I said, probably nobody is using LTP to test them, thus many tests will be broken.
[1] https://en.wikipedia.org/wiki/PA-RISC
[2] https://www.debian.org/ports/hppa/
[3] https://lists.debian.org/debian-hppa/
[4] https://lists.debian.org/debian-hppa/2024/09/threads.html
Also, this 4th patch also does not apply. Unlike first commit there are more conflicts (applying of course on the top of the 3 previous patches):
Description: [v4,4/4] Update syscalls files
Applying: Update syscalls files
error: patch failed: include/lapi/syscalls/arm.in:1
error: include/lapi/syscalls/arm.in: patch does not apply
error: patch failed: include/lapi/syscalls/arm64.in:294
error: include/lapi/syscalls/arm64.in: patch does not apply
error: patch failed: include/lapi/syscalls/ia64.in:341
error: include/lapi/syscalls/ia64.in: patch does not apply
error: patch failed: include/lapi/syscalls/x86_64.in:349
error: include/lapi/syscalls/x86_64.in: patch does not apply Patch failed at 0001 Update syscalls files
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH v4 4/4] Update syscalls files
Hi Petr,
Quoted 23 lines · Petr Vorel
Hi Andrea, Li, all,
Quoted 20 lines
Hi All,
Quoted 17 lines · Li Wang
Andrea Cervesato <[email protected]> wrote:
Signed-off-by Andrea Cervesato <[email protected]>Quoted 7 lines
--- include/lapi/syscalls/arc.in | 41 +- include/lapi/syscalls/arm.in | 819 ++++++++++++++++++----------------- include/lapi/syscalls/arm64.in | 18 +- include/lapi/syscalls/i386.in | 18 +- include/lapi/syscalls/ia64.in | 10 +-The mainline kernel has dropped support for Itanium IA-64 from kernel-v6.7 .
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cf8e8658100d4eae80ce9b21f7a81cb024dd5057
I'm wondering if we should remove IA64 support for LTP as well. But whatever LTP keeps the code for IA64 or not, maybe we don't need these update for ia64, right?
Quoted 8 lines
Quoted 3 lines
BTW, The below link here may not be directly relevant to your patch, but I think of we have discussed cleaning up the IA64 code in LTP before.
https://lists.linux.it/pipermail/ltp/2024-January/036611.htmlYes, it's time to drop IA64 code (as a separate effort, there are #ifdef).
It would be cleaner if you instead of modifying ia64.in just remove the file in a separate commit before (unrelated change). But I'm ok also with single commit if you're not going to send another version.
Ok, now I see the point. Well, we can make a decision around it then, but it will probably need more people involved.
Quoted 21 lines
I also wonder if we should add PA-RISC, HP stop supporting servers in 2013 [1]. Sure, kernel is still contains this arch, but I doubt anybody uses LTP for testing. The arch is IMHO not supported directly by any distro (it was dropped from Debian 6 squeeze [2], which was released 2011 and EOL 2016), moved to Debian ports [3]. The community is still somehow active, but few people just fight to fix compilation issues [4].
Sure, it's jut a single file (parisc.in) and we have other legacy architectures which are passing away but not yet removed from kernel tree due few people using them (at least sh, s390, sparc). Having these files we suggest somebody is actually taking care about these archs. But as I said, probably nobody is using LTP to test them, thus many tests will be broken.
[1] https://en.wikipedia.org/wiki/PA-RISC
[2] https://www.debian.org/ports/hppa/
[3] https://lists.debian.org/debian-hppa/
[4] https://lists.debian.org/debian-hppa/2024/09/threads.htmlAlso, this 4th patch also does not apply. Unlike first commit there are more conflicts (applying of course on the top of the 3 previous patches):
Quoted 11 lines
Description: [v4,4/4] Update syscalls files
Applying: Update syscalls files
error: patch failed:include/lapi/syscalls/arm.in:1
error:include/lapi/syscalls/arm.in: patch does not apply
error: patch failed:include/lapi/syscalls/arm64.in:294
error:include/lapi/syscalls/arm64.in: patch does not apply
error: patch failed:include/lapi/syscalls/ia64.in:341
error:include/lapi/syscalls/ia64.in: patch does not apply
error: patch failed:include/lapi/syscalls/x86_64.in:349
error:include/lapi/syscalls/x86_64.in: patch does not apply Patch failed at 0001 Update syscalls files
This is really strange. It's not happening for me even with the latest HEAD. Did you rebase first?
Quoted 2 lines
Kind regards,
Petr
Andrea
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH v4 4/4] Update syscalls files
Hi Andrea,
Quoted 1 line
Hi Petr,
...
Quoted 14 lines
Quoted 14 lines
Also, this 4th patch also does not apply. Unlike first commit there are more conflicts (applying of course on the top of the 3 previous patches):
Description: [v4,4/4] Update syscalls files
Applying: Update syscalls files
error: patch failed:include/lapi/syscalls/arm.in:1
error:include/lapi/syscalls/arm.in: patch does not apply
error: patch failed:include/lapi/syscalls/arm64.in:294
error:include/lapi/syscalls/arm64.in: patch does not apply
error: patch failed:include/lapi/syscalls/ia64.in:341
error:include/lapi/syscalls/ia64.in: patch does not apply
error: patch failed:include/lapi/syscalls/x86_64.in:349
error:include/lapi/syscalls/x86_64.in: patch does not apply Patch failed at 0001 Update syscalls files
Quoted 2 lines
This is really strange. It's not happening for me even with the latest HEAD. Did you rebase first?
I was applying to the master (as I wrote first I need to adjust first patch which also didn't apply, but that's just a single line). Don't bother if the problem is really on my side. But pushing the patchset to your fork would help me to actually test the code.
Kind regards,
Petr
Quoted 3 lines
Quoted 2 lines
Kind regards,
PetrAndrea
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH v4 4/4] Update syscalls files
Quoted 17 lines · Petr Vorel
Hi Andrea,
Quoted 1 line
Hi Petr,
...
Quoted 13 lines
Quoted 13 lines
Also, this 4th patch also does not apply. Unlike first commit there are more conflicts (applying of course on the top of the 3 previous patches):
Description: [v4,4/4] Update syscalls files
Applying: Update syscalls files
error: patch failed:include/lapi/syscalls/arm.in:1
error:include/lapi/syscalls/arm.in: patch does not apply
error: patch failed:include/lapi/syscalls/arm64.in:294
error:include/lapi/syscalls/arm64.in: patch does not apply
error: patch failed:include/lapi/syscalls/ia64.in:341
error:include/lapi/syscalls/ia64.in: patch does not apply
error: patch failed:include/lapi/syscalls/x86_64.in:349
error:include/lapi/syscalls/x86_64.in: patch does not apply Patch failed at 0001 Update syscalls files
Quoted 6 lines
Quoted 2 lines
This is really strange. It's not happening for me even with the latest HEAD. Did you rebase first?
I was applying to the master (as I wrote first I need to adjust first patch which also didn't apply, but that's just a single line). Don't bother if the problem is really on my side. But pushing the patchset to your fork would help me to actually test the code.
You can check it out here: https://github.com/acerv/ltp/actions/runs/11480881574
Andrea
Quoted 7 lines
Kind regards,
PetrQuoted 3 lines
Quoted 2 lines
Kind regards,
PetrAndrea
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH v4 4/4] Update syscalls files
Hi Andrea,
Quoted 20 lines · Petr Vorel
Quoted 19 lines
Hi Andrea,
Quoted 1 line
Hi Petr,
...
Quoted 15 lines
Quoted 5 lines
Also, this 4th patch also does not apply. Unlike first commit there are more conflicts (applying of course on the top of the 3 previous patches):
Description: [v4,4/4] Update syscalls files
Applying: Update syscalls files
error: patch failed:include/lapi/syscalls/arm.in:1Quoted 8 lines
error:
include/lapi/syscalls/arm.in: patch does not apply
error: patch failed:include/lapi/syscalls/arm64.in:294
error:include/lapi/syscalls/arm64.in: patch does not apply
error: patch failed:include/lapi/syscalls/ia64.in:341
error:include/lapi/syscalls/ia64.in: patch does not apply
error: patch failed:include/lapi/syscalls/x86_64.in:349
error:include/lapi/syscalls/x86_64.in: patch does not apply Patch failed at 0001 Update syscalls filesThis is really strange. It's not happening for me even with the latest HEAD. Did you rebase first?
Quoted 7 lines
Quoted 4 lines
I was applying to the master (as I wrote first I need to adjust first patch which also didn't apply, but that's just a single line). Don't bother if the problem is really on my side. But pushing the patchset to your fork would help me to actually test the code.
You can check it out here:
https://github.com/acerv/ltp/actions/runs/11480881574
thanks, but the run points to the b4/generate_syscalls branch [1], which is not the same as you post as v4. It has 4 commits, but 1st of them "Automatically generate syscalls.h" [2] is a cover letter without change. And it does not have the 4th commit [3] which I was unable to apply (the error reported, it's in few lines above in the email).
Anyway, you got a review from Li, thus feel free just merge what you sent as v4, no need to resent a new version just because it's not applicable.
I try to have a quick look on v4, but you don't have to wait for me.
Kind regards,
Petr
[1] https://github.com/acerv/ltp/commits/refs/heads/b4/generate_syscalls/
[2] https://github.com/acerv/ltp/commit/7544e1faa28cced4fdd6c47dc81ee5b84fb2ae01
[3] https://lore.kernel.org/ltp/[email protected]/
Quoted 9 lines
Andrea
Quoted 6 lines
Kind regards,
PetrQuoted 3 lines
Quoted 2 lines
Kind regards,
PetrAndrea
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH v4 4/4] Update syscalls files
In reply to Li WangHi Li,
Quoted 14 lines · Li Wang
Andrea Cervesato <[email protected]> wrote:
Signed-off-by: Andrea Cervesato <[email protected]> --- include/lapi/syscalls/arc.in <http://arc.in> | 41 +- include/lapi/syscalls/arm.in <http://arm.in> | 819 ++++++++++++++++++----------------- include/lapi/syscalls/arm64.in <http://arm64.in> | 18 +- include/lapi/syscalls/i386.in <http://i386.in> | 18 +- include/lapi/syscalls/ia64.in <http://ia64.in> | 10 +-
Quoted 7 lines
The mainline kernel has dropped support for Itanium IA-64 from kernel-v6.7.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cf8e8658100d4eae80ce9b21f7a81cb024dd5057I'm wondering if we should remove IA64 support for LTP as well.
But whatever LTP keeps the code for IA64 or not, maybe we don't need these update for ia64, right?
I don't know if it's a good idea, since we still support older kernel versions.
Quoted 5 lines
Signature · 3 lines
-- Regards, Li Wang
Andrea
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp