scsi: target: core: Fix null-ptr-deref in target_alloc_device()
Subsystems (2)
PATCH 1/1 scsi: target: core: Fix null-ptr-deref in target_alloc_device()
There is a null-ptr-deref issue reported by kasan:
BUG: KASAN: null-ptr-deref in target_alloc_device+0xbc4/0xbe0 [target_core_mod] ... kasan_report+0xb9/0xf0 target_alloc_device+0xbc4/0xbe0 [target_core_mod] core_dev_setup_virtual_lun0+0xef/0x1f0 [target_core_mod] target_core_init_configfs+0x205/0x420 [target_core_mod] do_one_initcall+0xdd/0x4e0
...
entry_SYSCALL_64_after_hwframe+0x76/0x7e
In target_alloc_device(), if allocing memory for dev queues fails, then dev will be freed by dev->transport->free_device(), but dev->transport is not initialized at that time, which will lead to a null pointer reference problem.
Fixing this bug by freeing dev with hba->backend->ops->free_device().
--- drivers/target/target_core_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/target/target_core_device.c +1 -1
@@ -691,7 +691,7 @@ struct se_device *target_alloc_device(struct se_hba *hba, const char *name) dev->queues =kcalloc (nr_cpu_ids,sizeof (*dev->queues),GFP_KERNEL );if (!dev->queues) { - dev->transport->free_device (dev); + hba->backend->ops->free_device (dev);return NULL ; }
Signature · 1 line
2.17.1
Quoted 30 lines · Wang Hai
There is a null-ptr-deref issue reported by kasan:
BUG: KASAN: null-ptr-deref in target_alloc_device+0xbc4/0xbe0 [target_core_mod] ... kasan_report+0xb9/0xf0 target_alloc_device+0xbc4/0xbe0 [target_core_mod] core_dev_setup_virtual_lun0+0xef/0x1f0 [target_core_mod] target_core_init_configfs+0x205/0x420 [target_core_mod] do_one_initcall+0xdd/0x4e0...
entry_SYSCALL_64_after_hwframe+0x76/0x7eIn
target_alloc_device(), if allocing memory for dev queues fails, then dev will be freed bydev->transport->free_device(), butdev->transportis not initialized at that time, which will lead to a null pointer reference problem.Fixing this bug by freeing dev with
hba->backend->ops->free_device().Fixes 1526d9f10c61 ("scsi: target: Make state_list per CPU")Signed-off-by Wang Hai <[email protected]>--- drivers/target/target_core_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/target/target_core_device.c +0
-0
drivers/target/target_core_device.c struct se_device *target_alloc_device(struct se_hba *hba, const char *name) · line 697
Quoted 8 lines
drivers/target/target_core_device.c +1
-1@@ -691,7 +691,7 @@ struct se_device *target_alloc_device(struct se_hba *hba, const char *name) dev->queues =kcalloc (nr_cpu_ids,sizeof (*dev->queues),GFP_KERNEL );if (!dev->queues) { - dev->transport->free_device (dev); + hba->backend->ops->free_device (dev);return NULL ; }
Thanks.
Martin K. Petersen
AppliedQuoted 9 lines · Wang Hai
There is a null-ptr-deref issue reported by kasan:
BUG: KASAN: null-ptr-deref in target_alloc_device+0xbc4/0xbe0 [target_core_mod] ... kasan_report+0xb9/0xf0 target_alloc_device+0xbc4/0xbe0 [target_core_mod] core_dev_setup_virtual_lun0+0xef/0x1f0 [target_core_mod] target_core_init_configfs+0x205/0x420 [target_core_mod] do_one_initcall+0xdd/0x4e0
Quoted 4 lines
...
entry_SYSCALL_64_after_hwframe+0x76/0x7e[...]
Applied to 6.12/scsi-fixes, thanks!
[1/1] scsi: target: core: Fix null-ptr-deref in target_alloc_device()
https://git.kernel.org/mkp/scsi/c/fca6caeb4a61
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering