Skip to contentSkip to conversation

staging: vt6656: Remove unused driver

PATCH New Philipp Hortmann 1 participant 1 message Oct 12, 2024 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: vt6656: Remove unused driver

Forest Bond contributed this driver in 2009.

The following reasons lead to the removal:
- This driver generates maintenance workload
- This driver has a maximum 54MBit/s as it supports only 802.11 b/g. Peak throughput is 3MBytes/s.
- ping times can be 17ms are often above 500ms and worst case 22 seconds. One other user does not see such long ping times using a rasperry pi.

I suggest deleting the driver as it no longer meets current expectations for throuput.

---
Artifacts of vt6656 in MAINTAINERS are removed with this patch. Removed artifacts in Makefile and Kconfig.

---
 MAINTAINERS                       |    5 -
 drivers/staging/Kconfig           |    2 -
 drivers/staging/Makefile          |    1 -
 drivers/staging/vt6656/Kconfig    |    7 -
 drivers/staging/vt6656/Makefile   |   15 -
 drivers/staging/vt6656/TODO       |   17 -
 drivers/staging/vt6656/baseband.c |  455 ------------
 drivers/staging/vt6656/baseband.h |   75 --
 drivers/staging/vt6656/card.c     |  456 ------------
 drivers/staging/vt6656/card.h     |   44 --
 drivers/staging/vt6656/channel.c  |   77 --
 drivers/staging/vt6656/channel.h  |   21 -
 drivers/staging/vt6656/desc.h     |   91 ---
 drivers/staging/vt6656/device.h   |  386 ----------
 drivers/staging/vt6656/key.c      |  142 ----
 drivers/staging/vt6656/key.h      |   40 -
 drivers/staging/vt6656/mac.c      |  183 -----
 drivers/staging/vt6656/mac.h      |  373 ----------
 drivers/staging/vt6656/main_usb.c | 1121 -----------------------------
 drivers/staging/vt6656/power.c    |  112 ---
 drivers/staging/vt6656/power.h    |   23 -
 drivers/staging/vt6656/rf.c       |  443 ------------
 drivers/staging/vt6656/rf.h       |   46 --
 drivers/staging/vt6656/rxtx.c     |  730 -------------------
 drivers/staging/vt6656/rxtx.h     |  178 -----
 drivers/staging/vt6656/usbpipe.c  |  506 -------------
 drivers/staging/vt6656/usbpipe.h  |   67 --
 drivers/staging/vt6656/wcmd.c     |  185 -----
 drivers/staging/vt6656/wcmd.h     |   48 --
 29 files changed, 5849 deletions(-)
 delete mode 100644 drivers/staging/vt6656/Kconfig
 delete mode 100644 drivers/staging/vt6656/Makefile
 delete mode 100644 drivers/staging/vt6656/TODO
 delete mode 100644 drivers/staging/vt6656/baseband.c
 delete mode 100644 drivers/staging/vt6656/baseband.h
 delete mode 100644 drivers/staging/vt6656/card.c
 delete mode 100644 drivers/staging/vt6656/card.h
 delete mode 100644 drivers/staging/vt6656/channel.c
 delete mode 100644 drivers/staging/vt6656/channel.h
 delete mode 100644 drivers/staging/vt6656/desc.h
 delete mode 100644 drivers/staging/vt6656/device.h
 delete mode 100644 drivers/staging/vt6656/key.c
 delete mode 100644 drivers/staging/vt6656/key.h
 delete mode 100644 drivers/staging/vt6656/mac.c
 delete mode 100644 drivers/staging/vt6656/mac.h
 delete mode 100644 drivers/staging/vt6656/main_usb.c
 delete mode 100644 drivers/staging/vt6656/power.c
 delete mode 100644 drivers/staging/vt6656/power.h
 delete mode 100644 drivers/staging/vt6656/rf.c
 delete mode 100644 drivers/staging/vt6656/rf.h
 delete mode 100644 drivers/staging/vt6656/rxtx.c
 delete mode 100644 drivers/staging/vt6656/rxtx.h
 delete mode 100644 drivers/staging/vt6656/usbpipe.c
 delete mode 100644 drivers/staging/vt6656/usbpipe.h
 delete mode 100644 drivers/staging/vt6656/wcmd.c
 delete mode 100644 drivers/staging/vt6656/wcmd.h
MAINTAINERS +0 -5
index 0f87adc74bb9..89e71b6fb431 100644
@@ -21982,11 +21982,6 @@ L:	[email protected]
 S:	Maintained
 F:	drivers/staging/sm750fb/
 
-STAGING - VIA VT665X DRIVERS
-M:	Philipp Hortmann <[email protected]>
-S:	Odd Fixes
-F:	drivers/staging/vt665?/
-
 STAGING SUBSYSTEM
 M:	Greg Kroah-Hartman <[email protected]>
 L:	[email protected]
drivers/staging/Kconfig +0 -2
index 2493e150fbbd..b7f089e071cc 100644
@@ -32,8 +32,6 @@ source "drivers/staging/rtl8712/Kconfig"
 
 source "drivers/staging/octeon/Kconfig"
 
-source "drivers/staging/vt6656/Kconfig"
-
 source "drivers/staging/iio/Kconfig"
 
 source "drivers/staging/sm750fb/Kconfig"
drivers/staging/Makefile +0 -1
index add5e887e451..40dea97d2090 100644
@@ -6,7 +6,6 @@ obj-$(CONFIG_FB_OLPC_DCON)	+= olpc_dcon/
 obj-$(CONFIG_RTL8723BS)		+= rtl8723bs/
 obj-$(CONFIG_R8712U)		+= rtl8712/
 obj-$(CONFIG_OCTEON_ETHERNET)	+= octeon/
-obj-$(CONFIG_VT6656)		+= vt6656/
 obj-$(CONFIG_VME_BUS)		+= vme_user/
 obj-$(CONFIG_IIO)		+= iio/
 obj-$(CONFIG_FB_SM750)		+= sm750fb/
drivers/staging/vt6656/Kconfig deleted +0 -7
deleted file mode 100644
index f52a3f1d9a2e..000000000000
@@ -1,7 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-config VT6656
-	tristate "VIA Technologies VT6656 support"
-	depends on MAC80211 && USB && WLAN && m
-	select FW_LOADER
-	help
-	  This is a vendor-written driver for VIA VT6656.
drivers/staging/vt6656/Makefile deleted +0 -15
deleted file mode 100644
index f696a9d7a143..000000000000
@@ -1,15 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-
-vt6656_stage-y +=	main_usb.o \
-			card.o  \
-			mac.o   \
-			baseband.o \
-			wcmd.o\
-			rxtx.o \
-			power.o \
-			key.o \
-			rf.o \
-			usbpipe.o \
-			channel.o
-
-obj-$(CONFIG_VT6656) +=	vt6656_stage.o
drivers/staging/vt6656/TODO deleted +0 -17
deleted file mode 100644
index 1edea5e8698b..000000000000
@@ -1,17 +0,0 @@
-TODO:
-- remove __cplusplus ifdefs -- done
-- remove kernel version compatibility wrappers
-- remove support for older wireless extensions
-- prepare for merge with vt6655 driver:
-  - remove PRINT_K() macro
-  - split rf.c
-  - abstract VT3184 chipset specific code
-- add common vt665x infrastructure
-- kill ttype.h -- done
-- switch to use MAC80211
-- use kernel coding style
-- sparse fixes
-- integrate with drivers/net/wireless
-
-Please send any patches to Greg Kroah-Hartman <[email protected]>
-and Philipp Hortmann <[email protected]>.
drivers/staging/vt6656/baseband.c deleted +0 -455

455 lines not on this page · raw message

drivers/staging/vt6656/baseband.h deleted +0 -75

75 lines not on this page · raw message

drivers/staging/vt6656/card.c deleted +0 -456

456 lines not on this page · raw message

drivers/staging/vt6656/card.h deleted +0 -44

44 lines not on this page · raw message

drivers/staging/vt6656/channel.c deleted +0 -77

77 lines not on this page · raw message

drivers/staging/vt6656/channel.h deleted +0 -21
deleted file mode 100644
index 723660e40310..000000000000
@@ -1,21 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
- * All rights reserved.
- *
- * Purpose: Country Regulation Rules header file
- *
- * Author: Lucas Lin
- *
- * Date: Dec 23, 2004
- *
- */
-
-#ifndef _CHANNEL_H_
-#define _CHANNEL_H_
-
-#include "device.h"
-
-void vnt_init_bands(struct vnt_private *priv);
-
-#endif  /* _CHANNEL_H_ */
drivers/staging/vt6656/desc.h deleted +0 -91

91 lines not on this page · raw message

drivers/staging/vt6656/device.h deleted +0 -386

386 lines not on this page · raw message

drivers/staging/vt6656/key.c deleted +0 -142

142 lines not on this page · raw message

drivers/staging/vt6656/key.h deleted +0 -40
deleted file mode 100644
index 6f1d5b4f6da7..000000000000
@@ -1,40 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
- * All rights reserved.
- *
- * Purpose: Implement functions for 802.11i Key management
- *
- * Author: Jerry Chen
- *
- * Date: May 29, 2003
- *
- */
-
-#ifndef __KEY_H__
-#define __KEY_H__
-
-#include "device.h"
-
-#define MAX_KEY_TABLE       11
-
-#define KEY_CTL_WEP         0x00
-#define KEY_CTL_NONE        0x01
-#define KEY_CTL_TKIP        0x02
-#define KEY_CTL_CCMP        0x03
-
-#define VNT_KEY_ONFLY_ALL	0x4000
-#define VNT_KEY_ONFLY		0x8000
-#define VNT_KEY_ALLGROUP	0x04
-#define VNT_KEY_GROUP		0x40
-#define VNT_KEY_PAIRWISE	VNT_KEY_ONFLY
-#define VNT_KEY_GROUP_ADDRESS	(VNT_KEY_ALLGROUP | VNT_KEY_GROUP)
-#define VNT_KEY_DEFAULTKEY	(VNT_KEY_GROUP_ADDRESS | VNT_KEY_ONFLY |\
-				VNT_KEY_ONFLY_ALL)
-
-int vnt_key_init_table(struct vnt_private *priv);
-
-int vnt_set_keys(struct ieee80211_hw *hw, struct ieee80211_sta *sta,
-		 struct ieee80211_vif *vif, struct ieee80211_key_conf *key);
-
-#endif /* __KEY_H__ */
drivers/staging/vt6656/mac.c deleted +0 -183

183 lines not on this page · raw message

drivers/staging/vt6656/mac.h deleted +0 -373

373 lines not on this page · raw message

drivers/staging/vt6656/main_usb.c deleted +0 -1121

592 lines not on this page · raw message

drivers/staging/vt6656/power.c deleted +0 -112

112 lines not on this page · raw message

drivers/staging/vt6656/power.h deleted +0 -23
deleted file mode 100644
index 9f9c70072933..000000000000

Lines of this file are not shown. View the raw message.

drivers/staging/vt6656/rf.c deleted +0 -443

443 lines not on this page · raw message

drivers/staging/vt6656/rf.h deleted +0 -46

46 lines not on this page · raw message

drivers/staging/vt6656/rxtx.c deleted +0 -730

730 lines not on this page · raw message

drivers/staging/vt6656/rxtx.h deleted +0 -178

178 lines not on this page · raw message

drivers/staging/vt6656/usbpipe.c deleted +0 -506

506 lines not on this page · raw message

drivers/staging/vt6656/usbpipe.h deleted +0 -67

67 lines not on this page · raw message

drivers/staging/vt6656/wcmd.c deleted +0 -185

185 lines not on this page · raw message

drivers/staging/vt6656/wcmd.h deleted +0 -48

48 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.43.0

Part of the diff is not shown here. View the raw message.