net: wwan: t7xx: add PM_AUTOSUSPEND_MS_BY_DW5933E for Dell DW5933e
Subsystems (5)
PATCH v3 1/1 net: wwan: t7xx: add PM_AUTOSUSPEND_MS_BY_DW5933E for Dell DW5933e
From: Jack Wu <[email protected]>
Because optimizing the power consumption of Dell DW5933e, Add a new auto suspend time for Dell DW5933e.
The Tests uses a small script to loop through the power_state of Dell DW5933e.
(for example: /sys/bus/pci/devices/0000\:72\:00.0/power_state)
* If Auto suspend is 20 seconds,
test script show power_state have 5% of the time was in D3 state when host don't have data packet transmission.
* Changed auto suspend time to 5 seconds,
test script show power_state have 50% of the time was in D3 state when host don't have data packet transmission.
---
V3:
* supplementary commit information
V2:
* Fix code style error
---
--- drivers/net/wwan/t7xx/t7xx_pci.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
drivers/net/wwan/t7xx/t7xx_pci.c +10 -3
@@ -49,6 +49,7 @@#define PM_SLEEP_DIS_TIMEOUT_MS 20#define PM_ACK_TIMEOUT_MS 1500#define PM_AUTOSUSPEND_MS 20000 +#define PM_AUTOSUSPEND_MS_BY_DW5933E 5000#define PM_RESOURCE_POLL_TIMEOUT_US 10000#define PM_RESOURCE_POLL_STEP_US 100
@@ -174,7 +175,7 @@ static int t7xx_wait_pm_config(struct t7xx_pci_dev *t7xx_dev)return ret; } -static int t7xx_pci_pm_init (struct t7xx_pci_dev *t7xx_dev) +static int t7xx_pci_pm_init (struct t7xx_pci_dev *t7xx_dev,int pm_autosuspend_ms) {struct pci_dev *pdev = t7xx_dev->pdev;
@@ -191,7 +192,7 @@ static int t7xx_pci_pm_init(struct t7xx_pci_dev *t7xx_dev) DPM_FLAG_NO_DIRECT_COMPLETE);iowrite32 (T7XX_L1_BIT (0 ),IREG_BASE (t7xx_dev) +DISABLE_ASPM_LOWPWR ); -pm_runtime_set_autosuspend_delay (&pdev->dev,PM_AUTOSUSPEND_MS ); +pm_runtime_set_autosuspend_delay (&pdev->dev, pm_autosuspend_ms);pm_runtime_use_autosuspend (&pdev->dev);return 0 ;
@@ -824,7 +825,13 @@ static int t7xx_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)IREG_BASE (t7xx_dev) =pcim_iomap_table (pdev)[T7XX_PCI_IREG_BASE ]; t7xx_dev->base_addr.pcie_ext_reg_base =pcim_iomap_table (pdev)[T7XX_PCI_EREG_BASE ]; - ret =t7xx_pci_pm_init (t7xx_dev); +if (id->vendor ==0x14c0 && id->device ==0x4d75 ) { +/* Dell DW5933e */ + ret =t7xx_pci_pm_init (t7xx_dev,PM_AUTOSUSPEND_MS_BY_DW5933E ); + }else { +/* Other devices */ + ret =t7xx_pci_pm_init (t7xx_dev,PM_AUTOSUSPEND_MS ); + }if (ret)return ret;
Signature · 1 line
2.34.1
Quoted 9 lines · On Tue, Oct 15, 2024 at 11:28:20AM +0800, [email protected] wrote:
From: Jack Wu <[email protected]>
Because optimizing the power consumption of Dell DW5933e, Add a new auto suspend time for Dell DW5933e.
The Tests uses a small script to loop through the
power_stateof Dell DW5933e.
(for example: /sys/bus/pci/devices/0000\:72\:00.0/power_state)
Quoted 7 lines
* If Auto suspend is 20 seconds,
test script showpower_statehave 5% of the time was in D3 state when host don't have data packet transmission.* Changed auto suspend time to 5 seconds,
test script showpower_statehave 50% of the time was in D3 state when host don't have data packet transmission.
There are still open questions on V2:
https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/
Andrew
---
pw-bot: cr